Skip to content

Commit 8b28ee1

Browse files
cvxluoclaude
andauthored
ref(grouping): remove frontend grouping configs fetch and fixtures (#112536)
The usage of this was removed in #75092, and it seems like it just lived on forever. Remove it from the frontend. Refs https://linear.app/getsentry/issue/ID-703/grouping-remove-obsolete-grouping-config-endpoints Co-authored-by: Claude <noreply@anthropic.com>
1 parent 64c7b9b commit 8b28ee1

File tree

5 files changed

+1
-89
lines changed

5 files changed

+1
-89
lines changed

static/app/types/event.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export type EventGroupComponent = {
2929
name: string | null;
3030
values: EventGroupComponent[] | string[];
3131
};
32-
export type EventGroupingConfig = {
32+
type EventGroupingConfig = {
3333
base: string | null;
3434
delegates: string[];
3535
id: string;

static/app/views/settings/projectGeneralSettings/index.spec.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import {GroupingConfigsFixture} from 'sentry-fixture/groupingConfigs';
21
import {OrganizationFixture} from 'sentry-fixture/organization';
32
import {ProjectFixture} from 'sentry-fixture/project';
43

@@ -37,7 +36,6 @@ describe('projectGeneralSettings', () => {
3736
securityTokenHeader: 'x-security-header',
3837
verifySSL: true,
3938
});
40-
const groupingConfigs = GroupingConfigsFixture();
4139
let putMock: jest.Mock;
4240
const mockOnChangeSlug = jest.fn();
4341

@@ -50,11 +48,6 @@ describe('projectGeneralSettings', () => {
5048

5149
beforeEach(() => {
5250
MockApiClient.clearMockResponses();
53-
MockApiClient.addMockResponse({
54-
url: `/organizations/${organization.slug}/grouping-configs/`,
55-
method: 'GET',
56-
body: groupingConfigs,
57-
});
5851
MockApiClient.addMockResponse({
5952
url: `/projects/${organization.slug}/${project.slug}/`,
6053
method: 'GET',
@@ -471,11 +464,6 @@ describe('projectGeneralSettings', () => {
471464
beforeEach(() => {
472465
mockOnChangeSlug.mockClear();
473466
MockApiClient.clearMockResponses();
474-
MockApiClient.addMockResponse({
475-
url: '/organizations/org-slug/grouping-configs/',
476-
method: 'GET',
477-
body: groupingConfigs,
478-
});
479467
MockApiClient.addMockResponse({
480468
url: '/projects/org-slug/project-slug/environments/',
481469
method: 'GET',

static/app/views/settings/projectIssueGrouping/index.spec.tsx

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -13,47 +13,15 @@ describe('projectIssueGrouping', () => {
1313
const project = projects[0]!;
1414

1515
it('renders successfully', async () => {
16-
const request = MockApiClient.addMockResponse({
17-
url: `/projects/${organization.slug}/${project.slug}/grouping-configs/`,
18-
body: [],
19-
});
20-
2116
render(<ProjectIssueGrouping />, {
2217
organization,
2318
outletContext: {project},
2419
});
2520

26-
expect(request).toHaveBeenCalled();
2721
expect(await screen.findByText('Issue Grouping')).toBeInTheDocument();
2822
});
2923

30-
it('renders error', async () => {
31-
const request = MockApiClient.addMockResponse({
32-
url: `/projects/${organization.slug}/${project.slug}/grouping-configs/`,
33-
body: {
34-
detail: 'Internal Error',
35-
},
36-
statusCode: 500,
37-
});
38-
39-
render(<ProjectIssueGrouping />, {
40-
organization,
41-
outletContext: {project},
42-
});
43-
44-
expect(request).toHaveBeenCalled();
45-
expect(
46-
await screen.findByText('Failed to load grouping configs')
47-
).toBeInTheDocument();
48-
});
49-
5024
it('shows derived grouping enhancements only for superusers', async () => {
51-
// Mock the API response
52-
MockApiClient.addMockResponse({
53-
url: `/projects/${organization.slug}/${project.slug}/grouping-configs/`,
54-
body: [],
55-
});
56-
5725
// First render with a non-superuser
5826
const {rerender} = render(<ProjectIssueGrouping />, {
5927
organization,

static/app/views/settings/projectIssueGrouping/index.tsx

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,11 @@ import {ExternalLink} from '@sentry/scraps/link';
33
import {hasEveryAccess} from 'sentry/components/acl/access';
44
import {Form} from 'sentry/components/forms/form';
55
import JsonForm from 'sentry/components/forms/jsonForm';
6-
import {LoadingError} from 'sentry/components/loadingError';
7-
import {LoadingIndicator} from 'sentry/components/loadingIndicator';
86
import {SentryDocumentTitle} from 'sentry/components/sentryDocumentTitle';
97
import {fields} from 'sentry/data/forms/projectIssueGrouping';
108
import {t, tct} from 'sentry/locale';
119
import {ProjectsStore} from 'sentry/stores/projectsStore';
12-
import type {EventGroupingConfig} from 'sentry/types/event';
1310
import type {Project} from 'sentry/types/project';
14-
import {getApiUrl} from 'sentry/utils/api/getApiUrl';
15-
import {useApiQuery} from 'sentry/utils/queryClient';
1611
import {routeTitleGen} from 'sentry/utils/routeTitle';
1712
import {useOrganization} from 'sentry/utils/useOrganization';
1813
import {SettingsPageHeader} from 'sentry/views/settings/components/settingsPageHeader';
@@ -24,29 +19,6 @@ export default function ProjectIssueGrouping() {
2419
const organization = useOrganization();
2520
const {project} = useProjectSettingsOutlet();
2621

27-
const queryKey = getApiUrl(
28-
'/projects/$organizationIdOrSlug/$projectIdOrSlug/grouping-configs/',
29-
{
30-
path: {organizationIdOrSlug: organization.slug, projectIdOrSlug: project.slug},
31-
}
32-
);
33-
const {
34-
data: groupingConfigs,
35-
isPending,
36-
isError,
37-
refetch,
38-
} = useApiQuery<EventGroupingConfig[]>([queryKey], {staleTime: 0, gcTime: 0});
39-
40-
if (isPending) {
41-
return <LoadingIndicator />;
42-
}
43-
44-
if (isError) {
45-
return (
46-
<LoadingError message={t('Failed to load grouping configs')} onRetry={refetch} />
47-
);
48-
}
49-
5022
const handleSubmit = (response: Project) => {
5123
// This will update our project context
5224
ProjectsStore.onUpdateSuccess(response);
@@ -58,10 +30,6 @@ export default function ProjectIssueGrouping() {
5830
const hasAccess = hasEveryAccess(['project:write'], {organization, project});
5931

6032
const jsonFormProps = {
61-
additionalFieldProps: {
62-
organization,
63-
groupingConfigs,
64-
},
6533
features: new Set(organization.features),
6634
access,
6735
disabled: !hasAccess,

tests/js/fixtures/groupingConfigs.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)