minor cleanup / info from a bot review

Author: saponifi3d

src/sentry/workflow_engine/defaults/workflows.py

@@ -110,8 +110,7 @@ def create_priority_workflow(org: Organization) -> Workflow:
 
 
 def ensure_default_workflows(project: Project) -> list[Workflow]:
-    workflows: list[Workflow] = []
-    workflows.append(create_priority_workflow(project.organization))
+    workflows = [create_priority_workflow(project.organization)]
     connect_workflows_to_issue_stream(project, workflows)
 
     return workflows

tests/sentry/integrations/slack/tasks/test_tasks.py

@@ -19,7 +19,7 @@
 from sentry.testutils.cases import TestCase
 from sentry.testutils.helpers import install_slack
 from sentry.testutils.skips import requires_snuba
-from sentry.workflow_engine.defaults.workflows import DEFAULT_WORKFLOW_LABEL
+from sentry.workflow_engine.receivers.project_workflows import DEFAULT_RULE_LABEL
 from tests.sentry.integrations.slack.utils.test_mock_slack_response import mock_slack_response
 
 pytestmark = [requires_snuba]
@@ -100,9 +100,7 @@ def test_task_new_rule(self, mock_set_value: MagicMock) -> None:
         with self.tasks():
             find_channel_id_for_rule(**data)
 
-        rule = Rule.objects.exclude(label__in=[DEFAULT_WORKFLOW_LABEL]).get(
-            project_id=self.project.id
-        )
+        rule = Rule.objects.exclude(label__in=[DEFAULT_RULE_LABEL]).get(project_id=self.project.id)
         mock_set_value.assert_called_with("success", rule.id)
         assert rule.label == "New Rule"
         # check that the channel_id got added
@@ -146,9 +144,7 @@ def test_task_new_rule_project_id(self, mock_set_value: MagicMock) -> None:
         with self.tasks():
             find_channel_id_for_rule(**data)
 
-        rule = Rule.objects.exclude(label__in=[DEFAULT_WORKFLOW_LABEL]).get(
-            project_id=self.project.id
-        )
+        rule = Rule.objects.exclude(label__in=[DEFAULT_RULE_LABEL]).get(project_id=self.project.id)
         mock_set_value.assert_called_with("success", rule.id)
         assert rule.label == "New Rule"
         # check that the channel_id got added
@@ -196,7 +192,7 @@ def test_task_new_rule_with_owner(self, mock_set_value: MagicMock) -> None:
         with self.tasks():
             find_channel_id_for_rule(**data)
 
-        rule = Rule.objects.exclude(label__in=[DEFAULT_WORKFLOW_LABEL]).get(
+        rule = Rule.objects.exclude(label__in=[DEFAULT_RULE_LABEL]).get(
             project_id=self.project.id,
         )
         mock_set_value.assert_called_with("success", rule.id)

tests/sentry/receivers/test_onboarding.py

@@ -182,7 +182,7 @@ def test_project_created__default_workflow(self) -> None:
 
         assert len(issue_stream_detectors) == 1
 
-        # Ensuer we have 1 connection to the issue stream, this triggers for both monitors above.
+        # Ensure we have 1 connection to the issue stream, this triggers for both monitors above.
         result_connections = DetectorWorkflow.objects.filter(workflow=workflow)
         assert result_connections.count() == 1
         assert result_connections[0].detector_id == issue_stream_detectors[0].id