Merge branch 'master' into jb/ref/topbar-actions

Author: JonasBa

.github/CODEOWNERS

@@ -439,6 +439,9 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /static/app/components/loading/                @getsentry/app-frontend
 /static/app/components/events/interfaces/      @getsentry/app-frontend
 /static/app/components/forms/                  @getsentry/app-frontend
+/static/app/components/featureShowcase.mdx     @getsentry/app-frontend
+/static/app/components/featureShowcase.spec.tsx @getsentry/app-frontend
+/static/app/components/featureShowcase.tsx     @getsentry/app-frontend
 /static/app/components/markdownTextArea.tsx    @getsentry/app-frontend
 /static/app/locale.tsx                         @getsentry/app-frontend
 ## End of Frontend

knip.config.ts

@@ -25,6 +25,8 @@ const productionEntryPoints = [
   'static/app/components/pipeline/**/*.{js,ts,tsx}',
   // TODO: Remove when used
   'static/app/views/seerExplorer/contexts/**/*.{js,ts,tsx}',
+  // TODO: Remove when used
+  'static/app/components/featureShowcase.tsx',
 ];
 
 const testingEntryPoints = [

pyproject.toml

@@ -474,6 +474,7 @@ module = [
   "sentry.identity.vsts_extension.*",
   "sentry.incidents.endpoints.bases",
   "sentry.incidents.handlers.*",
+  "sentry.incidents.metric_issue_detector",
   "sentry.incidents.utils.*",
   "sentry.ingest.slicing",
   "sentry.insights.migrations.*",

src/sentry/api/endpoints/organization_events.py

@@ -25,7 +25,6 @@
 from sentry.apidocs.parameters import GlobalParams, OrganizationParams, VisibilityParams
 from sentry.apidocs.utils import inline_sentry_response_serializer
 from sentry.discover.models import DiscoverSavedQuery, DiscoverSavedQueryTypes
-from sentry.exceptions import InvalidParams
 from sentry.models.dashboard_widget import DashboardWidget, DashboardWidgetTypes
 from sentry.models.organization import Organization
 from sentry.ratelimits.config import RateLimitConfig
@@ -194,8 +193,6 @@ def get(self, request: Request, organization: Organization) -> Response:
                     },
                 }
             )
-        except InvalidParams as err:
-            raise ParseError(detail=str(err))
 
         batch_features = self.get_features(organization, request)
 

src/sentry/api/endpoints/source_map_debug_blue_thunder_edition.py

@@ -1,6 +1,7 @@
 from typing import Literal, TypedDict
 
 import sentry_sdk
+from django.db.models import Exists, OuterRef
 from django.utils.encoding import force_bytes, force_str
 from drf_spectacular.utils import extend_schema
 from packaging.version import Version
@@ -20,6 +21,7 @@
     ArtifactBundle,
     ArtifactBundleArchive,
     DebugIdArtifactBundle,
+    ProjectArtifactBundle,
     ReleaseArtifactBundle,
     SourceFileType,
 )
@@ -179,11 +181,6 @@ def get(self, request: Request, project: Project, event_id: str) -> Response:
             has_uploaded_artifact_bundle_with_release = ReleaseArtifactBundle.objects.filter(
                 organization_id=project.organization_id, release_name=release.version
             ).exists()
-        has_uploaded_some_artifact_with_a_debug_id = DebugIdArtifactBundle.objects.filter(
-            organization_id=project.organization_id,
-            artifact_bundle__projectartifactbundle__project_id=project.id,
-        ).exists()
-
         debug_images = get_path(event_data, "debug_meta", "images")
         debug_images = debug_images if debug_images is not None else []
 
@@ -212,6 +209,23 @@ def get(self, request: Request, project: Project, event_id: str) -> Response:
             ):
                 debug_ids_with_uploaded_source_map.add(str(debug_id_artifact_bundle.debug_id))
 
+        has_uploaded_some_artifact_with_a_debug_id = bool(
+            debug_ids_with_uploaded_source_file or debug_ids_with_uploaded_source_map
+        ) or (
+            DebugIdArtifactBundle.objects.filter(
+                organization_id=project.organization_id,
+            )
+            .filter(
+                Exists(
+                    ProjectArtifactBundle.objects.filter(
+                        artifact_bundle_id=OuterRef("artifact_bundle_id"),
+                        project_id=project.id,
+                    )
+                )
+            )
+            .exists()
+        )
+
         # Get all abs paths and query for their existence so that we can match release artifacts
         release_process_abs_path_data = {}
         if release is not None:

src/sentry/api/serializers/rest_framework/dashboard.py

@@ -862,6 +862,19 @@ def update_widgets(self, instance, widget_data):
                     # Create a new widget.
                     self.create_widget(instance, data)
                 else:
+                    sentry_sdk.set_context(
+                        "dashboard",
+                        {
+                            "org_slug": instance.organization.slug,
+                            "dashboard_id": instance.id,
+                            "widget_id": widget_id,
+                            "existing_widget_ids": list(existing_map.keys()),
+                            "requested_widget_ids": widget_ids,
+                        },
+                    )
+                    sentry_sdk.capture_message(
+                        "Attempted to update widget not belonging to dashboard."
+                    )
                     raise serializers.ValidationError(
                         "You cannot update widgets that are not part of this dashboard."
                     )

src/sentry/charts/types.py

@@ -24,6 +24,7 @@ class ChartType(Enum):
     SLACK_PERFORMANCE_FUNCTION_REGRESSION = "slack:performance.functionRegression"
     SLACK_METRIC_DETECTOR_EVENTS = "slack:metricDetector.events"
     SLACK_METRIC_DETECTOR_SESSIONS = "slack:metricDetector.sessions"
+    SLACK_EXPLORE_LINE = "slack:explore.line"
 
 
 class ChartSize(TypedDict):

src/sentry/event_manager.py

@@ -65,7 +65,6 @@
 from sentry.grouping.ingest.hashing import (
     find_grouphash_with_group,
     get_or_create_grouphashes,
-    maybe_run_background_grouping,
     maybe_run_secondary_grouping,
     run_primary_grouping,
 )
@@ -1358,11 +1357,6 @@ def assign_event_to_group(
 
     # From here on out, we're just doing housekeeping
 
-    # Background grouping is a way for us to get performance metrics for a new
-    # config without having it actually affect on how events are grouped. It runs
-    # either before or after the main grouping logic, depending on the option value.
-    maybe_run_background_grouping(project, job)
-
     record_hash_calculation_metrics(
         project, primary.config, primary.hashes, secondary.config, secondary.hashes, result
     )

src/sentry/exceptions.py

@@ -1,4 +1,5 @@
 from django.core.exceptions import SuspiciousOperation
+from rest_framework.exceptions import ParseError
 
 
 class InvalidData(Exception):
@@ -89,5 +90,8 @@ def __init__(
         self.tombstone_id = tombstone_id
 
 
-class InvalidParams(Exception):
+class InvalidParams(ParseError):
+    """Inherits from ParseError so DRF automatically returns a 400 response
+    when this exception is unhandled in a view."""
+
     pass

src/sentry/features/temporary.py

@@ -317,6 +317,8 @@ def register_temporary_features(manager: FeatureManager) -> None:
     manager.add("organizations:seer-explorer-context-engine-fe-override-ui-flag", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable code editing tools in Seer Explorer chat
     manager.add("organizations:seer-explorer-chat-coding", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
+    # Enable code mode tools (sentry_api_search/execute) in Seer Explorer
+    manager.add("organizations:seer-explorer-code-mode-tools", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable structured LLM context (JSON snapshot) instead of ASCII DOM snapshot
     manager.add("organizations:context-engine-structured-page-context", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable the Seer Overview sections for Seat-Based users
@@ -382,6 +384,8 @@ def register_temporary_features(manager: FeatureManager) -> None:
     manager.add("organizations:data-browsing-widget-unfurl", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable dual-write of Seer project preferences to Sentry DB and Seer API
     manager.add("organizations:seer-project-settings-dual-write", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Enable reading of Seer project preferences from Sentry DB instead of Seer API
+    manager.add("organizations:seer-project-settings-read-from-sentry", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable public RPC endpoint for local seer development
     manager.add("organizations:seer-public-rpc", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Organizations on the old usage-based (v0) Seer plan