Skip to content

Commit 850d6b2

Browse files
committed
iterate
1 parent b4258f6 commit 850d6b2

File tree

3 files changed

+9
-109
lines changed

3 files changed

+9
-109
lines changed

.github/workflows/backend_selective_testing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
steps:
4646
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
4747
with:
48-
# fetching changed files in select-tests.py requires a full checkout for github.base_ref?
48+
# fetching changed files in select-tests.py requires a full checkout?
4949
fetch-depth: 0
5050

5151
# TODO: Replace with Gcloud download
@@ -64,7 +64,7 @@ jobs:
6464
- name: Select Tests
6565
id: select-tests
6666
env:
67-
GITHUB_PR_BASE_REF: ${{ github.base_ref }}
67+
GITHUB_PR_BASE_REF: ${{ ${{ github.event.pull_request.base.sha }} }}
6868
COVERAGE_DB_PATH: .coverage/.coverage.combined
6969
run: |
7070
python3 .github/workflows/scripts/select-tests.py

.github/workflows/scripts/calculate-backend-test-shards.py

Lines changed: 0 additions & 105 deletions
This file was deleted.

.github/workflows/scripts/select-tests.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@
1111
MAX_SHARDS = 22
1212
DEFAULT_SHARDS = 22
1313

14-
PYTEST_IGNORED_FILES = [
14+
PYTEST_IGNORED_FILES = (
1515
# the pytest code itself is not part of the test suite but will be referenced by most tests
1616
"sentry/testutils/pytest/sentry.py",
17-
]
17+
)
18+
19+
IGNORED_NODEIDS = ("tests/sentry/test_wsgi.py::test_wsgi_init",)
1820

1921

2022
def executed_lines(bitblob: bytes) -> set[int]:
@@ -68,6 +70,9 @@ def select_tests(coverage_db_path: str, changed_files: list[str]):
6870
continue
6971

7072
test_nodeid = test_context.partition("|")[0]
73+
if test_nodeid in IGNORED_NODEIDS:
74+
continue
75+
7176
test_nodeids.add(test_nodeid)
7277

7378
return test_nodeids

0 commit comments

Comments
 (0)