Skip to content

Commit 83efc2e

Browse files
fix(preprod): Fix mypy errors in snapshot auto-approval
1 parent 094fea0 commit 83efc2e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/sentry/preprod/snapshots/tasks.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import orjson
88
from django.db import IntegrityError
99
from django.utils import timezone
10+
from objectstore_client import Session
1011
from objectstore_client.client import RequestError
1112
from pydantic import ValidationError
1213
from taskbroker_client.retry import Retry
@@ -134,7 +135,7 @@ def _build_comparison_fingerprints(manifest: ComparisonManifest) -> set[tuple[st
134135
def _try_auto_approve_snapshot(
135136
head_artifact: PreprodArtifact,
136137
comparison_manifest: ComparisonManifest,
137-
session: object,
138+
session: Session,
138139
) -> bool:
139140
cc = head_artifact.commit_comparison
140141
if not cc or not cc.pr_number or not cc.head_repo_name:

tests/sentry/preprod/snapshots/test_auto_approve.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,7 @@ def test_auto_approves_when_fingerprints_match(self):
311311
approval_status=PreprodComparisonApproval.ApprovalStatus.APPROVED,
312312
)
313313
assert approval.approved_by_id is None
314+
assert approval.extras is not None
314315
assert approval.extras["auto_approval"] is True
315316
assert approval.extras["prev_approved_artifact_id"] == sibling.id
316317

0 commit comments

Comments
 (0)