Merge branch 'master' into docs/dotnet-stable-metrics-apis

Author: Flash0ver

.github/CODEOWNERS

@@ -677,6 +677,7 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /tests/sentry/issues/test_search_issues_dataset.py          @getsentry/issue-workflow
 /tests/sentry/issues/test_status_change_consumer.py         @getsentry/issue-detection-backend
 /tests/sentry/issues/test_status_change.py                  @getsentry/issue-detection-backend
+/tests/sentry/processing_errors/                            @getsentry/issue-detection-backend
 /tests/sentry/search/                                       @getsentry/issue-workflow
 /tests/sentry/seer/similarity/                              @getsentry/issue-detection-backend
 /tests/sentry/seer/supergroups/                             @getsentry/issue-detection-backend

.github/codeowners-coverage-baseline.txt

@@ -2370,12 +2370,6 @@ tests/sentry/processing/backpressure/test_checking.py
 tests/sentry/processing/backpressure/test_monitoring.py
 tests/sentry/processing/backpressure/test_redis.py
 tests/sentry/processing/eventstore/test_processing.py
-tests/sentry/processing_errors/__init__.py
-tests/sentry/processing_errors/eap/__init__.py
-tests/sentry/processing_errors/eap/test_producer.py
-tests/sentry/processing_errors/test_detection.py
-tests/sentry/processing_errors/test_grouptype.py
-tests/sentry/processing_errors/test_provisioning.py
 tests/sentry/projectoptions/__init__.py
 tests/sentry/projectoptions/test_basic.py
 tests/sentry/projects/project_rules/test_creator.py

src/sentry/api/bases/rule.py

@@ -42,6 +42,10 @@ def convert_args(
 
 
 class WorkflowEngineRuleEndpoint(RuleEndpoint):
+    # Subclasses may set a per-method granular flag (e.g. for GET) that is OR'd
+    # with the broad workflow-engine-rule-serializers flag.
+    workflow_engine_method_flags: dict[str, str] = {}
+
     def convert_args(
         self, request: Request, rule_id: str, *args: Any, **kwargs: Any
     ) -> tuple[Any, Any]:
@@ -51,7 +55,11 @@ def convert_args(
         if not rule_id.isdigit():
             raise ResourceDoesNotExist
 
-        if features.has("organizations:workflow-engine-rule-serializers", project.organization):
+        method_flag = self.workflow_engine_method_flags.get(request.method or "")
+        use_workflow_engine = features.has(
+            "organizations:workflow-engine-rule-serializers", project.organization
+        ) or (method_flag is not None and features.has(method_flag, project.organization))
+        if use_workflow_engine:
             try:
                 arw = AlertRuleWorkflow.objects.get(
                     rule_id=rule_id, workflow__organization=project.organization

src/sentry/api/endpoints/project_rule_details.py

@@ -103,6 +103,9 @@ class ProjectRuleDetailsPutSerializer(serializers.Serializer):
 @extend_schema(tags=["Alerts"])
 @cell_silo_endpoint
 class ProjectRuleDetailsEndpoint(WorkflowEngineRuleEndpoint):
+    workflow_engine_method_flags = {
+        "GET": "organizations:workflow-engine-projectruledetailsendpoint-get",
+    }
     publish_status = {
         "DELETE": ApiPublishStatus.PUBLIC,
         "GET": ApiPublishStatus.PUBLIC,

src/sentry/api/urls.py

@@ -560,6 +560,9 @@
 from sentry.seer.supergroups.endpoints.organization_supergroups import (
     OrganizationSupergroupsEndpoint,
 )
+from sentry.seer.supergroups.endpoints.organization_supergroups_by_group import (
+    OrganizationSupergroupsByGroupEndpoint,
+)
 from sentry.sentry_apps.api.endpoints.group_external_issue_details import (
     GroupExternalIssueDetailsEndpoint,
 )
@@ -2418,6 +2421,11 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
         OrganizationSupergroupsEndpoint.as_view(),
         name="sentry-api-0-organization-supergroups",
     ),
+    re_path(
+        r"^(?P<organization_id_or_slug>[^/]+)/seer/supergroups/by-group/$",
+        OrganizationSupergroupsByGroupEndpoint.as_view(),
+        name="sentry-api-0-organization-supergroups-by-group",
+    ),
     re_path(
         r"^(?P<organization_id_or_slug>[^/]+)/seer/supergroups/(?P<supergroup_id>[^/]+)/$",
         OrganizationSupergroupDetailsEndpoint.as_view(),

src/sentry/features/temporary.py

@@ -434,6 +434,9 @@ def register_temporary_features(manager: FeatureManager) -> None:
     # Use workflow engine exclusively for ProjectRulesEndpoint.get results.
     # See src/sentry/workflow_engine/docs/legacy_backport.md for context.
     manager.add("organizations:workflow-engine-projectrulesendpoint-get", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
+    # Use workflow engine exclusively for ProjectRuleDetailsEndpoint.get results.
+    # See src/sentry/workflow_engine/docs/legacy_backport.md for context.
+    manager.add("organizations:workflow-engine-projectruledetailsendpoint-get", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
     # Enable metric detector limits by plan type
     manager.add("organizations:workflow-engine-metric-detector-limit", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable EventUniqueUserFrequencyConditionWithConditions special alert condition

src/sentry/hybridcloud/rpc/resolvers.py

@@ -37,17 +37,14 @@ def _get_from_mapping(**query: Any) -> Cell:
 
 @dataclass(frozen=True)
 class ByCellName(CellResolutionStrategy):
-    """Resolve from a `str` parameter representing a cell's name.
-
-    Accepts either ``cell_name`` or ``region_name`` to ease the migration of
-    service method parameters from the old name to the new one.
+    """
+    Resolve from a `str` parameter representing a cell's name.
     """
 
     parameter_name: str = "cell_name"
 
     def resolve(self, arguments: ArgumentDict) -> Cell:
-        # TODO(cells): Temporary fall back to "region_name" while service methods are being migrated.
-        cell_name = arguments.get("region_name") or arguments[self.parameter_name]
+        cell_name = arguments[self.parameter_name]
         return get_cell_by_name(cell_name)
 
 

src/sentry/hybridcloud/services/control_organization_provisioning/impl.py

@@ -89,11 +89,11 @@ def _validate_organization_mapping_belongs_to_user(
             return False
 
     @staticmethod
-    def _generate_org_snowflake_id(region_name: str) -> int:
+    def _generate_org_snowflake_id() -> int:
         return generate_snowflake_id(Organization.snowflake_redis_key)
 
     @staticmethod
-    def _generate_org_slug(region_name: str, slug: str) -> str:
+    def _generate_org_slug(slug: str) -> str:
         slug_base = slug.replace("_", "-").strip("-")
         surrogate_org_slug = OrganizationSlugReservation()
         slugify_instance(surrogate_org_slug, slug_base, reserved=RESERVED_ORGANIZATION_SLUGS)
@@ -133,12 +133,10 @@ def provision_organization(
         org_provision_args: OrganizationProvisioningOptions,
     ) -> RpcOrganizationSlugReservation:
         # Generate a new non-conflicting slug and org ID
-        org_id = self._generate_org_snowflake_id(region_name=cell_name)
-        slug = self._generate_org_slug(
-            region_name=cell_name, slug=org_provision_args.provision_options.slug
-        )
+        org_id = self._generate_org_snowflake_id()
+        slug = self._generate_org_slug(slug=org_provision_args.provision_options.slug)
 
-        # Generate a provisioning outbox for the region and drain
+        # Generate a provisioning outbox for the cell and drain
         updated_provision_options = deepcopy(org_provision_args.provision_options)
         updated_provision_options.slug = slug
         provision_payload = OrganizationProvisioningOptions(
@@ -209,7 +207,7 @@ def update_organization_slug(
 
         slug_base = desired_slug
         if not require_exact:
-            slug_base = self._generate_org_slug(region_name=cell_name, slug=slug_base)
+            slug_base = self._generate_org_slug(slug=slug_base)
 
         try:
             with outbox_context(
@@ -296,7 +294,7 @@ def bulk_create_organization_slug_reservations(
         with outbox_context(transaction.atomic(router.db_for_write(OrganizationSlugReservation))):
             for org_id, slug in slug_mapping.items():
                 slug_reservation = OrganizationSlugReservation(
-                    slug=self._generate_org_slug(slug=slug, region_name=cell_name),
+                    slug=self._generate_org_slug(slug=slug),
                     organization_id=org_id,
                     reservation_type=OrganizationSlugReservationType.TEMPORARY_RENAME_ALIAS.value,
                     user_id=-1,

src/sentry/hybridcloud/services/control_organization_provisioning/service.py

@@ -45,11 +45,11 @@ def update_organization_slug(
     ) -> RpcOrganizationSlugReservation:
         """
         Updates an organization's slug via an outbox based confirmation flow to ensure that the control
-        and region silos stay in sync.
+        and cell silos stay in sync.
 
         Initially, the organization slug reservation is updated in control silo, which generates a replica
-        outbox to the desired region in order to ensure that a slug change in control _will eventually_
-        result in a slug change on the region side.
+        outbox to the desired cell in order to ensure that a slug change in control _will eventually_
+        result in a slug change on the cell side.
 
         :param cell_name: The cell where the organization exists
         :param organization_id: the ID of the organization whose slug to change

src/sentry/hybridcloud/services/organization_mapping/impl.py

@@ -61,7 +61,7 @@ def _check_organization_mapping_integrity(
 
         if not update.cell_name:
             capture_exception(
-                OrganizationMappingConsistencyException("Organization mapping must have a region")
+                OrganizationMappingConsistencyException("Organization mapping must have a cell")
             )
             return False
 
@@ -81,11 +81,11 @@ def _check_organization_mapping_integrity(
             )
             return False
 
-        org_slug_regions_set = {org_slug.cell_name for org_slug in org_slugs}
-        if update.cell_name not in org_slug_regions_set:
+        org_slug_cells_set = {org_slug.cell_name for org_slug in org_slugs}
+        if update.cell_name not in org_slug_cells_set:
             capture_exception(
                 OrganizationMappingConsistencyException(
-                    "Mismatched Slug Reservation and Organization Regions"
+                    "Mismatched Slug Reservation and Organization Cells"
                 )
             )
             return False