fix

Author: trevor-e

src/sentry/tasks/seer/night_shift/agentic_triage.py

@@ -29,6 +29,10 @@ class _TriageVerdict(pydantic.BaseModel):
 class _TriageResponse(pydantic.BaseModel):
     verdicts: list[_TriageVerdict]
 
+    @pydantic.validator("verdicts")
+    def filter_skips(cls, v: list[_TriageVerdict]) -> list[_TriageVerdict]:
+        return [verdict for verdict in v if verdict.action != TriageAction.SKIP]
+
 
 def agentic_triage_strategy(
     projects: Sequence[Project],
@@ -87,7 +91,7 @@ def _triage_candidates(
             )
             return []
 
-        triage_response: _TriageResponse = _TriageResponse.model_validate_json(content)
+        triage_response = _TriageResponse.parse_raw(content)
     except Exception:
         logger.exception(
             "night_shift.triage_request_error",

src/sentry/tasks/seer/night_shift/cron.py

@@ -13,7 +13,7 @@
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings
 from sentry.seer.models.project_repository import SeerProjectRepository
 from sentry.tasks.base import instrumented_task
-from sentry.tasks.seer.night_shift.simple_triage import fixability_score_strategy
+from sentry.tasks.seer.night_shift.agentic_triage import agentic_triage_strategy
 from sentry.taskworker.namespaces import seer_tasks
 from sentry.utils.iterators import chunked
 from sentry.utils.query import RangeQuerySetWrapper
@@ -98,7 +98,7 @@ def run_night_shift_for_org(organization_id: int) -> None:
         )
         return
 
-    candidates = fixability_score_strategy(eligible_projects)
+    candidates = agentic_triage_strategy(eligible_projects, organization)
 
     logger.info(
         "night_shift.candidates_selected",

src/sentry/tasks/seer/night_shift/models.py

@@ -9,6 +9,7 @@
 class TriageAction(enum.StrEnum):
     AUTOFIX = "autofix"
     ROOT_CAUSE_ONLY = "root_cause_only"
+    SKIP = "skip"
 
 
 @dataclass

tests/sentry/tasks/seer/test_night_shift.py

@@ -1,4 +1,4 @@
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
 
 from django.utils import timezone
 
@@ -14,6 +14,16 @@
 from sentry.testutils.cases import SnubaTestCase, TestCase
 from sentry.testutils.helpers.datetime import before_now
 from sentry.testutils.pytest.fixtures import django_db_all
+from sentry.utils import json
+
+
+def _mock_llm_response(group_ids: list[int], action: str = "autofix") -> MagicMock:
+    verdicts = [{"group_id": gid, "action": action, "reason": "test"} for gid in group_ids]
+    content = json.dumps({"verdicts": verdicts})
+    response = MagicMock()
+    response.status = 200
+    response.data = json.dumps({"content": content}).encode()
+    return response
 
 
 @django_db_all
@@ -152,7 +162,13 @@ def test_selects_candidates_and_skips_triggered(self) -> None:
             seer_autofix_last_triggered=timezone.now(),
         )
 
-        with patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger:
+        with (
+            patch(
+                "sentry.tasks.seer.night_shift.agentic_triage.make_llm_generate_request",
+                return_value=_mock_llm_response([high_fix.id, low_fix.id]),
+            ),
+            patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger,
+        ):
             run_night_shift_for_org(org.id)
 
             call_extra = mock_logger.info.call_args.kwargs["extra"]
@@ -175,7 +191,13 @@ def test_global_ranking_across_projects(self) -> None:
             project_b, "high-group", seer_fixability_score=0.95
         )
 
-        with patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger:
+        with (
+            patch(
+                "sentry.tasks.seer.night_shift.agentic_triage.make_llm_generate_request",
+                return_value=_mock_llm_response([high_group.id, low_group.id]),
+            ),
+            patch("sentry.tasks.seer.night_shift.cron.logger") as mock_logger,
+        ):
             run_night_shift_for_org(org.id)
 
             candidates = mock_logger.info.call_args.kwargs["extra"]["candidates"]