more test coverage

Author: srest2021

src/sentry/seer/autofix/utils.py

@@ -734,18 +734,14 @@ def read_preference_from_sentry_db(project: Project) -> SeerProjectPreference |
             handoff_point=handoff_point,
             target=handoff_target,
             integration_id=handoff_integration_id,
-            auto_create_pr=project.get_option(
-                "sentry:seer_automation_handoff_auto_create_pr", False
-            ),
+            auto_create_pr=project.get_option("sentry:seer_automation_handoff_auto_create_pr"),
         )
 
     return SeerProjectPreference(
         organization_id=project.organization_id,
         project_id=project.id,
         repositories=repo_definitions,
-        automated_run_stopping_point=project.get_option(
-            "sentry:seer_automated_run_stopping_point", SEER_AUTOMATED_RUN_STOPPING_POINT_DEFAULT
-        ),
+        automated_run_stopping_point=project.get_option("sentry:seer_automated_run_stopping_point"),
         automation_handoff=automation_handoff,
     )
 

tests/sentry/seer/autofix/test_autofix_utils.py

@@ -1234,6 +1234,12 @@ def setUp(self):
             external_id="ext123",
             name="test-org/test-repo",
         )
+        self.repo2 = self.create_repo(
+            project=self.project,
+            provider="integrations:github",
+            external_id="ext456",
+            name="test-org/other-repo",
+        )
 
     def test_unconfigured_project_returns_none(self):
         result = read_preference_from_sentry_db(self.project)
@@ -1252,20 +1258,29 @@ def test_project_with_repos_only(self):
             tag_value="production",
             branch_name="release",
         )
+        SeerProjectRepository.objects.create(
+            project=self.project,
+            repository=self.repo2,
+            branch_name="develop",
+        )
 
         result = read_preference_from_sentry_db(self.project)
         assert result is not None
         assert result.project_id == self.project.id
         assert result.organization_id == self.organization.id
-        assert len(result.repositories) == 1
-        assert result.repositories[0].owner == "test-org"
-        assert result.repositories[0].name == "test-repo"
-        assert result.repositories[0].branch_name == "main"
-        assert result.repositories[0].instructions == "Be helpful"
-        assert len(result.repositories[0].branch_overrides) == 1
-        assert result.repositories[0].branch_overrides[0].tag_name == "environment"
-        assert result.repositories[0].branch_overrides[0].tag_value == "production"
-        assert result.repositories[0].branch_overrides[0].branch_name == "release"
+        assert len(result.repositories) == 2
+        repo_by_name = {r.name: r for r in result.repositories}
+        assert repo_by_name["test-repo"].owner == "test-org"
+        assert repo_by_name["test-repo"].branch_name == "main"
+        assert repo_by_name["test-repo"].instructions == "Be helpful"
+        assert len(repo_by_name["test-repo"].branch_overrides) == 1
+        assert repo_by_name["test-repo"].branch_overrides[0].tag_name == "environment"
+        assert repo_by_name["test-repo"].branch_overrides[0].tag_value == "production"
+        assert repo_by_name["test-repo"].branch_overrides[0].branch_name == "release"
+        assert repo_by_name["other-repo"].owner == "test-org"
+        assert repo_by_name["other-repo"].branch_name == "develop"
+        assert repo_by_name["other-repo"].instructions is None
+        assert repo_by_name["other-repo"].branch_overrides == []
         assert result.automated_run_stopping_point == "code_changes"
         assert result.automation_handoff is None
 
@@ -1294,6 +1309,58 @@ def test_project_with_handoff_only(self):
         assert result.automation_handoff.integration_id == 42
         assert result.automation_handoff.auto_create_pr is True
 
+    def test_project_with_repos_and_options(self):
+        SeerProjectRepository.objects.create(
+            project=self.project,
+            repository=self.repo,
+            branch_name="main",
+        )
+        SeerProjectRepository.objects.create(
+            project=self.project,
+            repository=self.repo2,
+            branch_name="develop",
+        )
+        self.project.update_option("sentry:seer_automated_run_stopping_point", "open_pr")
+        self.project.update_option("sentry:seer_automation_handoff_point", "root_cause")
+        self.project.update_option(
+            "sentry:seer_automation_handoff_target", "cursor_background_agent"
+        )
+        self.project.update_option("sentry:seer_automation_handoff_integration_id", 42)
+
+        result = read_preference_from_sentry_db(self.project)
+        assert result is not None
+        assert len(result.repositories) == 2
+        assert result.automated_run_stopping_point == "open_pr"
+        assert result.automation_handoff is not None
+        assert result.automation_handoff.handoff_point == "root_cause"
+        assert result.automation_handoff.target == "cursor_background_agent"
+        assert result.automation_handoff.integration_id == 42
+        assert result.automation_handoff.auto_create_pr is False
+
+    def test_excludes_other_projects_data(self):
+        other_project = self.create_project(organization=self.organization)
+        other_repo = self.create_repo(
+            project=other_project,
+            provider="integrations:github",
+            external_id="ext789",
+            name="test-org/other-project-repo",
+        )
+        SeerProjectRepository.objects.create(
+            project=other_project, repository=other_repo, branch_name="main"
+        )
+        other_project.update_option("sentry:seer_automated_run_stopping_point", "open_pr")
+
+        SeerProjectRepository.objects.create(
+            project=self.project, repository=self.repo, branch_name="develop"
+        )
+        self.project.update_option("sentry:seer_automated_run_stopping_point", "root_cause")
+
+        result = read_preference_from_sentry_db(self.project)
+        assert result is not None
+        assert len(result.repositories) == 1
+        assert result.repositories[0].name == "test-repo"
+        assert result.automated_run_stopping_point == "root_cause"
+
     def test_partial_handoff_returns_none_handoff(self):
         self.project.update_option("sentry:seer_automation_handoff_point", "root_cause")
 
@@ -1315,6 +1382,12 @@ def setUp(self):
             external_id="ext123",
             name="test-org/test-repo",
         )
+        self.repo2 = self.create_repo(
+            project=self.project1,
+            provider="integrations:github",
+            external_id="ext456",
+            name="test-org/other-repo",
+        )
 
     def test_empty_project_ids_returns_empty(self):
         result = bulk_read_preferences_from_sentry_db(self.organization.id, [])
@@ -1328,6 +1401,9 @@ def test_bulk_returns_correct_preferences(self):
         SeerProjectRepository.objects.create(
             project=self.project1, repository=self.repo, branch_name="main"
         )
+        SeerProjectRepository.objects.create(
+            project=self.project1, repository=self.repo2, branch_name="develop"
+        )
         self.project2.update_option("sentry:seer_automated_run_stopping_point", "open_pr")
         self.project2.update_option("sentry:seer_automation_handoff_point", "root_cause")
         self.project2.update_option(
@@ -1342,8 +1418,8 @@ def test_bulk_returns_correct_preferences(self):
 
         pref1 = result[self.project1.id]
         assert pref1 is not None
-        assert len(pref1.repositories) == 1
-        assert pref1.repositories[0].branch_name == "main"
+        assert len(pref1.repositories) == 2
+        assert {r.branch_name for r in pref1.repositories} == {"main", "develop"}
         assert pref1.automated_run_stopping_point == "code_changes"
         assert pref1.automation_handoff is None