fix(cmdk): Filter out async resource actions with 0 results

Resource actions (those with a `resource` prop) are async group
containers — they only make sense when they have children. When an
async resource returns no results, the parent node should not appear
in the list.

Previously the browse-mode filter only ran on top-level nodes, so a
resource action nested inside a group would still be pushed to the
results list. The search-mode path had no guard at all, so a resource
action whose label matched the query would show up as a (non-functional)
clickable item.

Fix both paths and add tests for top-level, nested, and search-mode
variants of the 0-results case.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: JonasBa

static/app/components/commandPalette/ui/commandPalette.spec.tsx

@@ -24,6 +24,7 @@ jest.mock('@tanstack/react-virtual', () => ({
 
 import {closeModal} from 'sentry/actionCreators/modal';
 import * as modalActions from 'sentry/actionCreators/modal';
+import type {CommandPaletteAction} from 'sentry/components/commandPalette/types';
 import {CommandPaletteProvider} from 'sentry/components/commandPalette/ui/cmdk';
 import {CMDKAction} from 'sentry/components/commandPalette/ui/cmdk';
 import type {CMDKActionData} from 'sentry/components/commandPalette/ui/cmdk';
@@ -647,4 +648,84 @@ describe('CommandPalette', () => {
       expect(screen.getAllByRole('option')).toHaveLength(1);
     });
   });
+
+  describe('resource action with 0 results', () => {
+    function emptyResource() {
+      return {
+        queryKey: ['test-empty-resource'] as const,
+        queryFn: (): CommandPaletteAction[] => [],
+      };
+    }
+
+    it('is omitted from browse mode at the top level', async () => {
+      render(
+        <CommandPaletteProvider>
+          <CMDKAction display={{label: 'Async Resource'}} resource={emptyResource}>
+            {data =>
+              data.map((_, i) => (
+                <CMDKAction key={i} to="/x/" display={{label: 'Result'}} />
+              ))
+            }
+          </CMDKAction>
+          <CMDKAction display={{label: 'Real Action'}} onAction={jest.fn()} />
+          <CommandPalette onAction={jest.fn()} />
+        </CommandPaletteProvider>
+      );
+
+      await screen.findByRole('option', {name: 'Real Action'});
+      expect(
+        screen.queryByRole('option', {name: 'Async Resource'})
+      ).not.toBeInTheDocument();
+    });
+
+    it('is omitted from browse mode when nested inside a group', async () => {
+      render(
+        <CommandPaletteProvider>
+          <CMDKAction display={{label: 'Group'}}>
+            <CMDKAction display={{label: 'Async Resource'}} resource={emptyResource}>
+              {data =>
+                data.map((_, i) => (
+                  <CMDKAction key={i} to="/x/" display={{label: 'Result'}} />
+                ))
+              }
+            </CMDKAction>
+            <CMDKAction display={{label: 'Real Action'}} onAction={jest.fn()} />
+          </CMDKAction>
+          <CommandPalette onAction={jest.fn()} />
+        </CommandPaletteProvider>
+      );
+
+      await screen.findByRole('option', {name: 'Real Action'});
+      expect(
+        screen.queryByRole('option', {name: 'Async Resource'})
+      ).not.toBeInTheDocument();
+    });
+
+    it('is omitted from search mode even when the label matches the query', async () => {
+      render(
+        <CommandPaletteProvider>
+          <CMDKAction display={{label: 'Async Resource'}} resource={emptyResource}>
+            {data =>
+              data.map((_, i) => (
+                <CMDKAction key={i} to="/x/" display={{label: 'Result'}} />
+              ))
+            }
+          </CMDKAction>
+          <CMDKAction display={{label: 'Other'}} onAction={jest.fn()} />
+          <CommandPalette onAction={jest.fn()} />
+        </CommandPaletteProvider>
+      );
+
+      const input = await screen.findByRole('textbox', {name: 'Search commands'});
+      await userEvent.type(input, 'async');
+
+      // Wait for search to take effect — 'Other' should be filtered out since it doesn't match
+      await waitFor(() => {
+        expect(screen.queryByRole('option', {name: 'Other'})).not.toBeInTheDocument();
+      });
+      expect(
+        screen.queryByRole('option', {name: 'Async Resource'})
+      ).not.toBeInTheDocument();
+    });
+  });
 });

static/app/components/commandPalette/ui/commandPalette.tsx

@@ -480,6 +480,15 @@ function flattenActions(
       results.push({...node, listItemType: isGroup ? 'section' : 'action'});
       if (isGroup) {
         for (const child of node.children) {
+          const childIsGroup = child.children.length > 0;
+          if (
+            !childIsGroup &&
+            'resource' in child &&
+            !('to' in child) &&
+            !('onAction' in child)
+          ) {
+            continue;
+          }
           results.push({...child, listItemType: 'action'});
         }
       }
@@ -530,6 +539,11 @@ function flattenActions(
           .map(c => ({...c, listItemType: 'action' as const})),
       ];
     }
+    // Skip resource nodes with no children — they are async group containers that
+    // returned 0 results and have no executable action of their own.
+    if ('resource' in item && !('to' in item) && !('onAction' in item)) {
+      return [];
+    }
     return scores.get(item.key)?.score.matched ? [{...item, listItemType: 'action'}] : [];
   });