fix typing

Author: srest2021

src/sentry/seer/autofix/autofix_agent.py

@@ -513,17 +513,16 @@ def trigger_coding_agent_handoff(
     repo_definitions: list[SeerRepoDefinition] = []
     if features.has("organizations:seer-project-settings-read-from-sentry", group.organization):
         preference = read_preference_from_sentry_db(group.project)
-        if preference:
-            repo_definitions = preference.repositories
-            if preference.automation_handoff:
-                auto_create_pr = preference.automation_handoff.auto_create_pr
+        repo_definitions = preference.repositories
+        if preference.automation_handoff:
+            auto_create_pr = preference.automation_handoff.auto_create_pr
     else:
         try:
-            preference = get_project_seer_preferences(group.project_id).preference
-            if preference:
-                repo_definitions = preference.repositories
-                if preference.automation_handoff:
-                    auto_create_pr = preference.automation_handoff.auto_create_pr
+            pref = get_project_seer_preferences(group.project_id).preference
+            if pref:
+                repo_definitions = pref.repositories
+                if pref.automation_handoff:
+                    auto_create_pr = pref.automation_handoff.auto_create_pr
         except Exception:
             logger.exception(
                 "autofix.coding_agent_handoff.get_preferences_error",

src/sentry/seer/autofix/coding_agent.py

@@ -237,7 +237,7 @@ def _launch_agents_for_repos(
         try:
             project = Project.objects.get_from_cache(id=autofix_state.request.project_id)
             preference = read_preference_from_sentry_db(project)
-            if preference and preference.automation_handoff:
+            if preference.automation_handoff:
                 auto_create_pr = preference.automation_handoff.auto_create_pr
         except Project.DoesNotExist:
             logger.exception(
@@ -250,9 +250,9 @@ def _launch_agents_for_repos(
             )
     else:
         try:
-            preference = get_project_seer_preferences(autofix_state.request.project_id).preference
-            if preference and preference.automation_handoff:
-                auto_create_pr = preference.automation_handoff.auto_create_pr
+            pref = get_project_seer_preferences(autofix_state.request.project_id).preference
+            if pref and pref.automation_handoff:
+                auto_create_pr = pref.automation_handoff.auto_create_pr
         except (SeerApiError, SeerApiResponseValidationError):
             logger.exception(
                 "coding_agent.get_project_seer_preferences_error",

src/sentry/seer/autofix/on_completion_hook.py

@@ -490,16 +490,16 @@ def _get_handoff_config_if_applicable(
 
         # Check project preferences
         if features.has("organizations:seer-project-settings-read-from-sentry", group.organization):
-            preference = read_preference_from_sentry_db(group.project)
-        else:
-            try:
-                preference = get_project_seer_preferences(group.project_id).preference
-            except (SeerApiError, SeerApiResponseValidationError):
-                logger.exception(
-                    "autofix.on_completion_hook.get_preferences_failed",
-                    extra={"group_id": group.id, "project_id": group.project_id},
-                )
-                return None
+            return read_preference_from_sentry_db(group.project).automation_handoff
+
+        try:
+            preference = get_project_seer_preferences(group.project_id).preference
+        except (SeerApiError, SeerApiResponseValidationError):
+            logger.exception(
+                "autofix.on_completion_hook.get_preferences_failed",
+                extra={"group_id": group.id, "project_id": group.project_id},
+            )
+            return None
 
         if not preference:
             return None
@@ -510,6 +510,7 @@ def _clear_handoff_preference(
         cls, project: Project, run_id: int, organization: Organization
     ) -> None:
         """Clear automation_handoff from project preferences after integration is not found."""
+        preference: SeerProjectPreference | None = None
         if features.has("organizations:seer-project-settings-read-from-sentry", organization):
             preference = read_preference_from_sentry_db(project)
         else: