Skip to content

Commit 672a127

Browse files
committed
Extract common step components into new file
1 parent b589ff9 commit 672a127

File tree

3 files changed

+31
-36
lines changed

3 files changed

+31
-36
lines changed

static/app/views/automations/components/actionFilterBlock.tsx

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import styled from '@emotion/styled';
22

33
import {Button} from '@sentry/scraps/button';
44
import {Container, Flex} from '@sentry/scraps/layout';
5-
import {Select} from '@sentry/scraps/select';
65

76
import {useFormField} from 'sentry/components/workflowEngine/form/useFormField';
87
import {ConditionBadge} from 'sentry/components/workflowEngine/ui/conditionBadge';
@@ -26,6 +25,11 @@ import {
2625
validateActions,
2726
} from 'sentry/views/automations/components/automationFormData';
2827
import {DataConditionNodeList} from 'sentry/views/automations/components/dataConditionNodeList';
28+
import {
29+
EmbeddedSelectField,
30+
Step,
31+
StepLead,
32+
} from 'sentry/views/automations/components/stepComponents';
2933
import {useSendTestNotification as useSendTestNotificationMutation} from 'sentry/views/automations/hooks';
3034
import {useConnectedDetectors} from 'sentry/views/automations/hooks/useConnectedDetectors';
3135

@@ -172,23 +176,6 @@ export function ActionFilterBlock({actionFilter}: ActionFilterBlockProps) {
172176
);
173177
}
174178

175-
const Step = styled(Flex)`
176-
flex-direction: column;
177-
gap: ${p => p.theme.space.sm};
178-
`;
179-
180-
const StepLead = styled(Flex)`
181-
align-items: center;
182-
gap: ${p => p.theme.space.xs};
183-
margin-bottom: ${p => p.theme.space.xs};
184-
`;
185-
186-
const EmbeddedSelectField = styled(Select)`
187-
padding: 0;
188-
font-weight: ${p => p.theme.font.weight.sans.regular};
189-
text-transform: none;
190-
`;
191-
192179
const IfThenWrapper = styled(Flex)`
193180
position: relative;
194181
flex-direction: column;

static/app/views/automations/components/automationBuilder.tsx

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import styled from '@emotion/styled';
33

44
import {Alert} from '@sentry/scraps/alert';
55
import {Container, Flex} from '@sentry/scraps/layout';
6-
import {Select} from '@sentry/scraps/select';
76

87
import {fetchOrgMembers} from 'sentry/actionCreators/members';
98
import {ConditionBadge} from 'sentry/components/workflowEngine/ui/conditionBadge';
@@ -22,6 +21,11 @@ import {AutomationBuilderConflictContext} from 'sentry/views/automations/compone
2221
import {useAutomationBuilderContext} from 'sentry/views/automations/components/automationBuilderContext';
2322
import {useAutomationBuilderErrorContext} from 'sentry/views/automations/components/automationBuilderErrorContext';
2423
import {DataConditionNodeList} from 'sentry/views/automations/components/dataConditionNodeList';
24+
import {
25+
EmbeddedSelectField,
26+
Step,
27+
StepLead,
28+
} from 'sentry/views/automations/components/stepComponents';
2529
import {TRIGGER_MATCH_OPTIONS} from 'sentry/views/automations/components/triggers/constants';
2630
import {findConflictingConditions} from 'sentry/views/automations/hooks/utils';
2731

@@ -120,23 +124,6 @@ export function AutomationBuilder() {
120124
);
121125
}
122126

123-
const Step = styled(Flex)`
124-
flex-direction: column;
125-
gap: ${p => p.theme.space.sm};
126-
`;
127-
128-
const StepLead = styled(Flex)`
129-
align-items: center;
130-
gap: ${p => p.theme.space.xs};
131-
margin-bottom: ${p => p.theme.space.xs};
132-
`;
133-
134-
const EmbeddedSelectField = styled(Select)`
135-
padding: 0;
136-
font-weight: ${p => p.theme.font.weight.sans.regular};
137-
text-transform: none;
138-
`;
139-
140127
const StyledAlert = styled(Alert)`
141128
margin-top: ${p => p.theme.space.md};
142129
`;
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import styled from '@emotion/styled';
2+
3+
import {Flex} from '@sentry/scraps/layout';
4+
import {Select} from '@sentry/scraps/select';
5+
6+
export const Step = styled(Flex)`
7+
flex-direction: column;
8+
gap: ${p => p.theme.space.sm};
9+
`;
10+
11+
export const StepLead = styled(Flex)`
12+
align-items: center;
13+
gap: ${p => p.theme.space.xs};
14+
margin-bottom: ${p => p.theme.space.xs};
15+
`;
16+
17+
export const EmbeddedSelectField = styled(Select)`
18+
padding: 0;
19+
font-weight: ${p => p.theme.font.weight.sans.regular};
20+
text-transform: none;
21+
`;

0 commit comments

Comments
 (0)