Skip to content

Commit 53be095

Browse files
committed
fix(bitbucket): Add missing uuid and external_id to pagination tests
Mock response data was missing the uuid field that get_repo_external_id() requires, causing KeyError. Assertions were also missing the external_id key in expected results. Refs VDY-67
1 parent ea9d018 commit 53be095

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tests/sentry/integrations/bitbucket/test_integration.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,30 +70,30 @@ def test_get_repositories_multiple_pages(self) -> None:
7070
responses.GET,
7171
base_url,
7272
json={
73-
"values": [{"full_name": "sentryuser/repo-1"}],
73+
"values": [{"full_name": "sentryuser/repo-1", "uuid": "{r1}"}],
7474
"next": f"{base_url}?pagelen=100&page=2",
7575
},
7676
)
7777
responses.add(
7878
responses.GET,
7979
f"{base_url}?pagelen=100&page=2",
8080
json={
81-
"values": [{"full_name": "sentryuser/repo-2"}],
81+
"values": [{"full_name": "sentryuser/repo-2", "uuid": "{r2}"}],
8282
"next": f"{base_url}?pagelen=100&page=3",
8383
},
8484
)
8585
responses.add(
8686
responses.GET,
8787
f"{base_url}?pagelen=100&page=3",
88-
json={"values": [{"full_name": "sentryuser/repo-3"}]},
88+
json={"values": [{"full_name": "sentryuser/repo-3", "uuid": "{r3}"}]},
8989
)
9090

9191
installation = self.integration.get_installation(self.organization.id)
9292
result = installation.get_repositories()
9393
assert result == [
94-
{"identifier": "sentryuser/repo-1", "name": "sentryuser/repo-1"},
95-
{"identifier": "sentryuser/repo-2", "name": "sentryuser/repo-2"},
96-
{"identifier": "sentryuser/repo-3", "name": "sentryuser/repo-3"},
94+
{"identifier": "sentryuser/repo-1", "name": "sentryuser/repo-1", "external_id": "{r1}"},
95+
{"identifier": "sentryuser/repo-2", "name": "sentryuser/repo-2", "external_id": "{r2}"},
96+
{"identifier": "sentryuser/repo-3", "name": "sentryuser/repo-3", "external_id": "{r3}"},
9797
]
9898

9999
@responses.activate
@@ -105,21 +105,21 @@ def test_get_repositories_respects_page_limit(self) -> None:
105105
responses.GET,
106106
base_url,
107107
json={
108-
"values": [{"full_name": "sentryuser/repo-1"}],
108+
"values": [{"full_name": "sentryuser/repo-1", "uuid": "{r1}"}],
109109
"next": f"{base_url}?pagelen=100&page=2",
110110
},
111111
)
112112
# Page 2 should not be fetched
113113
responses.add(
114114
responses.GET,
115115
f"{base_url}?pagelen=100&page=2",
116-
json={"values": [{"full_name": "sentryuser/repo-2"}]},
116+
json={"values": [{"full_name": "sentryuser/repo-2", "uuid": "{r2}"}]},
117117
)
118118

119119
installation = self.integration.get_installation(self.organization.id)
120120
result = installation.get_repositories(page_number_limit=1)
121121
assert result == [
122-
{"identifier": "sentryuser/repo-1", "name": "sentryuser/repo-1"},
122+
{"identifier": "sentryuser/repo-1", "name": "sentryuser/repo-1", "external_id": "{r1}"},
123123
]
124124
assert len(responses.calls) == 1
125125

0 commit comments

Comments
 (0)