Skip to content

Commit 488a225

Browse files
mtopo27claude
andcommitted
fix(preprod): Add tab=size query param to size status check settings URL
The mobile-builds settings page now uses tabs, so the configure link in VCS size status checks needs to include tab=size to land on the correct tab. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent fc84cb2 commit 488a225

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

src/sentry/preprod/vcs/status_checks/size/templates.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,12 @@ def _get_settings_url(
331331
) -> str:
332332
"""Build the settings URL for the project's preprod settings page."""
333333
base_url = f"/settings/projects/{project.slug}/mobile-builds/"
334+
query = "tab=size"
334335
if triggered_rules:
335336
unique_rule_ids = list(dict.fromkeys(tr.rule.id for tr in triggered_rules))
336337
expanded_params = "&".join(f"expanded={rule_id}" for rule_id in unique_rule_ids)
337-
return project.organization.absolute_url(base_url, query=expanded_params)
338-
return project.organization.absolute_url(base_url)
338+
query += "&" + expanded_params
339+
return project.organization.absolute_url(base_url, query=query)
339340

340341

341342
def _format_failed_checks_details(

tests/sentry/preprod/vcs/status_checks/size/test_templates.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,9 @@ def test_mixed_platforms_render_separate_tables(self) -> None:
965965

966966
android_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{android_artifact.id}"
967967
ios_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{ios_artifact.id}"
968-
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/"
968+
settings_url = (
969+
f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size"
970+
)
969971

970972
expected = f"""\
971973
### Android Builds
@@ -1314,7 +1316,7 @@ def test_single_triggered_rule_shows_details_section(self) -> None:
13141316
artifact_url = (
13151317
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}"
13161318
)
1317-
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"
1319+
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1"
13181320

13191321
expected = f"""\
13201322
## ❌ 1 Failed Size Check
@@ -1463,7 +1465,7 @@ def test_multiple_triggered_rules_url_formatting(self) -> None:
14631465
artifact_url = (
14641466
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}"
14651467
)
1466-
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"
1468+
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"
14671469

14681470
expected = f"""\
14691471
## ❌ 3 Failed Size Checks
@@ -1576,7 +1578,7 @@ def test_multiple_apps_with_triggered_rules(self) -> None:
15761578
artifact2_url = (
15771579
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact2.id}"
15781580
)
1579-
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1&expanded=rule-2"
1581+
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1&expanded=rule-2"
15801582

15811583
expected = f"""\
15821584
## ❌ 2 Failed Size Checks
@@ -1680,7 +1682,7 @@ def test_mixed_pass_fail_with_triggered_rules(self) -> None:
16801682

16811683
failed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{failed_artifact.id}"
16821684
passed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{passed_artifact.id}"
1683-
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"
1685+
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1"
16841686

16851687
expected = f"""\
16861688
## ❌ 1 Failed Size Check

0 commit comments

Comments
 (0)