Skip to content

Commit 473e6b1

Browse files
mjqclaude
andcommitted
ref(perf): Rename OverviewSpansTable to SampledEventsTable
Rename to match the UI label for this table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 1513257 commit 473e6b1

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

static/app/views/performance/eap/overviewSpansTable.tsx renamed to static/app/views/performance/eap/sampledEventsTable.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const BASE_FIELDS: SpanProperty[] = [
7171
'spans.ui',
7272
];
7373

74-
type OverviewSpansColumn = GridColumnHeader<
74+
type SampledEventsColumn = GridColumnHeader<
7575
| 'span_id'
7676
| 'user.display'
7777
| 'request.method'
@@ -83,7 +83,7 @@ type OverviewSpansColumn = GridColumnHeader<
8383
| typeof SPAN_OPS_BREAKDOWN_COLUMN_KEY
8484
>;
8585

86-
const BASE_COLUMN_ORDER: OverviewSpansColumn[] = [
86+
const BASE_COLUMN_ORDER: SampledEventsColumn[] = [
8787
{key: 'span_id', name: t('Span ID'), width: COL_WIDTH_UNDEFINED},
8888
{key: 'user.display', name: t('User'), width: COL_WIDTH_UNDEFINED},
8989
{key: 'request.method', name: t('HTTP Method'), width: COL_WIDTH_UNDEFINED},
@@ -97,13 +97,13 @@ const BASE_COLUMN_ORDER: OverviewSpansColumn[] = [
9797
{key: 'timestamp', name: t('Timestamp'), width: COL_WIDTH_UNDEFINED},
9898
];
9999

100-
const REPLAY_COLUMN: OverviewSpansColumn = {
100+
const REPLAY_COLUMN: SampledEventsColumn = {
101101
key: 'replayId',
102102
name: t('Replay'),
103103
width: COL_WIDTH_UNDEFINED,
104104
};
105105

106-
const PROFILE_COLUMN: OverviewSpansColumn = {
106+
const PROFILE_COLUMN: SampledEventsColumn = {
107107
key: 'profile.id',
108108
name: t('Profile'),
109109
width: COL_WIDTH_UNDEFINED,
@@ -115,7 +115,7 @@ type Props = {
115115
maxDuration?: number;
116116
};
117117

118-
export function OverviewSpansTable({eventView, transactionName, maxDuration}: Props) {
118+
export function SampledEventsTable({eventView, transactionName, maxDuration}: Props) {
119119
const {selection} = usePageFilters();
120120
const location = useLocation();
121121
const {projects} = useProjects();
@@ -133,7 +133,7 @@ export function OverviewSpansTable({eventView, transactionName, maxDuration}: Pr
133133

134134
const fields = showReplayColumn ? BASE_FIELDS.concat('replayId') : BASE_FIELDS;
135135

136-
const columnOrder: OverviewSpansColumn[] = [
136+
const columnOrder: SampledEventsColumn[] = [
137137
...BASE_COLUMN_ORDER,
138138
...(showReplayColumn ? [REPLAY_COLUMN] : []),
139139
PROFILE_COLUMN,
@@ -259,7 +259,7 @@ export function OverviewSpansTable({eventView, transactionName, maxDuration}: Pr
259259
}
260260

261261
function renderBodyCell(
262-
column: OverviewSpansColumn,
262+
column: SampledEventsColumn,
263263
row: Record<string, any>,
264264
meta: EventsMetaType | undefined,
265265
projectSlug: string | undefined,

static/app/views/performance/transactionSummary/transactionEvents/content.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import {Mode} from 'sentry/views/explore/contexts/pageParamsContext/mode';
3838
import {getExploreUrl} from 'sentry/views/explore/utils';
3939
import {QueryParameterNames} from 'sentry/views/insights/common/views/queryParameters';
4040
import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters';
41-
import {OverviewSpansTable} from 'sentry/views/performance/eap/overviewSpansTable';
41+
import {SampledEventsTable} from 'sentry/views/performance/eap/sampledEventsTable';
4242
import {useTransactionSummaryEAP} from 'sentry/views/performance/eap/useTransactionSummaryEAP';
4343
import type {SpanOperationBreakdownFilter} from 'sentry/views/performance/transactionSummary/filter';
4444
import {
@@ -213,7 +213,7 @@ export function EventsContent(props: Props) {
213213
: percentileValues?.[eventsDisplayFilterName];
214214

215215
const table = shouldUseEAP ? (
216-
<OverviewSpansTable
216+
<SampledEventsTable
217217
eventView={eventView}
218218
transactionName={transactionName}
219219
maxDuration={maxDuration}

0 commit comments

Comments
 (0)