Skip to content

Commit 3f1e93a

Browse files
cameroncookeCursor
andauthored
fix(preprod): Allow branch ref ellipsis in mobile builds table (EME-882) (#112774)
Truncate long Git branch names in the mobile builds table build column. `Text` with `ellipsis` needs a parent with a definite bounded width. Nested flex rows default to `min-width: auto`, so the VCS line grew with the full branch name and ellipsis never applied. The build column now sets `minWidth={0}` on the row cell and flex wrappers so the grid track can shrink, wraps the head ref in a `flex={1}` `overflow="hidden"` region so only that segment consumes leftover width, and adds a `Tooltip` with `showOnlyOnOverflow` so reviewers can read the full ref when it is clipped. Column `minmax` templates in the size and distribution tables are unchanged; this is strictly flex/grid shrink behavior inside the build cell. ## Before <img width="975" height="408" alt="Screenshot 2026-04-13 at 11 02 10" src="https://github.com/user-attachments/assets/937ed8ea-7235-4648-b206-dc2b7fc1a97c" /> ## After <img width="850" height="472" alt="Screenshot 2026-04-13 at 11 20 52" src="https://github.com/user-attachments/assets/854db4e4-7859-4e94-be6f-a22f3262be93" /> Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <noreply@cursor.com>
1 parent 6d3af9d commit 3f1e93a

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

static/app/components/preprod/preprodBuildsTableCommon.tsx

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ export function PreprodBuildsRowCells({
118118
</SimpleTable.RowCell>
119119
)}
120120

121-
<SimpleTable.RowCell justify="start">
122-
<Flex direction="column" gap="xs">
121+
<SimpleTable.RowCell justify="start" minWidth={0}>
122+
<Flex direction="column" gap="xs" minWidth={0} width="100%">
123123
<Flex align="center" gap="xs">
124124
{build.app_info?.version !== null && (
125125
<Text size="lg" bold>
@@ -133,7 +133,7 @@ export function PreprodBuildsRowCells({
133133
)}
134134
{build.state === 3 && <IconCheckmark size="sm" variant="success" />}
135135
</Flex>
136-
<Flex align="center" gap="xs">
136+
<Flex align="center" gap="xs" minWidth={0}>
137137
<IconCommit size="xs" />
138138
<Text size="sm" variant="muted" monospace>
139139
{(build.vcs_info?.head_sha?.slice(0, 7) || '--').toUpperCase()}
@@ -150,9 +150,17 @@ export function PreprodBuildsRowCells({
150150
<Text size="sm" variant="muted">
151151
152152
</Text>
153-
<Text size="sm" variant="muted">
154-
{build.vcs_info?.head_ref || '--'}
155-
</Text>
153+
<Flex flex={1} minWidth={0} overflow="hidden">
154+
<Tooltip
155+
title={build.vcs_info?.head_ref || undefined}
156+
showOnlyOnOverflow
157+
skipWrapper
158+
>
159+
<Text size="sm" variant="muted" ellipsis>
160+
{build.vcs_info?.head_ref || '--'}
161+
</Text>
162+
</Tooltip>
163+
</Flex>
156164
</Fragment>
157165
)}
158166
</Flex>

0 commit comments

Comments
 (0)