Skip to content

Commit 3f10a2a

Browse files
nsdeschenescodex
andcommitted
fix(dashboards): Hide internal trace metric filter keys
Pass hidden trace metric keys into the static attribute lookups used by the trace metrics search bar data provider. This keeps internal metric fields out of getFilterKeys() so dashboard filter suggestions match the hidden dynamic attribute behavior. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com> Made-with: Cursor
1 parent fd2958c commit 3f10a2a

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

static/app/views/dashboards/datasetConfig/traceMetrics.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,22 @@ function useTraceMetricsSearchBarDataProvider(
185185
};
186186

187187
const {attributes: stringAttributes, secondaryAliases: stringSecondaryAliases} =
188-
useTraceMetricItemAttributes({query: createTraceMetricFilter(traceMetric)}, 'string');
188+
useTraceMetricItemAttributes(
189+
{query: createTraceMetricFilter(traceMetric)},
190+
'string',
191+
HiddenTraceMetricSearchFields
192+
);
189193
const {attributes: numberAttributes, secondaryAliases: numberSecondaryAliases} =
190-
useTraceMetricItemAttributes({query: createTraceMetricFilter(traceMetric)}, 'number');
194+
useTraceMetricItemAttributes(
195+
{query: createTraceMetricFilter(traceMetric)},
196+
'number',
197+
HiddenTraceMetricSearchFields
198+
);
191199
const {attributes: booleanAttributes, secondaryAliases: booleanSecondaryAliases} =
192200
useTraceMetricItemAttributes(
193201
{query: createTraceMetricFilter(traceMetric)},
194-
'boolean'
202+
'boolean',
203+
HiddenTraceMetricSearchFields
195204
);
196205

197206
const {filterKeys, filterKeySections, getTagValues} =

0 commit comments

Comments
 (0)