fix(onboarding): Fix knip and typecheck CI failures

Un-export OnboardingSessionState (no longer imported externally).
Add @public JSDoc tags to SCM prop interfaces so knip recognizes
them as intentionally exported for the project creation flow.
Fix renderComponent type in scmPlatformFeatures.spec.tsx.

ref(onboarding): Un-export SCM prop interfaces until needed

No external consumers yet. Re-export when the project creation
flow imports them.

Author: jaydgoss

static/app/components/onboarding/onboardingContext.tsx

@@ -19,7 +19,7 @@ type OnboardingContextProps = {
   selectedRepository?: Repository;
 };
 
-export type OnboardingSessionState = {
+type OnboardingSessionState = {
   createdProjectSlug?: string;
   selectedFeatures?: ProductSolution[];
   selectedIntegration?: Integration;

static/app/views/onboarding/components/scmRepoSelector.tsx

@@ -12,7 +12,7 @@ import {ScmVirtualizedMenuList} from './scmVirtualizedMenuList';
 import {useScmRepos} from './useScmRepos';
 import {useScmRepoSelection} from './useScmRepoSelection';
 
-export interface ScmRepoSelectorProps {
+interface ScmRepoSelectorProps {
   integration: Integration;
   onRepositoryChange: (repo: Repository | undefined) => void;
   selectedRepository: Repository | undefined;

static/app/views/onboarding/scmConnect.tsx

@@ -22,7 +22,7 @@ import {useScmPlatformDetection} from './components/useScmPlatformDetection';
 import {useScmProviders} from './components/useScmProviders';
 import {SCM_STEP_CONTENT_WIDTH} from './consts';
 
-export interface ScmConnectProps {
+interface ScmConnectProps {
   onComplete: () => void;
   onIntegrationChange: (integration: Integration | undefined) => void;
   onRepositoryChange: (repo: Repository | undefined) => void;

static/app/views/onboarding/scmPlatformFeatures.spec.tsx

@@ -67,7 +67,7 @@ describe('ScmPlatformFeatures', () => {
 
   function renderComponent(
     overrides?: Partial<typeof defaultProps>,
-    orgOverride?: Parameters<typeof render>[1]['organization']
+    orgOverride?: typeof organization
   ) {
     const props = {...defaultProps, ...overrides};
     return render(<ScmPlatformFeatures {...props} />, {

static/app/views/onboarding/scmPlatformFeatures.tsx

@@ -75,7 +75,7 @@ function shouldSuggestFramework(platformKey: PlatformKey): boolean {
 // Wider than SCM_STEP_CONTENT_WIDTH (506px) used by the footer.
 const PLATFORM_CONTENT_WIDTH = '564px';
 
-export interface ScmPlatformFeaturesProps {
+interface ScmPlatformFeaturesProps {
   onComplete: () => void;
   onFeaturesChange: (features: ProductSolution[]) => void;
   onPlatformChange: (platform: OnboardingSelectedSDK | undefined) => void;

static/app/views/onboarding/scmProjectDetails.tsx

@@ -31,7 +31,7 @@ import {ScmStepHeader} from './components/scmStepHeader';
 
 const PROJECT_DETAILS_WIDTH = '285px';
 
-export interface ScmProjectDetailsProps {
+interface ScmProjectDetailsProps {
   onComplete: (
     platform?: OnboardingSelectedSDK,
     query?: Record<string, string[]>