Skip to content

Commit 376e9ae

Browse files
committed
fix(conversations): Fix TS errors, lint issues, and remove unused drawer files
- Add conversationId to ParamKeys for useParams type safety - Remove unnecessary non-null assertions in conversationDetail and layout - Fix Flex justify/align values to use design system tokens - Fix IconUser to use variant prop instead of removed color prop - Fix padding token from "none" to "0" - Delete unused conversationDrawer and useUrlConversationDrawer files - Remove unused useConversationDrawerQueryState export
1 parent 9978f7e commit 376e9ae

File tree

9 files changed

+6
-421
lines changed

9 files changed

+6
-421
lines changed

static/app/utils/useParams.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ type ParamKeys =
2222
| 'broadcastId'
2323
| 'clientID'
2424
| 'codeId'
25+
| 'conversationId'
2526
| 'dashboardId'
2627
| 'dataExportId'
2728
| 'dataForwarderId'

static/app/views/insights/pages/conversations/components/conversationDrawer.spec.tsx

Lines changed: 0 additions & 63 deletions
This file was deleted.

static/app/views/insights/pages/conversations/components/conversationDrawer.tsx

Lines changed: 0 additions & 159 deletions
This file was deleted.

static/app/views/insights/pages/conversations/components/conversationsTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ const BodyCell = memo(function BodyCell({
214214
return (
215215
<Tooltip title={displayName} showOnlyOnOverflow>
216216
<Flex align="center" gap="xs" minWidth={0}>
217-
<IconUser size="md" color="subText" />
217+
<IconUser size="md" variant="muted" />
218218
<Text ellipsis>{displayName}</Text>
219219
</Flex>
220220
</Tooltip>

static/app/views/insights/pages/conversations/conversationDetail.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function ConversationDetailContent() {
5050

5151
const conversation = useMemo(
5252
() => ({
53-
conversationId: conversationId!,
53+
conversationId,
5454
startTimestamp: queryState.start ?? undefined,
5555
endTimestamp: queryState.end ?? undefined,
5656
}),
@@ -72,11 +72,11 @@ function ConversationDetailContent() {
7272
width="full"
7373
style={{display: 'flex', flexDirection: 'column', flex: 1}}
7474
>
75-
<Flex direction="column" gap="md" padding="none none xl none">
75+
<Flex direction="column" gap="md" padding="0 0 xl 0">
7676
<ConversationSummary
7777
nodes={nodes}
7878
nodeTraceMap={nodeTraceMap}
79-
conversationId={conversationId!}
79+
conversationId={conversationId}
8080
isLoading={isLoading}
8181
/>
8282
</Flex>

static/app/views/insights/pages/conversations/hooks/useUrlConversationDrawer.spec.tsx

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)