ref(nav): Remove size prop from FeedbackButton inside TopBar.Slot and migrate subscriptionSettingsLayout

Inside TopBar.Slot, the TopBar owns button sizing, so the size prop
on FeedbackButton is redundant. Remove it from all 11 migrated files.

Also migrate subscriptionSettingsLayout.tsx to use TopBar.Slot when
the page-frame feature is active.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: JonasBa

static/app/views/automations/components/automationFeedbackButton.tsx

@@ -10,7 +10,6 @@ export function AutomationFeedbackButton() {
     return (
       <TopBar.Slot name="feedback">
         <FeedbackButton
-          size="sm"
           feedbackOptions={{
             messagePlaceholder: t('How can we improve the alerts experience?'),
             tags: {

static/app/views/detectors/components/monitorFeedbackButton.tsx

@@ -10,7 +10,6 @@ export function MonitorFeedbackButton() {
     return (
       <TopBar.Slot name="feedback">
         <FeedbackButton
-          size="sm"
           feedbackOptions={{
             messagePlaceholder: t('How can we improve the monitor experience?'),
             tags: {

static/app/views/feedback/feedbackListPage.tsx

@@ -159,7 +159,6 @@ export default function FeedbackListPage() {
                 {hasPageFrameFeature ? (
                   <TopBar.Slot name="feedback">
                     <FeedbackButton
-                      size="sm"
                       feedbackOptions={{
                         messagePlaceholder: t(
                           'How can we improve the User Feedback experience?'

static/app/views/issueDetails/streamline/header/header.tsx

@@ -154,7 +154,6 @@ export function StreamlinedGroupHeader({event, group, project}: GroupHeaderProps
                 <TopBar.Slot name="feedback">
                   <FeedbackButton
                     aria-label={t('Give feedback on the issue Sentry detected')}
-                    size="xs"
                     feedbackOptions={{
                       messagePlaceholder: t(
                         'Please provide feedback on the issue Sentry detected.'

static/app/views/issueList/issueViews/issueViewsList/issueViewsList.tsx

@@ -371,7 +371,6 @@ export default function IssueViewsList() {
               {hasPageFrameFeature ? (
                 <TopBar.Slot name="feedback">
                   <FeedbackButton
-                    size="sm"
                     feedbackOptions={{
                       formTitle: t('Give Feedback'),
                       messagePlaceholder: t('How can we make issue views better for you?'),

static/app/views/performance/newTraceDetails/traceHeader/index.tsx

@@ -95,7 +95,6 @@ export function TraceMetaDataHeader(props: TraceMetadataHeaderProps) {
             {hasPageFrameFeature ? (
               <TopBar.Slot name="feedback">
                 <FeedbackButton
-                  size="xs"
                   feedbackOptions={{
                     messagePlaceholder: t(
                       'How can we make the trace view better for you?'

static/app/views/performance/newTraceDetails/traceHeader/placeholder.tsx

@@ -46,7 +46,6 @@ export function PlaceHolder({
             {hasPageFrameFeature ? (
               <TopBar.Slot name="feedback">
                 <FeedbackButton
-                  size="xs"
                   feedbackOptions={{
                     messagePlaceholder: t(
                       'How can we make the trace view better for you?'

static/app/views/performance/newTraceDetails/traceSummary.tsx

@@ -93,7 +93,6 @@ export function TraceSummarySection({traceSlug}: {traceSlug: string}) {
         {hasPageFrameFeature ? (
           <TopBar.Slot name="feedback">
             <FeedbackButton
-              size="xs"
               feedbackOptions={{
                 messagePlaceholder: t(
                   'How can we make the trace summary better for you?'
@@ -202,7 +201,6 @@ export function TraceSummarySection({traceSlug}: {traceSlug: string}) {
             </TopBar.Slot>
           ) : (
             <FeedbackButton
-              size="xs"
               feedbackOptions={{
                 messagePlaceholder: t(
                   'How can we make the trace summary better for you?'

static/app/views/replays/detail/header/replayDetailsHeaderActions.tsx

@@ -28,7 +28,7 @@ export function ReplayDetailsHeaderActions({readerResult}: Props) {
         <ButtonActionsWrapper>
           {hasPageFrameFeature ? (
             <TopBar.Slot name="feedback">
-              <FeedbackButton size="xs">{null}</FeedbackButton>
+              <FeedbackButton>{null}</FeedbackButton>
             </TopBar.Slot>
           ) : (
             <FeedbackButton size="xs" />
@@ -46,7 +46,7 @@ export function ReplayDetailsHeaderActions({readerResult}: Props) {
         <ButtonActionsWrapper>
           {hasPageFrameFeature ? (
             <TopBar.Slot name="feedback">
-              <FeedbackButton size="xs">{null}</FeedbackButton>
+              <FeedbackButton>{null}</FeedbackButton>
             </TopBar.Slot>
           ) : (
             <FeedbackButton size="xs" />

static/gsApp/components/subscriptionSettingsLayout.tsx

@@ -12,11 +12,14 @@ import {SettingsBreadcrumb} from 'sentry/views/settings/components/settingsBread
 import type {RouteWithName} from 'sentry/views/settings/components/settingsBreadcrumb/types';
 import {SettingsHeader} from 'sentry/views/settings/components/settingsHeader';
 import {SettingsSearch} from 'sentry/views/settings/components/settingsSearch';
+import {TopBar} from 'sentry/views/navigation/topBar';
+import {useHasPageFrameFeature} from 'sentry/views/navigation/useHasPageFrameFeature';
 
 export default function SubscriptionSettingsLayout() {
   const location = useLocation();
   const params = useParams();
   const routes = useRoutes();
+  const hasPageFrameFeature = useHasPageFrameFeature();
   let feedbackSource = location.pathname;
   for (let i = routes.length - 1; i >= 0; i--) {
     const route = routes[i] as RouteWithName;
@@ -32,19 +35,37 @@ export default function SubscriptionSettingsLayout() {
         <Flex align="center" justify="between" gap="xl">
           <StyledSettingsBreadcrumb params={params} routes={routes} />
           <Flex align="center" gap="xl">
-            <FeedbackButton
-              feedbackOptions={{
-                formTitle: t('Give feedback'),
-                messagePlaceholder: t(
-                  'How can we make the %s page better for you?',
-                  feedbackSource
-                ),
-                tags: {
-                  ['feedback.source']: feedbackSource,
-                  ['feedback.owner']: 'billing',
-                },
-              }}
-            />
+            {hasPageFrameFeature ? (
+              <TopBar.Slot name="feedback">
+                <FeedbackButton
+                  feedbackOptions={{
+                    formTitle: t('Give feedback'),
+                    messagePlaceholder: t(
+                      'How can we make the %s page better for you?',
+                      feedbackSource
+                    ),
+                    tags: {
+                      ['feedback.source']: feedbackSource,
+                      ['feedback.owner']: 'billing',
+                    },
+                  }}
+                >{null}</FeedbackButton>
+              </TopBar.Slot>
+            ) : (
+              <FeedbackButton
+                feedbackOptions={{
+                  formTitle: t('Give feedback'),
+                  messagePlaceholder: t(
+                    'How can we make the %s page better for you?',
+                    feedbackSource
+                  ),
+                  tags: {
+                    ['feedback.source']: feedbackSource,
+                    ['feedback.owner']: 'billing',
+                  },
+                }}
+              />
+            )}
             <SettingsSearch />
           </Flex>
         </Flex>