Skip to content

Commit 31f9de5

Browse files
authored
ref(cells): Remove dead SiloMode.CELL check from ReactPageView (#113001)
Cells don't receive public web traffic, and @control_silo_view already enforces this at the framework level. The check and its log line should never be reached.
1 parent 08d3d1d commit 31f9de5

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

src/sentry/web/frontend/react_page.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from sentry.models.organization import Organization
1515
from sentry.organizations.absolute_url import customer_domain_path, generate_organization_url
1616
from sentry.organizations.services.organization import organization_service
17-
from sentry.silo.base import SiloMode
1817
from sentry.types.cell import (
1918
find_all_multitenant_locality_names,
2019
subdomain_is_locality,
@@ -190,18 +189,6 @@ def handle_auth_required(self, request: HttpRequest, *args, **kwargs) -> HttpRes
190189
return super().handle_auth_required(request, *args, **kwargs)
191190

192191
def handle(self, request: HttpRequest, organization, **kwargs) -> HttpResponse:
193-
if SiloMode.get_current_mode() == SiloMode.CELL:
194-
# This shouldn't happen as all requests in production for HTML pages
195-
# should be in control.
196-
logger.info(
197-
"react_page.region_silo",
198-
extra={
199-
"url": request.get_full_path(),
200-
"method": request.method,
201-
"user-agent": request.headers.get("User-Agent"),
202-
},
203-
)
204-
205192
return self.handle_react(request, organization=organization)
206193

207194

0 commit comments

Comments
 (0)