fix(ci): address review feedback for early devservices

- Use strict shell (set -euo pipefail) at action level
- Fix set -e preventing exit code file from being written in subshell
- Add 10-minute timeout to Snuba bootstrap wait loop
- Move devservices start after chartcuterie build in acceptance
- Revert migrations/migrations-drift (checkout master first, action doesn't exist there yet)

Author: joshuarli

.github/actions/setup-devservices/action.yml

@@ -18,7 +18,7 @@ runs:
         enable-cache: false
 
     - name: Start devservices in background
-      shell: bash
+      shell: bash --noprofile --norc -euo pipefail {0}
       run: |
         DS_VERSION=$(python3 -c "
         import tomllib
@@ -34,5 +34,5 @@ runs:
         uv pip install --python /tmp/ds-venv/bin/python -q \
           --index-url https://pypi.devinfra.sentry.io/simple \
           "devservices==${DS_VERSION}"
-        (timeout ${{ inputs.timeout-minutes }}m /tmp/ds-venv/bin/devservices up --mode ${{ inputs.mode }}; echo $? > /tmp/ds-exit) \
+        (set +e; timeout ${{ inputs.timeout-minutes }}m /tmp/ds-venv/bin/devservices up --mode ${{ inputs.mode }}; echo $? > /tmp/ds-exit) \
           > /tmp/ds.log 2>&1 &

.github/workflows/backend.yml

@@ -279,7 +279,14 @@ jobs:
       - name: Wait for Snuba bootstrap
         if: env.XDIST_PER_WORKER_SNUBA == '1'
         run: |
-          while [ ! -f /tmp/snuba-bootstrap-exit ]; do sleep 2; done
+          SECONDS=0
+          while [ ! -f /tmp/snuba-bootstrap-exit ]; do
+            if [ $SECONDS -gt 600 ]; then
+              echo "::error::Timed out waiting for Snuba bootstrap after 600s"
+              exit 1
+            fi
+            sleep 2
+          done
           SNUBA_RC=$(cat /tmp/snuba-bootstrap-exit)
           if [ "$SNUBA_RC" -ne 0 ]; then
             echo "::error::Snuba per-worker bootstrap failed"

.github/workflows/migrations-drift.yml

@@ -27,21 +27,10 @@ jobs:
         with:
           ref: master
 
-      - name: Start devservices early
-        uses: ./.github/actions/setup-devservices
-        with:
-          mode: migrations
-
       - name: Setup sentry env
         uses: ./.github/actions/setup-sentry
         with:
           mode: migrations
-          skip-devservices: 'true'
-
-      - name: Wait for devservices
-        run: |
-          sentry init
-          ./.github/actions/setup-devservices/wait.sh
 
       - name: Apply migrations
         env:

.github/workflows/migrations.yml

@@ -47,21 +47,10 @@ jobs:
         with:
           ref: master
 
-      - name: Start devservices early
-        uses: ./.github/actions/setup-devservices
-        with:
-          mode: migrations
-
       - name: Setup sentry env
         uses: ./.github/actions/setup-sentry
         with:
           mode: migrations
-          skip-devservices: 'true'
-
-      - name: Wait for devservices
-        run: |
-          sentry init
-          ./.github/actions/setup-devservices/wait.sh
 
       - name: Apply migrations
         run: |