Merge branch 'master' into cleanup-getsentry-aliases

Author: lynnagara

.agents/skills/hybrid-cloud-outboxes/references/debugging.md

@@ -6,7 +6,7 @@ Understanding the pipeline helps locate where things break:
 
 1. **Model save/delete** writes outbox row inside `outbox_context(transaction.atomic(...))`
 2. **On commit**: if `flush=True`, `drain_shard()` runs synchronously for that shard
-3. **Periodic task**: `enqueue_outbox_jobs` (region) / `enqueue_outbox_jobs_control` (control) runs on a cron schedule
+3. **Periodic task**: `enqueue_outbox_jobs` (cell) / `enqueue_outbox_jobs_control` (control) runs on a cron schedule
 4. **`schedule_batch`** partitions the ID range into `CONCURRENCY=5` chunks and spawns `drain_outbox_shards` tasks
 5. **`drain_outbox_shards`** calls `process_outbox_batch` which:
    - Calls `find_scheduled_shards(lo, hi)` to find shards with `scheduled_for <= now`
@@ -71,9 +71,9 @@ Both tables share these columns:
 
 `sentry_controloutbox` has one additional column:
 
-| Column        | Type    | Description                   |
-| ------------- | ------- | ----------------------------- |
-| `region_name` | varchar | Target region for this outbox |
+| Column        | Type    | Description                 |
+| ------------- | ------- | --------------------------- |
+| `region_name` | varchar | Target cell for this outbox |
 
 ### Resolving Enum Values
 
@@ -92,10 +92,10 @@ When generating SQL for a developer, **print the query to the terminal** so they
 2. Comments mapping integer values to their enum names
 3. Reasonable `LIMIT` clauses to avoid overwhelming output
 
-#### Find stuck shards (region)
+#### Find stuck shards (cell)
 
 ```sql
--- Find region outbox shards stuck in backoff
+-- Find cell outbox shards stuck in backoff
 -- shard_scope: 0 = ORGANIZATION_SCOPE, 1 = USER_SCOPE, etc.
 -- category: see OutboxCategory enum in category.py
 SELECT
@@ -199,7 +199,7 @@ LIMIT 10;
 
 When a developer asks you to debug stuck outboxes:
 
-1. **Determine the table**: Ask which model or direction is involved, or infer from context. Use `sentry_regionoutbox` for region models, `sentry_controloutbox` for control models.
+1. **Determine the table**: Ask which model or direction is involved, or infer from context. Use `sentry_regionoutbox` for cell models, `sentry_controloutbox` for control models.
 2. **Resolve enum values**: Read `src/sentry/hybridcloud/outbox/category.py` to get the integer values for the relevant `OutboxCategory` and `OutboxScope`.
 3. **Construct the query**: Use the templates above, substituting resolved values. Always add comments with the human-readable enum names.
 4. **Print to terminal**: Output the final SQL so the developer can copy it. Do NOT attempt to run it — you don't have production database access.
@@ -212,10 +212,10 @@ When a developer asks you to debug stuck outboxes:
 The `should_skip_shard()` method checks these options:
 
 ```python
-# Skip specific organization shards (region outboxes)
+# Skip specific organization shards (cell outboxes)
 "hybrid_cloud.authentication.disabled_organization_shards": [org_id_1, org_id_2]
 
-# Skip specific user shards (region/control outboxes)
+# Skip specific user shards (cell/control outboxes)
 "hybrid_cloud.authentication.disabled_user_shards": [user_id_1, user_id_2]
 ```
 
@@ -252,7 +252,7 @@ For local debugging or in a Django shell:
 ```python
 from sentry.hybridcloud.models.outbox import CellOutbox, ControlOutbox
 
-# Top 10 deepest region shards
+# Top 10 deepest cell shards
 for shard in CellOutbox.get_shard_depths_descending(limit=10):
     print(f"Scope={shard['shard_scope']} ID={shard['shard_identifier']} Depth={shard['depth']}")
 ```

.github/CODEOWNERS

@@ -489,6 +489,11 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 *sentryapp*.py                                                       @getsentry/product-owners-settings-integrations @getsentry/ecosystem
 *doc_integration*.py                                                 @getsentry/ecosystem
 
+/src/sentry/runner/commands/createproject.py                         @getsentry/ecosystem
+/src/sentry/runner/commands/createorg.py                             @getsentry/ecosystem
+/tests/sentry/runner/commands/test_createproject.py                  @getsentry/ecosystem
+/tests/sentry/runner/commands/test_createorg.py                      @getsentry/ecosystem
+
 ## End of Integrations
 
 
@@ -673,12 +678,14 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /static/app/components/events/highlights/                   @getsentry/issue-workflow
 /static/app/components/issues/                              @getsentry/issue-workflow
 /static/app/components/stackTrace/                          @getsentry/issue-workflow
+/static/app/components/stream/supergroupRow.tsx             @getsentry/issue-detection-frontend
 /static/app/views/issueList/                                @getsentry/issue-workflow
 /static/app/views/issueList/issueListSeerComboBox.tsx       @getsentry/issue-workflow @getsentry/machine-learning-ai
 /static/app/views/issueList/pages/supergroups.tsx           @getsentry/issue-detection-frontend
 /static/app/views/issueList/supergroups/                    @getsentry/issue-detection-frontend
 /static/app/views/issueDetails/                             @getsentry/issue-workflow
 /static/app/views/nav/secondary/sections/issues/            @getsentry/issue-workflow
+/static/app/views/sharedGroupDetails/                       @getsentry/issue-workflow
 /static/app/components/events/interfaces/performance/spanEvidenceKeyValueList.tsx @getsentry/issue-detection-frontend
 /static/app/components/events/interfaces/crashContent/exception/actionableItems.tsx   @getsentry/issue-workflow
 /tests/sentry/deletions/test_group.py                       @getsentry/issue-detection-backend

.github/codeowners-coverage-baseline.txt

@@ -184,6 +184,7 @@ src/sentry/runner/commands/cleanup.py
 src/sentry/runner/commands/config.py
 src/sentry/runner/commands/configoptions.py
 src/sentry/runner/commands/createflag.py
+src/sentry/runner/commands/createorg.py
 src/sentry/runner/commands/createuser.py
 src/sentry/runner/commands/devserver.py
 src/sentry/runner/commands/devservices.py
@@ -225,9 +226,6 @@ src/sentry/scripts/quotas/is_rate_limited.lua
 src/sentry/scripts/ratelimits/api_limiter.lua
 src/sentry/scripts/ratelimits/leaky_bucket.lua
 src/sentry/scripts/similarity/index.lua
-src/sentry/scripts/spans/add-buffer.lua
-src/sentry/scripts/spans/done-flush-segment-data.lua
-src/sentry/scripts/spans/done-flush-segment.lua
 src/sentry/scripts/tsdb/cmsketch.lua
 src/sentry/scripts/utils/locking/delete_lock.lua
 src/sentry/scripts/utils/sadd_capped.lua
@@ -552,7 +550,6 @@ static/app/components/discover/transactionsList.spec.tsx
 static/app/components/discover/transactionsList.tsx
 static/app/components/discover/transactionsTable.tsx
 static/app/components/discoverButton.tsx
-static/app/components/dnd/dragReorderButton.tsx
 static/app/components/dropdownButton.tsx
 static/app/components/dropdownMenu/footer.tsx
 static/app/components/dropdownMenu/index.spec.tsx
@@ -605,14 +602,9 @@ static/app/components/events/eventAttachmentActions.tsx
 static/app/components/events/eventAttachments.spec.tsx
 static/app/components/events/eventAttachments.tsx
 static/app/components/events/eventAttachmentsCrashReportsNotice.tsx
-static/app/components/events/eventBreadcrumbsSection.spec.tsx
-static/app/components/events/eventBreadcrumbsSection.tsx
 static/app/components/events/eventCustomPerformanceMetrics.tsx
 static/app/components/events/eventDataSection.tsx
 static/app/components/events/eventDrawer.tsx
-static/app/components/events/eventEntries.spec.tsx
-static/app/components/events/eventEntries.tsx
-static/app/components/events/eventEntry.tsx
 static/app/components/events/eventEvidence.spec.tsx
 static/app/components/events/eventEvidence.tsx
 static/app/components/events/eventExtraData/getEventExtraDataKnownDataDetails.tsx
@@ -1023,18 +1015,6 @@ static/app/components/replaysOnboarding/replayConfigToggle.tsx
 static/app/components/replaysOnboarding/replayOnboardingLayout.tsx
 static/app/components/replaysOnboarding/sidebar.tsx
 static/app/components/replaysOnboarding/utils.tsx
-static/app/components/repositories/getRepoStatusLabel.tsx
-static/app/components/repositories/repoProviderIcon.tsx
-static/app/components/repositories/scmIntegrationTree/providerConfigLink.tsx
-static/app/components/repositories/scmIntegrationTree/scmIntegrationTree.tsx
-static/app/components/repositories/scmIntegrationTree/scmIntegrationTreeNodes.ts
-static/app/components/repositories/scmIntegrationTree/scmIntegrationTreeRow.tsx
-static/app/components/repositories/scmIntegrationTree/scmTreeFilters.tsx
-static/app/components/repositories/scmIntegrationTree/types.ts
-static/app/components/repositories/scmIntegrationTree/useScmIntegrationTreeData.spec.tsx
-static/app/components/repositories/scmIntegrationTree/useScmIntegrationTreeData.ts
-static/app/components/repositories/scmIntegrationTree/useScmTreeFilters.tsx
-static/app/components/repositories/scmRepoTreeModal.tsx
 static/app/components/repositoryRow.spec.tsx
 static/app/components/repositoryRow.tsx
 static/app/components/resolutionBox.spec.tsx
@@ -1489,9 +1469,6 @@ static/app/views/setupWizard/utils/useOrganizationsWithRegion.tsx
 static/app/views/setupWizard/utils/useUpdateWizardCache.tsx
 static/app/views/setupWizard/waitingForWizardToConnect.tsx
 static/app/views/setupWizard/wizardProjectSelection.tsx
-static/app/views/sharedGroupDetails/index.spec.tsx
-static/app/views/sharedGroupDetails/index.tsx
-static/app/views/sharedGroupDetails/sharedGroupHeader.tsx
 static/app/views/unsubscribe/issue.spec.tsx
 static/app/views/unsubscribe/issue.tsx
 static/app/views/unsubscribe/project.spec.tsx
@@ -2318,6 +2295,7 @@ tests/sentry/runner/commands/test_cleanup.py
 tests/sentry/runner/commands/test_config.py
 tests/sentry/runner/commands/test_configoptions.py
 tests/sentry/runner/commands/test_createflag.py
+tests/sentry/runner/commands/test_createorg.py
 tests/sentry/runner/commands/test_createuser.py
 tests/sentry/runner/commands/test_init.py
 tests/sentry/runner/commands/test_migrations.py

src/sentry/api/endpoints/user_organizations.py

@@ -13,6 +13,8 @@
 from sentry.users.services.user import RpcUser
 
 
+# TODO(cells): Non-routable by Synapse (no org slug in URL). Fix by moving to
+# @control_silo_endpoint and querying OrganizationMemberMapping + OrganizationMapping.
 @cell_silo_endpoint
 class UserOrganizationsEndpoint(RegionSiloUserEndpoint):
     publish_status = {

src/sentry/api/serializers/models/project.py

@@ -1181,7 +1181,7 @@ def format_options(self, attrs: Mapping[str, Any]) -> dict[str, Any]:
                 "sentry:preprod_snapshot_status_checks_fail_on_added", False
             ),
             "sentry:preprod_snapshot_status_checks_fail_on_removed": options.get(
-                "sentry:preprod_snapshot_status_checks_fail_on_removed", False
+                "sentry:preprod_snapshot_status_checks_fail_on_removed", True
             ),
             "quotas:spike-protection-disabled": options.get("quotas:spike-protection-disabled"),
             "sentry:preprod_size_enabled_query": options.get("sentry:preprod_size_enabled_query"),

src/sentry/dashboards/endpoints/organization_dashboard_generate.py

@@ -18,8 +18,8 @@
 from sentry.models.organization import Organization
 from sentry.ratelimits.config import RateLimitConfig
 from sentry.seer.explorer.client import SeerExplorerClient
-from sentry.seer.explorer.client_utils import has_seer_explorer_access_with_detail
 from sentry.seer.models import SeerApiError, SeerPermissionError
+from sentry.seer.seer_setup import has_seer_access_with_detail
 from sentry.types.ratelimit import RateLimit, RateLimitCategory
 
 logger = logging.getLogger(__name__)
@@ -63,7 +63,7 @@ def post(self, request: Request, organization: Organization) -> Response:
         ):
             return Response({"detail": "Feature not enabled"}, status=403)
 
-        has_access, error = has_seer_explorer_access_with_detail(organization, request.user)
+        has_access, error = has_seer_access_with_detail(organization, request.user)
         if not has_access:
             raise PermissionDenied(error)
 

src/sentry/hybridcloud/services/control_organization_provisioning/model.py

@@ -1,7 +1,3 @@
-from typing import Any
-
-from pydantic import root_validator
-
 from sentry.hybridcloud.rpc import RpcModel
 
 
@@ -12,14 +8,3 @@ class RpcOrganizationSlugReservation(RpcModel):
     slug: str
     cell_name: str
     reservation_type: int
-
-    @root_validator(pre=True)
-    @classmethod
-    def _accept_region_name(cls, values: dict[str, Any]) -> dict[str, Any]:
-        if "region_name" in values and "cell_name" not in values:
-            values["cell_name"] = values.pop("region_name")
-        return values
-
-    @property
-    def region_name(self) -> str:
-        return self.cell_name

src/sentry/hybridcloud/services/replica/impl.py

@@ -296,7 +296,7 @@ def upsert_replicated_org_slug_reservation(
                 slug=slug_reservation.slug,
                 organization_id=slug_reservation.organization_id,
                 user_id=slug_reservation.user_id,
-                cell_name=slug_reservation.region_name,
+                cell_name=slug_reservation.cell_name,
                 reservation_type=slug_reservation.reservation_type,
                 organization_slug_reservation_id=slug_reservation.id,
             )

src/sentry/identity/oauth2.py

@@ -32,6 +32,7 @@
     IntegrationPipelineViewEvent,
     IntegrationPipelineViewType,
 )
+from sentry.pipeline.base import Pipeline
 from sentry.pipeline.types import PipelineStepResult
 from sentry.pipeline.views.base import PipelineView
 from sentry.shared_integrations.exceptions import ApiError, ApiInvalidRequestError, ApiUnauthorized
@@ -282,7 +283,7 @@ def __init__(
         self.bind_key = bind_key
         self.extra_authorize_params = extra_authorize_params or {}
 
-    def get_step_data(self, pipeline: Any, request: HttpRequest) -> dict[str, str]:
+    def get_step_data(self, pipeline: Pipeline[Any, Any], request: HttpRequest) -> dict[str, str]:
         params = urlencode(
             {
                 "client_id": self.client_id,
@@ -301,7 +302,7 @@ def get_serializer_cls(self) -> type:
     def handle_post(
         self,
         validated_data: dict[str, str],
-        pipeline: Any,
+        pipeline: Pipeline[Any, Any],
         request: HttpRequest,
     ) -> PipelineStepResult:
         code = validated_data["code"]

src/sentry/integrations/base.py

@@ -240,11 +240,15 @@ class is just a descriptor for how that object functions, and what behavior
     the installer's identity to the organization integration
     """
 
-    is_cell_restricted: bool = False
-    """
-    Returns True if each integration installation can only be connected on one cell of Sentry at a
-    time. It will raise an error if any organization from another cell attempts to install it.
-    """
+    # TODO(cells): Remove once jira integration is updated and works for multi-cell.
+    # No integrations should be cell restricted.
+    @property
+    def is_cell_restricted(self) -> bool:
+        """
+        Returns True if each integration installation can only be connected on one cell of Sentry at a
+        time. It will raise an error if any organization from another cell attempts to install it.
+        """
+        return False
 
     features: frozenset[IntegrationFeatures] = frozenset()
     """can be any number of IntegrationFeatures"""