feat(refactor): Move common exceptions out of the discover db

Move IssueSearchQueryException to common exceptions module

Remove future annotation

Remove future annotation

Author: manessaraj

src/sentry/incidents/utils/process_update_helpers.py

@@ -5,7 +5,7 @@
 
 from sentry.incidents.utils.types import QuerySubscriptionUpdate
 from sentry.search.eap.utils import add_start_end_conditions
-from sentry.search.events.datasets.discover import InvalidIssueSearchQuery
+from sentry.search.exceptions import InvalidIssueSearchQuery
 from sentry.snuba.dataset import Dataset
 from sentry.snuba.entity_subscription import (
     ENTITY_TIME_COLUMNS,

src/sentry/search/eap/resolver.py

@@ -64,9 +64,9 @@
 from sentry.search.events import constants as qb_constants
 from sentry.search.events import fields
 from sentry.search.events import filter as event_filter
-from sentry.search.events.datasets.discover import InvalidIssueSearchQuery
 from sentry.search.events.filter import to_list
 from sentry.search.events.types import SAMPLING_MODES, SnubaParams
+from sentry.search.exceptions import InvalidIssueSearchQuery
 
 
 def collect_issue_short_ids_from_parsed_terms(terms: Sequence[object]) -> set[str]:

src/sentry/search/events/datasets/discover.py

@@ -95,23 +95,13 @@
 )
 from sentry.search.events.filter import to_list
 from sentry.search.events.types import SelectType, WhereType
+from sentry.search.exceptions import InvalidIssueSearchQuery
 from sentry.search.utils import DEVICE_CLASS
 from sentry.snuba.dataset import Dataset
 from sentry.snuba.referrer import Referrer
 from sentry.utils.numbers import format_grouped_length
 
 
-class InvalidIssueSearchQuery(InvalidSearchQuery):
-    """Raised when an issue filter references non-existent issue IDs."""
-
-    def __init__(self, invalid_ids: list[str]):
-        self.invalid_ids = invalid_ids
-        super().__init__(f"Issue IDs do not exist: {invalid_ids}")
-
-    def __str__(self) -> str:
-        return f"Issue IDs do not exist: {self.invalid_ids}"
-
-
 class DiscoverDatasetConfig(DatasetConfig):
     custom_threshold_columns = {
         "apdex()",

src/sentry/search/exceptions.py

@@ -0,0 +1,12 @@
+from sentry.exceptions import InvalidSearchQuery
+
+
+class InvalidIssueSearchQuery(InvalidSearchQuery):
+    """Raised when an issue filter references non-existent issue IDs."""
+
+    def __init__(self, invalid_ids: list[str]):
+        self.invalid_ids = invalid_ids
+        super().__init__(f"Issue IDs do not exist: {invalid_ids}")
+
+    def __str__(self) -> str:
+        return f"Issue IDs do not exist: {self.invalid_ids}"

tests/sentry/incidents/utils/test_process_update_helpers.py

@@ -5,7 +5,7 @@
 
 from sentry.incidents.utils.process_update_helpers import get_aggregation_value
 from sentry.incidents.utils.types import QuerySubscriptionUpdate
-from sentry.search.events.datasets.discover import InvalidIssueSearchQuery
+from sentry.search.exceptions import InvalidIssueSearchQuery
 from sentry.snuba.dataset import Dataset
 from sentry.snuba.entity_subscription import get_entity_subscription_from_snuba_query
 from sentry.snuba.models import SnubaQuery, SnubaQueryEventType