fix(tracemetrics): Allow sorting on all aggregate columns

narsaynorath · narsaynorath · commit 22d2dc578486 · 2026-04-15T15:15:36.000-04:00
diff --git a/static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx b/static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx
@@ -250,8 +250,6 @@ export function AggregatesTab({traceMetric, isMetricOptionsEmpty}: AggregatesTab
           }
 
           const direction = sorts.find(s => s.field === field)?.kind;
-          const canSort =
-            displayColumns.find(column => column.key === field)?.isSortable !== false;
 
           function updateSort() {
             const kind = direction === 'desc' ? 'asc' : 'desc';
@@ -268,7 +266,7 @@ export function AggregatesTab({traceMetric, isMetricOptionsEmpty}: AggregatesTab
               }
               isSticky={isLastColumn(i)}
               sort={direction}
-              handleSortClick={canSort ? updateSort : undefined}
+              handleSortClick={updateSort}
             >
               <Tooltip showOnlyOnOverflow title={label}>
                 {label}

Original file line number	Diff line number	Diff line change
`@@ -250,8 +250,6 @@ export function AggregatesTab({traceMetric, isMetricOptionsEmpty}: AggregatesTab`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`const direction = sorts.find(s => s.field === field)?.kind;`
`253`		`- const canSort =`
`254`		`- displayColumns.find(column => column.key === field)?.isSortable !== false;`
`255`	`253`
`256`	`254`	`function updateSort() {`
`257`	`255`	`const kind = direction === 'desc' ? 'asc' : 'desc';`
`@@ -268,7 +266,7 @@ export function AggregatesTab({traceMetric, isMetricOptionsEmpty}: AggregatesTab`
`268`	`266`	`}`
`269`	`267`	`isSticky={isLastColumn(i)}`
`270`	`268`	`sort={direction}`
`271`		`- handleSortClick={canSort ? updateSort : undefined}`
	`269`	`+ handleSortClick={updateSort}`
`272`	`270`	`>`
`273`	`271`	`<Tooltip showOnlyOnOverflow title={label}>`
`274`	`272`	`{label}`