Merge branch 'master' into jb/cmdk/jsx-poc

Author: JonasBa

.github/CODEOWNERS

@@ -439,6 +439,9 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /static/app/components/loading/                @getsentry/app-frontend
 /static/app/components/events/interfaces/      @getsentry/app-frontend
 /static/app/components/forms/                  @getsentry/app-frontend
+/static/app/components/featureShowcase.mdx     @getsentry/app-frontend
+/static/app/components/featureShowcase.spec.tsx @getsentry/app-frontend
+/static/app/components/featureShowcase.tsx     @getsentry/app-frontend
 /static/app/components/markdownTextArea.tsx    @getsentry/app-frontend
 /static/app/locale.tsx                         @getsentry/app-frontend
 ## End of Frontend

knip.config.ts

@@ -25,6 +25,8 @@ const productionEntryPoints = [
   'static/app/components/pipeline/**/*.{js,ts,tsx}',
   // TODO: Remove when used
   'static/app/views/seerExplorer/contexts/**/*.{js,ts,tsx}',
+  // TODO: Remove when used
+  'static/app/components/featureShowcase.tsx',
 ];
 
 const testingEntryPoints = [

pyproject.toml

@@ -474,6 +474,7 @@ module = [
   "sentry.identity.vsts_extension.*",
   "sentry.incidents.endpoints.bases",
   "sentry.incidents.handlers.*",
+  "sentry.incidents.metric_issue_detector",
   "sentry.incidents.utils.*",
   "sentry.ingest.slicing",
   "sentry.insights.migrations.*",

src/sentry/api/endpoints/organization_events.py

@@ -25,7 +25,6 @@
 from sentry.apidocs.parameters import GlobalParams, OrganizationParams, VisibilityParams
 from sentry.apidocs.utils import inline_sentry_response_serializer
 from sentry.discover.models import DiscoverSavedQuery, DiscoverSavedQueryTypes
-from sentry.exceptions import InvalidParams
 from sentry.models.dashboard_widget import DashboardWidget, DashboardWidgetTypes
 from sentry.models.organization import Organization
 from sentry.ratelimits.config import RateLimitConfig
@@ -194,8 +193,6 @@ def get(self, request: Request, organization: Organization) -> Response:
                     },
                 }
             )
-        except InvalidParams as err:
-            raise ParseError(detail=str(err))
 
         batch_features = self.get_features(organization, request)
 

src/sentry/api/endpoints/organization_profiling_profiles.py

@@ -1,3 +1,4 @@
+import sentry_sdk
 from django.http import HttpResponse
 from rest_framework import serializers
 from rest_framework.exceptions import ParseError
@@ -77,6 +78,8 @@ def get(self, request: Request, organization: Organization) -> HttpResponse:
             return Response(serializer.errors, status=400)
         serialized = serializer.validated_data
 
+        sentry_sdk.set_tag("query.dataSource", serialized["dataSource"])
+
         with handle_query_errors():
             executor = FlamegraphExecutor(
                 request=request,

src/sentry/api/endpoints/prompts_activity.py

@@ -79,8 +79,7 @@ def get(self, request: Request, organization: Organization, **kwargs) -> Respons
         )
         featuredata = {k.feature: k.data for k in result_qs}
         if len(features) == 1:
-            result = result_qs.first()
-            data = None if result is None else result.data
+            data = featuredata.get(features[0])
             return Response({"data": data, "features": featuredata})
         else:
             return Response({"features": featuredata})

src/sentry/api/endpoints/source_map_debug_blue_thunder_edition.py

@@ -1,6 +1,7 @@
 from typing import Literal, TypedDict
 
 import sentry_sdk
+from django.db.models import Exists, OuterRef
 from django.utils.encoding import force_bytes, force_str
 from drf_spectacular.utils import extend_schema
 from packaging.version import Version
@@ -20,6 +21,7 @@
     ArtifactBundle,
     ArtifactBundleArchive,
     DebugIdArtifactBundle,
+    ProjectArtifactBundle,
     ReleaseArtifactBundle,
     SourceFileType,
 )
@@ -179,11 +181,6 @@ def get(self, request: Request, project: Project, event_id: str) -> Response:
             has_uploaded_artifact_bundle_with_release = ReleaseArtifactBundle.objects.filter(
                 organization_id=project.organization_id, release_name=release.version
             ).exists()
-        has_uploaded_some_artifact_with_a_debug_id = DebugIdArtifactBundle.objects.filter(
-            organization_id=project.organization_id,
-            artifact_bundle__projectartifactbundle__project_id=project.id,
-        ).exists()
-
         debug_images = get_path(event_data, "debug_meta", "images")
         debug_images = debug_images if debug_images is not None else []
 
@@ -212,6 +209,23 @@ def get(self, request: Request, project: Project, event_id: str) -> Response:
             ):
                 debug_ids_with_uploaded_source_map.add(str(debug_id_artifact_bundle.debug_id))
 
+        has_uploaded_some_artifact_with_a_debug_id = bool(
+            debug_ids_with_uploaded_source_file or debug_ids_with_uploaded_source_map
+        ) or (
+            DebugIdArtifactBundle.objects.filter(
+                organization_id=project.organization_id,
+            )
+            .filter(
+                Exists(
+                    ProjectArtifactBundle.objects.filter(
+                        artifact_bundle_id=OuterRef("artifact_bundle_id"),
+                        project_id=project.id,
+                    )
+                )
+            )
+            .exists()
+        )
+
         # Get all abs paths and query for their existence so that we can match release artifacts
         release_process_abs_path_data = {}
         if release is not None:

src/sentry/api/serializers/rest_framework/dashboard.py

@@ -862,6 +862,19 @@ def update_widgets(self, instance, widget_data):
                     # Create a new widget.
                     self.create_widget(instance, data)
                 else:
+                    sentry_sdk.set_context(
+                        "dashboard",
+                        {
+                            "org_slug": instance.organization.slug,
+                            "dashboard_id": instance.id,
+                            "widget_id": widget_id,
+                            "existing_widget_ids": list(existing_map.keys()),
+                            "requested_widget_ids": widget_ids,
+                        },
+                    )
+                    sentry_sdk.capture_message(
+                        "Attempted to update widget not belonging to dashboard."
+                    )
                     raise serializers.ValidationError(
                         "You cannot update widgets that are not part of this dashboard."
                     )

src/sentry/api/urls.py

@@ -377,7 +377,6 @@
 )
 from sentry.issues.endpoints.project_codeowners_details import ProjectCodeOwnersDetailsEndpoint
 from sentry.issues.endpoints.project_codeowners_index import ProjectCodeOwnersEndpoint
-from sentry.issues.endpoints.project_grouping_configs import ProjectGroupingConfigsEndpoint
 from sentry.issues.endpoints.project_issues_resolved_in_release import (
     ProjectIssuesResolvedInReleaseEndpoint,
 )
@@ -3278,12 +3277,6 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
         ProjectRepoPathParsingEndpoint.as_view(),
         name="sentry-api-0-project-repo-path-parsing",
     ),
-    # Grouping configs
-    re_path(
-        r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/grouping-configs/$",
-        ProjectGroupingConfigsEndpoint.as_view(),
-        name="sentry-api-0-project-grouping-configs",
-    ),
     re_path(
         r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/profiling/profiles/(?P<profile_id>(?:\d+|[A-Fa-f0-9-]{32,36}))/$",
         ProjectProfilingProfileEndpoint.as_view(),

src/sentry/apidocs/api_publish_status_allowlist_dont_modify.py

@@ -695,7 +695,6 @@
         "DELETE"
     },
     "/api/0/projects/{organization_id_or_slug}/{project_id_or_slug}/stacktrace-link/": {"GET"},
-    "/api/0/projects/{organization_id_or_slug}/{project_id_or_slug}/grouping-configs/": {"GET"},
     "/api/0/projects/{organization_id_or_slug}/{project_id_or_slug}/appstoreconnect/": {"POST"},
     "/api/0/projects/{organization_id_or_slug}/{project_id_or_slug}/appstoreconnect/apps/": {
         "POST"
@@ -822,8 +821,6 @@
     "/api/0/doc-integrations/{doc_integration_id_or_slug}/avatar/": {"GET", "PUT"},
     "/api/0/integration-features/": {"GET"},
     "/api/0/issue-occurrence/": {"POST"},
-    "/api/0/grouping-configs/": {"GET"},
-    "/api/0/organizations/{organization_id_or_slug}/grouping-configs/": {"GET"},
     "/api/0/builtin-symbol-sources/": {"GET"},
     "/api/0/organizations/{organization_id_or_slug}/builtin-symbol-sources/": {"GET"},
     "/api/0/wizard/": {"GET", "DELETE"},