Skip to content

Commit 1b2ce84

Browse files
committed
Remove useRouter usages from organization stats team insights
1 parent cbb90a8 commit 1b2ce84

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

static/app/views/organizationStats/teamInsights/controls.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@ import {
1515
import {getArbitraryRelativePeriod} from 'sentry/components/timeRangeSelector/utils';
1616
import {t} from 'sentry/locale';
1717
import type {DateString} from 'sentry/types/core';
18-
import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
1918
import type {TeamWithProjects} from 'sentry/types/project';
2019
import {uniq} from 'sentry/utils/array/uniq';
2120
import {isActiveSuperuser} from 'sentry/utils/isActiveSuperuser';
2221
import {localStorageWrapper} from 'sentry/utils/localStorage';
22+
import {useLocation} from 'sentry/utils/useLocation';
23+
import {useNavigate} from 'sentry/utils/useNavigate';
2324
import {useOrganization} from 'sentry/utils/useOrganization';
2425
import {useProjects} from 'sentry/utils/useProjects';
2526

@@ -48,19 +49,19 @@ const PAGE_QUERY_PARAMS = [
4849
'environment',
4950
];
5051

51-
type Props = Pick<RouteComponentProps, 'router' | 'location'> & {
52+
type Props = {
5253
currentEnvironment?: string;
5354
currentTeam?: TeamWithProjects;
5455
showEnvironment?: boolean;
5556
};
5657

5758
export function TeamStatsControls({
58-
location,
59-
router,
6059
currentTeam,
6160
currentEnvironment,
6261
showEnvironment,
6362
}: Props) {
63+
const location = useLocation();
64+
const navigate = useNavigate();
6465
const {projects} = useProjects({
6566
slugs: currentTeam?.projects?.map(project => project.slug) ?? [],
6667
});
@@ -125,7 +126,7 @@ export function TeamStatsControls({
125126
},
126127
};
127128

128-
router.push(nextLocation);
129+
navigate(nextLocation);
129130

130131
return nextLocation;
131132
}

static/app/views/organizationStats/teamInsights/health.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {decodeScalar} from 'sentry/utils/queryString';
1212
import {useRouteAnalyticsEventNames} from 'sentry/utils/routeAnalytics/useRouteAnalyticsEventNames';
1313
import {useLocation} from 'sentry/utils/useLocation';
1414
import {useOrganization} from 'sentry/utils/useOrganization';
15-
import {useRouter} from 'sentry/utils/useRouter';
1615
import {useUserTeams} from 'sentry/utils/useUserTeams';
1716
import {StatsHeader as Header} from 'sentry/views/organizationStats/header';
1817

@@ -25,7 +24,6 @@ import {TeamStability} from './teamStability';
2524
import {dataDatetime} from './utils';
2625

2726
export default function TeamStatsHealth() {
28-
const router = useRouter();
2927
const location = useLocation();
3028
const organization = useOrganization();
3129
const {teams, isLoading, isError} = useUserTeams();
@@ -64,11 +62,7 @@ export default function TeamStatsHealth() {
6462
<Header organization={organization} activeTab="health" />
6563

6664
<div>
67-
<TeamStatsControls
68-
location={location}
69-
router={router}
70-
currentTeam={currentTeam}
71-
/>
65+
<TeamStatsControls currentTeam={currentTeam} />
7266

7367
{isLoading && <LoadingIndicator />}
7468
{!isLoading && (

static/app/views/organizationStats/teamInsights/issues.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {localStorageWrapper} from 'sentry/utils/localStorage';
1111
import {useRouteAnalyticsEventNames} from 'sentry/utils/routeAnalytics/useRouteAnalyticsEventNames';
1212
import {useLocation} from 'sentry/utils/useLocation';
1313
import {useOrganization} from 'sentry/utils/useOrganization';
14-
import {useRouter} from 'sentry/utils/useRouter';
1514
import {useUserTeams} from 'sentry/utils/useUserTeams';
1615
import {StatsHeader as Header} from 'sentry/views/organizationStats/header';
1716

@@ -26,7 +25,6 @@ import {dataDatetime} from './utils';
2625
export default function TeamStatsIssues() {
2726
const organization = useOrganization();
2827
const location = useLocation();
29-
const router = useRouter();
3028
const {teams, isLoading, isError} = useUserTeams();
3129

3230
useRouteAnalyticsEventNames('team_insights.viewed', 'Team Insights: Viewed');
@@ -66,8 +64,6 @@ export default function TeamStatsIssues() {
6664
<div>
6765
<TeamStatsControls
6866
showEnvironment
69-
location={location}
70-
router={router}
7167
currentTeam={currentTeam}
7268
currentEnvironment={environment}
7369
/>

0 commit comments

Comments
 (0)