ref(onboarding): Gate platform detection API call to GitHub provider only (#112269)

The `useScmPlatformDetection` hook fires the platform detection API call
for any connected repository, but the backend only supports GitHub. For
non-GitHub providers (GitLab, Bitbucket, etc.) this causes a pointless
loading spinner followed by an error, then a fallback to the manual
picker.

Gate the query on `repository.provider.id === 'integrations:github'` so
non-GitHub providers skip detection entirely and land directly on the
manual picker with no flash of loading/error UI. Also hides the "Back to
recommended platforms" link when there are no detected platforms to go
back to.

Refs LINEAR-VDY-65

Author: jaydgoss

static/app/views/onboarding/components/useScmPlatformDetection.spec.tsx

@@ -1,12 +1,17 @@
 import {DetectedPlatformFixture} from 'sentry-fixture/detectedPlatform';
 import {OrganizationFixture} from 'sentry-fixture/organization';
+import {RepositoryFixture} from 'sentry-fixture/repository';
 
 import {renderHookWithProviders, waitFor} from 'sentry-test/reactTestingLibrary';
 
 import {useScmPlatformDetection} from './useScmPlatformDetection';
 
 describe('useScmPlatformDetection', () => {
   const organization = OrganizationFixture();
+  const githubRepo = RepositoryFixture({
+    id: '42',
+    provider: {id: 'integrations:github', name: 'GitHub'},
+  });
 
   afterEach(() => {
     MockApiClient.clearMockResponses();
@@ -29,7 +34,7 @@ describe('useScmPlatformDetection', () => {
       body: {platforms: mockPlatforms},
     });
 
-    const {result} = renderHookWithProviders(() => useScmPlatformDetection('42'), {
+    const {result} = renderHookWithProviders(() => useScmPlatformDetection(githubRepo), {
       organization,
     });
 
@@ -38,7 +43,7 @@ describe('useScmPlatformDetection', () => {
     });
   });
 
-  it('returns empty array when repoId is undefined', () => {
+  it('returns empty array when repository is undefined', () => {
     const apiMock = MockApiClient.addMockResponse({
       url: `/organizations/${organization.slug}/repos/undefined/platforms/`,
       body: {platforms: []},
@@ -58,7 +63,7 @@ describe('useScmPlatformDetection', () => {
       body: {platforms: []},
     });
 
-    const {result} = renderHookWithProviders(() => useScmPlatformDetection('42'), {
+    const {result} = renderHookWithProviders(() => useScmPlatformDetection(githubRepo), {
       organization,
     });
 
@@ -72,12 +77,33 @@ describe('useScmPlatformDetection', () => {
       body: {detail: 'Internal Error'},
     });
 
-    const {result} = renderHookWithProviders(() => useScmPlatformDetection('42'), {
+    const {result} = renderHookWithProviders(() => useScmPlatformDetection(githubRepo), {
       organization,
     });
 
     await waitFor(() => {
       expect(result.current.isError).toBe(true);
     });
   });
+
+  it('skips detection for non-GitHub providers', () => {
+    const gitlabRepo = RepositoryFixture({
+      id: '99',
+      provider: {id: 'integrations:gitlab', name: 'GitLab'},
+    });
+
+    const apiMock = MockApiClient.addMockResponse({
+      url: `/organizations/${organization.slug}/repos/99/platforms/`,
+      body: {platforms: []},
+    });
+
+    const {result} = renderHookWithProviders(() => useScmPlatformDetection(gitlabRepo), {
+      organization,
+    });
+
+    expect(apiMock).not.toHaveBeenCalled();
+    expect(result.current.detectedPlatforms).toEqual([]);
+    expect(result.current.isPending).toBe(false);
+    expect(result.current.isError).toBe(false);
+  });
 });

static/app/views/onboarding/components/useScmPlatformDetection.ts

@@ -1,6 +1,8 @@
+import {skipToken, useQuery} from '@tanstack/react-query';
+
+import type {Repository} from 'sentry/types/integrations';
 import type {PlatformKey} from 'sentry/types/project';
-import {getApiUrl} from 'sentry/utils/api/getApiUrl';
-import {fetchDataQuery, useQuery} from 'sentry/utils/queryClient';
+import {apiOptions} from 'sentry/utils/api/apiOptions';
 import {useOrganization} from 'sentry/utils/useOrganization';
 
 export interface DetectedPlatform {
@@ -15,31 +17,31 @@ interface PlatformDetectionResponse {
   platforms: DetectedPlatform[];
 }
 
-export function useScmPlatformDetection(repoId: string | undefined) {
-  const organization = useOrganization();
+const SUPPORTED_PROVIDER = 'integrations:github';
 
-  const query = useQuery({
-    queryKey: [
-      getApiUrl('/organizations/$organizationIdOrSlug/repos/$repoId/platforms/', {
-        path: {
-          organizationIdOrSlug: organization.slug,
-          repoId: repoId!,
-        },
-      }),
-      {method: 'GET'},
-    ] as const,
-    queryFn: async context => {
-      return fetchDataQuery<PlatformDetectionResponse>(context);
-    },
-    staleTime: 30_000,
-    enabled: !!repoId,
-  });
+export function useScmPlatformDetection(repository: Repository | undefined) {
+  const organization = useOrganization();
+  const repoId = repository?.id;
+  const isSupported = repository?.provider.id === SUPPORTED_PROVIDER;
 
-  const {data} = query;
+  const query = useQuery(
+    apiOptions.as<PlatformDetectionResponse>()(
+      '/organizations/$organizationIdOrSlug/repos/$repoId/platforms/',
+      {
+        path:
+          repoId && isSupported
+            ? {organizationIdOrSlug: organization.slug, repoId}
+            : skipToken,
+        staleTime: 30_000,
+      }
+    )
+  );
 
   return {
-    detectedPlatforms: data?.[0]?.platforms ?? [],
-    isPending: query.isPending,
+    detectedPlatforms: query.data?.platforms ?? [],
+    // Use isLoading so that disabled queries (non-GitHub providers)
+    // report false instead of the idle-pending state.
+    isPending: query.isLoading,
     isError: query.isError,
   };
 }

static/app/views/onboarding/scmConnect.tsx

@@ -42,7 +42,7 @@ export function ScmConnect({onComplete}: StepProps) {
   } = useScmProviders();
 
   // Pre-warm platform detection so results are cached when the user advances
-  useScmPlatformDetection(selectedRepository?.id);
+  useScmPlatformDetection(selectedRepository);
 
   // Derive integration from explicit selection, falling back to existing
   const effectiveIntegration = selectedIntegration ?? activeIntegrationExisting;

static/app/views/onboarding/scmPlatformFeatures.spec.tsx

@@ -59,7 +59,10 @@ function makeOnboardingWrapper(initialState?: OnboardingSessionState) {
   };
 }
 
-const mockRepository = RepositoryFixture({id: '42'});
+const mockRepository = RepositoryFixture({
+  id: '42',
+  provider: {id: 'integrations:github', name: 'GitHub'},
+});
 
 describe('ScmPlatformFeatures', () => {
   const organization = OrganizationFixture({

static/app/views/onboarding/scmPlatformFeatures.tsx

@@ -108,7 +108,7 @@ export function ScmPlatformFeatures({onComplete}: StepProps) {
     detectedPlatforms,
     isPending: isDetecting,
     isError: isDetectionError,
-  } = useScmPlatformDetection(hasScmConnected ? selectedRepository.id : undefined);
+  } = useScmPlatformDetection(selectedRepository);
 
   const currentFeatures = useMemo(
     () => selectedFeatures ?? [ProductSolution.ERROR_MONITORING],
@@ -445,7 +445,7 @@ export function ScmPlatformFeatures({onComplete}: StepProps) {
               }}
               styles={{container: base => ({...base, width: '100%'})}}
             />
-            {hasScmConnected && !isDetectionError && (
+            {hasScmConnected && !isDetectionError && hasDetectedPlatforms && (
               <Button size="xs" priority="link" onClick={handleBackToRecommended}>
                 {t('Back to recommended platforms')}
               </Button>