Skip to content

Commit 0edd5d1

Browse files
committed
ref(issues): Remove streamlined UI from event interfaces
1 parent 22867f0 commit 0edd5d1

File tree

4 files changed

+8
-21
lines changed

4 files changed

+8
-21
lines changed

static/app/components/events/interfaces/crashContent/exception/stackTrace.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import type {PlatformKey} from 'sentry/types/project';
1111
import {StackType, StackView} from 'sentry/types/stacktrace';
1212
import {defined} from 'sentry/utils';
1313
import {isNativePlatform} from 'sentry/utils/platform';
14-
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
1514

1615
type Props = {
1716
chainedException: boolean;
@@ -44,7 +43,6 @@ export function StackTrace({
4443
frameSourceMapDebuggerData,
4544
stackType,
4645
}: Props) {
47-
const hasStreamlinedUI = useHasStreamlinedUI();
4846
if (!defined(stacktrace)) {
4947
return null;
5048
}
@@ -90,7 +88,7 @@ export function StackTrace({
9088
newestFirst={newestFirst}
9189
event={event}
9290
meta={meta}
93-
hideIcon={hasStreamlinedUI}
91+
hideIcon
9492
/>
9593
);
9694
}
@@ -107,7 +105,7 @@ export function StackTrace({
107105
threadId={threadId}
108106
frameSourceMapDebuggerData={frameSourceMapDebuggerData}
109107
hideSourceMapDebugger={stackType === StackType.MINIFIED}
110-
hideIcon={hasStreamlinedUI}
108+
hideIcon
111109
/>
112110
);
113111
}

static/app/components/events/interfaces/crashContent/stackTrace/index.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import type {PlatformKey} from 'sentry/types/project';
66
import type {StacktraceType} from 'sentry/types/stacktrace';
77
import {StackView} from 'sentry/types/stacktrace';
88
import {isNativePlatform} from 'sentry/utils/platform';
9-
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
109

1110
import {Content} from './content';
1211
import {NativeContent} from './nativeContent';
@@ -39,7 +38,6 @@ export function StackTraceContent({
3938
threadId,
4039
lockAddress,
4140
}: Props) {
42-
const hasStreamlinedUI = useHasStreamlinedUI();
4341
if (stackView === StackView.RAW) {
4442
return (
4543
<ErrorBoundary mini>
@@ -62,7 +60,7 @@ export function StackTraceContent({
6260
groupingCurrentLevel={groupingCurrentLevel}
6361
meta={meta}
6462
inlined={inlined}
65-
hideIcon={inlined || hasStreamlinedUI}
63+
hideIcon
6664
maxDepth={maxDepth}
6765
/>
6866
</ErrorBoundary>
@@ -79,7 +77,7 @@ export function StackTraceContent({
7977
event={event}
8078
newestFirst={newestFirst}
8179
meta={meta}
82-
hideIcon={inlined || hasStreamlinedUI}
80+
hideIcon
8381
inlined={inlined}
8482
maxDepth={maxDepth}
8583
threadId={threadId}

static/app/components/events/interfaces/exception.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {EntryType} from 'sentry/types/event';
1010
import type {Group} from 'sentry/types/group';
1111
import type {Project} from 'sentry/types/project';
1212
import {SectionDivider} from 'sentry/views/issueDetails/streamline/foldSection';
13-
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
1413

1514
import {ExceptionContent} from './crashContent/exception';
1615
import {NoStackTraceMessage} from './noStackTraceMessage';
@@ -33,8 +32,6 @@ export function Exception({
3332
groupingCurrentLevel,
3433
}: Props) {
3534
const eventHasThreads = !!event.entries.some(entry => entry.type === EntryType.THREADS);
36-
const hasStreamlinedUI = useHasStreamlinedUI();
37-
3835
// in case there are threads in the event data, we don't render the
3936
// exception block. Instead the exception is contained within the
4037
// thread interface.
@@ -106,7 +103,7 @@ export function Exception({
106103
groupingCurrentLevel={groupingCurrentLevel}
107104
meta={meta}
108105
/>
109-
{hasStreamlinedUI && group && (
106+
{group && (
110107
<Fragment>
111108
{data.values && data.values.length > 1 && (
112109
<SectionDivider orientation="horizontal" />

static/app/components/events/interfaces/nativeFrame.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import {useSyncedLocalStorageState} from 'sentry/utils/useSyncedLocalStorageStat
4646
import {withSentryAppComponents} from 'sentry/utils/withSentryAppComponents';
4747
import {SectionKey, useIssueDetails} from 'sentry/views/issueDetails/streamline/context';
4848
import {getFoldSectionKey} from 'sentry/views/issueDetails/streamline/foldSection';
49-
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
5049

5150
import {combineStatus} from './debugMeta/utils';
5251
import {Context} from './frame/context';
@@ -112,8 +111,6 @@ function NativeFrame({
112111
getFoldSectionKey(SectionKey.DEBUGMETA),
113112
debugSectionConfig?.initialCollapse ?? false
114113
);
115-
const hasStreamlinedUI = useHasStreamlinedUI();
116-
117114
const fullStackTrace = stackView === StackView.FULL;
118115

119116
const absolute = displayOptions.includes('absolute-addresses');
@@ -127,8 +124,7 @@ function NativeFrame({
127124
!!frame.symbolicatorStatus &&
128125
frame.symbolicatorStatus !== SymbolicatorStatus.UNKNOWN_IMAGE &&
129126
!isHoverPreviewed &&
130-
// We know the debug section is rendered (only once streamline ui is enabled)
131-
(hasStreamlinedUI ? !!debugSectionConfig : true);
127+
!!debugSectionConfig;
132128

133129
const leadsToApp = !frame.inApp && (nextFrame?.inApp || !nextFrame);
134130
const expandable = isExpandable({
@@ -255,10 +251,8 @@ function NativeFrame({
255251
DebugMetaStore.updateFilter(searchTerm);
256252
}
257253

258-
if (hasStreamlinedUI) {
259-
// Expand the section
260-
setIsCollapsed(false);
261-
}
254+
// Expand the section
255+
setIsCollapsed(false);
262256

263257
// Scroll to the section
264258
document

0 commit comments

Comments
 (0)