delete

Author: kcons

src/sentry/workflow_engine/endpoints/organization_detector_details.py

@@ -242,4 +242,7 @@ def delete(self, request: Request, organization: Organization, detector: Detecto
 
         Delete a monitor
         """
+        # Intentionally no _check_metric_detector_allowed gate here:
+        # orgs should be able to delete detectors they can no longer use
+        # (e.g. after a plan downgrade).
         return remove_detector(request, organization, detector)

tests/sentry/workflow_engine/endpoints/test_organization_detector_details.py

@@ -1054,6 +1054,15 @@ def test_simple(self, mock_schedule_update_project_config: mock.MagicMock) -> No
         assert self.detector.status == ObjectStatus.PENDING_DELETION
         mock_schedule_update_project_config.assert_called_once_with(self.detector)
 
+    def test_delete_allowed_without_metric_subscription_feature(self) -> None:
+        with self.feature({"organizations:incidents": False}):
+            with outbox_runner():
+                self.get_success_response(self.organization.slug, self.detector.id)
+
+        assert CellScheduledDeletion.objects.filter(
+            model_name="Detector", object_id=self.detector.id
+        ).exists()
+
     def test_error_group_type(self) -> None:
         """
         Test that we do not delete the required error detector