Skip to content

Commit 0d2da12

Browse files
committed
specific
1 parent 3e7afa4 commit 0d2da12

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/sentry/integrations/jira/webhooks/installed.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import sentry_sdk
22
from django.db import router, transaction
3-
from jwt import InvalidKeyError
3+
from jwt import DecodeError, ExpiredSignatureError, InvalidKeyError, InvalidSignatureError
44
from rest_framework import status
55
from rest_framework.request import Request
66
from rest_framework.response import Response
@@ -67,10 +67,15 @@ def post(self, request: Request, *args, **kwargs) -> Response:
6767
return self.respond(
6868
{"detail": "Invalid key id"}, status=status.HTTP_400_BAD_REQUEST
6969
)
70-
except Exception:
71-
lifecycle.record_halt(halt_reason="JWT authentication failed")
70+
except (InvalidSignatureError, ExpiredSignatureError):
71+
lifecycle.record_halt(halt_reason="JWT contained invalid or expired signature")
7272
return self.respond(
73-
{"detail": "JWT authentication failed"}, status=status.HTTP_400_BAD_REQUEST
73+
{"detail": "Invalid or expired signature"}, status=status.HTTP_400_BAD_REQUEST
74+
)
75+
except DecodeError:
76+
lifecycle.record_halt(halt_reason="Could not decode JWT token")
77+
return self.respond(
78+
{"detail": "Could not decode JWT token"}, status=status.HTTP_400_BAD_REQUEST
7479
)
7580

7681
data = JiraIntegrationProvider().build_integration(state)

0 commit comments

Comments
 (0)