fix deletion

Author: kcons

src/sentry/deletions/defaults/alertrule.py

@@ -1,5 +1,10 @@
 from sentry.deletions.base import BaseRelation, ModelDeletionTask, ModelRelation
 from sentry.incidents.models.alert_rule import AlertRule
+from sentry.workflow_engine.models.alertrule_detector import AlertRuleDetector
+
+
+class AlertRuleDetectorDeletionTask(ModelDeletionTask[AlertRuleDetector]):
+    manager_name = "objects_for_deletion"
 
 
 class AlertRuleDeletionTask(ModelDeletionTask[AlertRule]):
@@ -10,7 +15,15 @@ class AlertRuleDeletionTask(ModelDeletionTask[AlertRule]):
     def get_child_relations(self, instance: AlertRule) -> list[BaseRelation]:
         from sentry.incidents.models.alert_rule import AlertRuleTrigger
         from sentry.incidents.models.incident import Incident
-        from sentry.workflow_engine.models import AlertRuleDetector, AlertRuleWorkflow
+        from sentry.workflow_engine.models import AlertRuleWorkflow
 
-        model_list = (AlertRuleTrigger, Incident, AlertRuleDetector, AlertRuleWorkflow)
-        return [ModelRelation(m, {"alert_rule_id": instance.id}) for m in model_list]
+        return [
+            ModelRelation(AlertRuleTrigger, {"alert_rule_id": instance.id}),
+            ModelRelation(Incident, {"alert_rule_id": instance.id}),
+            ModelRelation(
+                AlertRuleDetector,
+                {"alert_rule_id": instance.id},
+                task=AlertRuleDetectorDeletionTask,
+            ),
+            ModelRelation(AlertRuleWorkflow, {"alert_rule_id": instance.id}),
+        ]

src/sentry/deletions/defaults/rule.py

@@ -2,6 +2,7 @@
 from collections.abc import Sequence
 
 from sentry.deletions.base import BaseRelation, ModelDeletionTask, ModelRelation
+from sentry.deletions.defaults.alertrule import AlertRuleDetectorDeletionTask
 from sentry.models.rule import Rule
 from sentry.workflow_engine.models import Workflow
 
@@ -19,7 +20,11 @@ def get_child_relations(self, instance: Rule) -> list[BaseRelation]:
             ModelRelation(GroupRuleStatus, {"rule_id": instance.id}),
             ModelRelation(RuleFireHistory, {"rule_id": instance.id}),
             ModelRelation(RuleActivity, {"rule_id": instance.id}),
-            ModelRelation(AlertRuleDetector, {"rule_id": instance.id}),
+            ModelRelation(
+                AlertRuleDetector,
+                {"rule_id": instance.id},
+                task=AlertRuleDetectorDeletionTask,
+            ),
         ]
 
         alert_rule_workflow = AlertRuleWorkflow.objects.filter(rule_id=instance.id).first()