Commit 0bce46d
committed
ref(github): Address review nits on paginated repos
Document cache consistency caveat in get_repositories_paginated
docstring: cache expiry between pages can cause duplicates/skips,
acceptable for infinite-scroll.
Make _parse_cursor a staticmethod. Add comment clarifying per_page
and offset are guaranteed set when paginated is not None.
Refs VDY-461 parent 50e1bd8 commit 0bce46d
File tree
2 files changed
+7
-2
lines changed- src/sentry/integrations
- api/endpoints
- github
2 files changed
+7
-2
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
142 | 143 | | |
143 | 144 | | |
144 | 145 | | |
145 | | - | |
| 146 | + | |
| 147 | + | |
146 | 148 | | |
147 | 149 | | |
148 | 150 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | | - | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
383 | 386 | | |
384 | 387 | | |
385 | 388 | | |
| |||
0 commit comments