Skip to content

Commit 0865dc6

Browse files
ref(dynamic-sampling): Remove canSubmit from submit buttons
The submit button should always be clickable so users can trigger validation and see errors. Only disable based on access permissions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 9e6c294 commit 0865dc6

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

static/app/views/settings/dynamicSampling/organizationSampling.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ export function OrganizationSampling() {
8282

8383
return (
8484
<form.AppForm form={form}>
85-
<form.Subscribe selector={s => ({isDirty: s.isDirty, canSubmit: s.canSubmit})}>
86-
{({isDirty, canSubmit}) => (
85+
<form.Subscribe selector={s => ({isDirty: s.isDirty})}>
86+
{({isDirty}) => (
8787
<Fragment>
8888
<OnRouteLeave
8989
message={UNSAVED_CHANGES_MESSAGE}
@@ -123,10 +123,7 @@ export function OrganizationSampling() {
123123
'You do not have permission to update these settings.'
124124
)}
125125
>
126-
<form.SubmitButton
127-
disabled={!hasAccess || !canSubmit}
128-
formNoValidate
129-
>
126+
<form.SubmitButton disabled={!hasAccess} formNoValidate>
130127
{t('Apply Changes')}
131128
</form.SubmitButton>
132129
</Tooltip>

static/app/views/settings/dynamicSampling/projectSampling.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,11 @@ export function ProjectSampling() {
126126
<form.Subscribe
127127
selector={s => ({
128128
isDirty: s.isDirty,
129-
canSubmit: s.canSubmit,
130129
currentProjectRates: s.values.projectRates,
131130
fieldMeta: s.fieldMeta,
132131
})}
133132
>
134-
{({isDirty, canSubmit, currentProjectRates, fieldMeta}) => {
133+
{({isDirty, currentProjectRates, fieldMeta}) => {
135134
const projectErrors: Record<string, string | undefined> = {};
136135
for (const id of Object.keys(currentProjectRates)) {
137136
const error = fieldMeta[`projectRates.${id}`]?.errors?.[0]?.message;
@@ -177,10 +176,7 @@ export function ProjectSampling() {
177176
>
178177
{t('Reset')}
179178
</Button>
180-
<form.SubmitButton
181-
disabled={!hasAccess || !canSubmit}
182-
formNoValidate
183-
>
179+
<form.SubmitButton disabled={!hasAccess} formNoValidate>
184180
{t('Apply Changes')}
185181
</form.SubmitButton>
186182
</Fragment>

0 commit comments

Comments
 (0)