Skip to content

Commit cac2a68

Browse files
authored
fix: Rename internal SetupLogging to SetupUnityLogging (#2096)
1 parent 3e02634 commit cac2a68

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/Sentry.Unity/ScriptableSentryUnityOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ internal SentryUnityOptions ToSentryUnityOptions(bool isBuilding, ISentryUnityIn
224224

225225
// We need to set up logging here because the configure callback might have changed the debug options.
226226
// Without setting up here we might miss out on logs between option-loading (now) and Init - i.e. native configuration
227-
options.SetupLogging();
227+
options.SetupUnityLogging();
228228

229229
if (options.AttachViewHierarchy)
230230
{

src/Sentry.Unity/SentryUnityOptionsExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ internal static bool IsValid(this SentryUnityOptions options)
4747
return true;
4848
}
4949

50-
internal static void SetupLogging(this SentryUnityOptions options)
50+
internal static void SetupUnityLogging(this SentryUnityOptions options)
5151
{
5252
if (options.Debug)
5353
{

src/Sentry.Unity/SentryUnitySDK.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ private SentryUnitySdk(SentryUnityOptions options)
2222
{
2323
var unitySdk = new SentryUnitySdk(options);
2424

25-
options.SetupLogging();
25+
options.SetupUnityLogging();
2626
if (!options.ShouldInitializeSdk())
2727
{
2828
return null;

test/Sentry.Unity.Tests/SentryUnityOptionsExtensionsTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public void SetupLogging_DebugAndNoDiagnosticLogger_SetsUnityLogger()
9999

100100
Assert.IsNull(options.DiagnosticLogger); // Sanity check
101101

102-
options.SetupLogging();
102+
options.SetupUnityLogging();
103103

104104
Assert.IsInstanceOf<UnityLogger>(options.DiagnosticLogger);
105105
}
@@ -111,7 +111,7 @@ public void SetupLogging_DebugFalse_DiagnosticLoggerIsNull()
111111
var options = _fixture.GetSut();
112112
options.DiagnosticLogger = new UnityLogger(options);
113113

114-
options.SetupLogging();
114+
options.SetupUnityLogging();
115115

116116
Assert.IsNull(options.DiagnosticLogger);
117117
}
@@ -125,7 +125,7 @@ public void SetupLogging_DiagnosticLoggerSet_LeavesOrRemovesDiagnosticLogger(boo
125125
var options = _fixture.GetSut();
126126
options.DiagnosticLogger = new UnityLogger(options);
127127

128-
options.SetupLogging();
128+
options.SetupUnityLogging();
129129

130130
Assert.AreEqual(debug, options.DiagnosticLogger is not null);
131131
}

0 commit comments

Comments
 (0)