chore(core): Bump sample app to React Native 0.84.1 (#5941)

* chore(core): Bump sample app to React Native 0.84.1

React Native 0.84.1 ships Hermes V1 as the default JS engine.

Changes:
- react-native 0.80.2 -> 0.84.1, react 19.1.0 -> 19.2.3
- Android SDK 35 -> 36, Gradle 8.14.1 -> 9.0.0
- Simplified MainApplication.kt to use new getDefaultReactHost(context, packageList) pattern
  replacing the legacy DefaultReactNativeHost/ReactNativeHost boilerplate
- Updated @react-native/* and @react-native-community/cli devDependencies

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(core): Patch react-native-build-config for Gradle 9 compatibility

Gradle 9 removed jcenter() and deprecated lintOptions.
Apply yarn patch to remove the obsolete buildscript block and
replace lintOptions with lint.

Also includes Xcode project changes from RN 0.84 (RCT_REMOVE_LEGACY_ARCH flag).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(core): Patch react-native-launch-arguments for Gradle 9 compatibility

Gradle 9 removed the `destinationDir` property from JavaCompile tasks.
Use `destinationDirectory` instead.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore(core): Bump react-native-reanimated to 4.3.0 for RN 0.84 support

Reanimated 3.x uses legacy arch APIs (LayoutAnimationController,
UIManagerModuleListener) that were removed in RN 0.84.
Reanimated 4.x supports RN 0.81-0.85.

Also adds react-native-worklets 0.8.1 as required peer dependency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(core): Replace deprecated rncore.h with FBReactNativeSpec.h

rncore.h is deprecated in RN 0.84 and triggers -Werror.
Replace with FBReactNativeSpec.h and FBReactNativeSpec_ModuleProvider.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Lint issue

* fix(ci): Bump Node to 22 in sample app CI workflows

RN 0.84 requires Node >= 22.11. Metro from RN 0.84 uses
Array.toReversed() which is not available in Node 18.

Bump Node version for the Bundle job in buildandtest.yml and
all jobs in sample-application.yml that run Metro bundling.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ios): Fix podspec compiler flags being overridden by install_modules_dependencies

`s.compiler_flags` was silently overridden by `install_modules_dependencies()`,
so `-DSENTRY_PROFILING_SUPPORTED`, `-DNEW_HERMES_RUNTIME`, and
`-DRCT_NEW_ARCH_ENABLED` were never applied. Add flags to
`pod_target_xcconfig['OTHER_CFLAGS']` which takes effect correctly.

Also set `REACT_NATIVE_NODE_MODULES_DIR` in the sample app's Podfile
and pod-install script so the podspec detects the app's RN version
instead of the SDK's devDependency version in the monorepo.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* revert: Remove redundant OTHER_CFLAGS from pod_target_xcconfig

The compiler flags (SENTRY_PROFILING_SUPPORTED, NEW_HERMES_RUNTIME, etc.)
are already applied per-file via s.compiler_flags, which
install_modules_dependencies preserves. Adding them to pod_target_xcconfig
was redundant.

The actual fix for the iOS build was the REACT_NATIVE_NODE_MODULES_DIR
env var in the Podfile, which ensures the podspec detects the app's
RN version instead of the SDK's devDependency version in the monorepo.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor(core): Remove yarn patches in favor of version bumps and dep removal

- Remove react-native-build-config dependency entirely. It was
  unmaintained (uses jcenter, Gradle 1.3) and only used to read
  one Android BuildConfig field. Use react-native-launch-arguments
  for both platforms instead.
- Bump react-native-launch-arguments to 4.1.1 which has the
  Gradle 9 fix (destinationDirectory) built-in.
- Remove both yarn patch files and resolutions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(ci): Remove legacy arch from sample app CI matrix

RN 0.84 and Reanimated 4 require the New Architecture.
Legacy arch builds fail with: "Reanimated requires the New Architecture
to be enabled".

Also remove dynamic-frameworks variant since it was previously excluded
for new arch.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(core): Fix tsconfig resolution and Detox R8 error for RN 0.84

- Use bare specifier in tsconfig extends (`@react-native/typescript-config`
  instead of `@react-native/typescript-config/tsconfig.json`). Node 22
  strictly enforces the package's `exports` field, and ts-jest couldn't
  resolve the direct file path.

- Add proguard `-dontwarn` for `NotThreadSafeBridgeIdleDebugListener`
  which Detox references but was removed in RN 0.84.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(core): Restore react-native-build-config and update Node constraints

- Re-add react-native-build-config with yarn patch for Gradle 9 compat.
  The Android BuildConfig.SENTRY_DISABLE_NATIVE_START is a build-time
  flag that can't be replaced by runtime launch arguments.
- Restore original platform-specific shouldUseAutoStart() logic.
- Update engines.node to >=22.11.0 and volta node to 22.22.2
  to match RN 0.84 requirements.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: antonis

.github/workflows/buildandtest.yml

@@ -246,7 +246,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
       - name: Install Dependencies

.github/workflows/sample-application.yml

@@ -57,12 +57,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        rn-architecture: ['legacy', 'new']
-        ios-use-frameworks: ['no-frameworks', 'dynamic-frameworks']
+        rn-architecture: ['new']
+        ios-use-frameworks: ['no-frameworks']
         build-type: ['dev', 'production']
-        exclude:
-          - rn-architecture: 'new'
-            ios-use-frameworks: 'dynamic-frameworks'
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
@@ -72,7 +69,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
 
@@ -152,7 +149,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        rn-architecture: ['legacy', 'new']
+        rn-architecture: ['new']
         build-type: ['dev', 'production']
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -163,7 +160,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
 
@@ -238,7 +235,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
 
@@ -325,7 +322,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
 
@@ -407,7 +404,7 @@ jobs:
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
         with:
           package-manager-cache: false
-          node-version: 18
+          node-version: 22
           cache: 'yarn'
           cache-dependency-path: yarn.lock
 

.yarn/patches/react-native-build-config-npm-0.3.2-0e671629bd.patch

@@ -0,0 +1,27 @@
+diff --git a/android/build.gradle b/android/build.gradle
+index 8eb2638fe8f4eddfe5daaa3d54ba39cf4e11e6f8..f7d77d75f57004438998cded63ce694d0753dcf4 100644
+--- a/android/build.gradle
++++ b/android/build.gradle
+@@ -1,13 +1,3 @@
+-buildscript {
+-    repositories {
+-        jcenter()
+-    }
+-
+-    dependencies {
+-        classpath 'com.android.tools.build:gradle:1.3.0'
+-    }
+-}
+-
+ apply plugin: 'com.android.library'
+
+ android {
+@@ -19,7 +9,7 @@ android {
+         versionCode 1
+         versionName "1.0"
+     }
+-    lintOptions {
++    lint {
+         abortOnError false
+     }
+ }

package.json

@@ -116,6 +116,7 @@
     "@appium/base-driver@npm:10.2.2/path-to-regexp": "^8.4.0",
     "router@npm:2.2.0/path-to-regexp": "^8.4.0",
     "yaml": "^2.8.3",
+    "react-native-build-config@^0.3.2": "patch:react-native-build-config@npm%3A0.3.2#./.yarn/patches/react-native-build-config-npm-0.3.2-0e671629bd.patch",
     "minimatch@npm:5.1.9/brace-expansion": "^2.0.3",
     "minimatch@npm:8.0.7/brace-expansion": "^2.0.3",
     "minimatch@npm:9.0.9/brace-expansion": "^2.0.3",

samples/react-native/android/app/build.gradle

@@ -190,6 +190,7 @@ android {
             signingConfig signingConfigs.debug
             minifyEnabled enableProguardInReleaseBuilds
             proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
+            testProguardFiles "proguard-rules.pro"
             proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"
         }
     }

samples/react-native/android/app/proguard-rules.pro

@@ -12,3 +12,6 @@
 # Detox Release tests were failing on missing kotlin.Result
 # It should be covered by node_modules/detox/android/detox/proguard-rules-app.pro but it seems missing
 -keep class kotlin.** { *; }
+
+# Detox references bridge classes removed in RN 0.84
+-dontwarn com.facebook.react.bridge.NotThreadSafeBridgeIdleDebugListener

samples/react-native/android/app/src/main/java/io/sentry/reactnative/sample/MainApplication.kt

@@ -4,36 +4,23 @@ import android.app.Application
 import com.facebook.react.PackageList
 import com.facebook.react.ReactApplication
 import com.facebook.react.ReactHost
-import com.facebook.react.ReactNativeHost
-import com.facebook.react.ReactPackage
-import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.load
+import com.facebook.react.ReactNativeApplicationEntryPoint.loadReactNative
 import com.facebook.react.defaults.DefaultReactHost.getDefaultReactHost
-import com.facebook.react.defaults.DefaultReactNativeHost
-import com.facebook.react.soloader.OpenSourceMergedSoMapping
-import com.facebook.soloader.SoLoader
 import io.sentry.react.RNSentrySDK
 
 class MainApplication :
     Application(),
     ReactApplication {
-    override val reactNativeHost: ReactNativeHost =
-        object : DefaultReactNativeHost(this) {
-            override fun getPackages(): List<ReactPackage> =
+    override val reactHost: ReactHost by lazy {
+        getDefaultReactHost(
+            context = applicationContext,
+            packageList =
                 PackageList(this).packages.apply {
                     add(SamplePackage())
                     add(TurboSamplePackage())
-                }
-
-            override fun getJSMainModuleName(): String = "index"
-
-            override fun getUseDeveloperSupport(): Boolean = BuildConfig.DEBUG
-
-            override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
-            override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED
-        }
-
-    override val reactHost: ReactHost
-        get() = getDefaultReactHost(applicationContext, reactNativeHost)
+                },
+        )
+    }
 
     override fun onCreate() {
         super.onCreate()
@@ -46,11 +33,7 @@ class MainApplication :
             throw RuntimeException("This was intentional test crash before JS started.")
         }
 
-        SoLoader.init(this, OpenSourceMergedSoMapping)
-        if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
-            // If you opted-in for the New Architecture, we load the native entry point for this app.
-            load()
-        }
+        loadReactNative(this)
     }
 
     private fun shouldCrashOnStart(): Boolean {

samples/react-native/android/app/src/main/jni/OnLoad.cpp

@@ -29,11 +29,11 @@
 
 #include <DefaultComponentsRegistry.h>
 #include <DefaultTurboModuleManagerDelegate.h>
+#include <FBReactNativeSpec.h>
 #include <NativeSampleModule.h>
 #include <autolinking.h>
 #include <fbjni/fbjni.h>
 #include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
-#include <rncore.h>
 
 #ifdef REACT_NATIVE_APP_CODEGEN_HEADER
 #    include REACT_NATIVE_APP_CODEGEN_HEADER
@@ -91,7 +91,7 @@ javaModuleProvider(const std::string &name, const JavaTurboModule::InitParams &p
     // if (module != nullptr) {
     //    return module;
     // }
-    // return rncore_ModuleProvider(name, params);
+    // return FBReactNativeSpec_ModuleProvider(name, params);
 
     // We link app local modules if available
 #ifdef REACT_NATIVE_APP_MODULE_PROVIDER
@@ -102,7 +102,7 @@ javaModuleProvider(const std::string &name, const JavaTurboModule::InitParams &p
 #endif
 
     // We first try to look up core modules
-    if (auto module = rncore_ModuleProvider(name, params)) {
+    if (auto module = FBReactNativeSpec_ModuleProvider(name, params)) {
         return module;
     }
 

samples/react-native/android/build.gradle

@@ -1,10 +1,10 @@
 
 buildscript {
     ext {
-        buildToolsVersion = "35.0.0"
+        buildToolsVersion = "36.0.0"
         minSdkVersion = 24
-        compileSdkVersion = 35
-        targetSdkVersion = 35
+        compileSdkVersion = 36
+        targetSdkVersion = 36
         ndkVersion = "27.1.12297006"
         kotlinVersion = "2.0.21"
     }

samples/react-native/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME