use getDefaultIntegrations to add/not add span streaming integration

Author: Lms24

packages/node-core/src/light/sdk.ts

@@ -39,7 +39,7 @@ import { nativeNodeFetchIntegration } from './integrations/nativeNodeFetchIntegr
 /**
  * Get default integrations for the Light Node-Core SDK.
  */
-export function getDefaultIntegrations(): Integration[] {
+export function getDefaultIntegrations(options?: Options): Integration[] {
   return [
     // Common
     eventFiltersIntegration(),
@@ -61,6 +61,7 @@ export function getDefaultIntegrations(): Integration[] {
     childProcessIntegration(),
     processSessionIntegration(),
     modulesIntegration(),
+    ...(options?.traceLifecycle === 'stream' ? [spanStreamingIntegration()] : []),
   ];
 }
 
@@ -113,10 +114,6 @@ function _init(
     );
   }
 
-  if (options.traceLifecycle === 'stream' && !options.integrations.some(({ name }) => name === 'SpanStreaming')) {
-    options.integrations.push(spanStreamingIntegration());
-  }
-
   applySdkMetadata(options, 'node-light', ['node-core']);
 
   const client = new LightNodeClient(options);

packages/node-core/src/sdk/index.ts

@@ -47,7 +47,7 @@ import { initializeEsmLoader } from './esmLoader';
 /**
  * Get default integrations for the Node-Core SDK.
  */
-export function getDefaultIntegrations(): Integration[] {
+export function getDefaultIntegrations(options?: Options): Integration[] {
   return [
     // Common
     // TODO(v11): Replace with `eventFiltersIntegration` once we remove the deprecated `inboundFiltersIntegration`
@@ -72,6 +72,7 @@ export function getDefaultIntegrations(): Integration[] {
     childProcessIntegration(),
     processSessionIntegration(),
     modulesIntegration(),
+    ...(options?.traceLifecycle === 'stream' ? [spanStreamingIntegration()] : []),
   ];
 }
 
@@ -127,10 +128,6 @@ function _init(
     );
   }
 
-  if (options.traceLifecycle === 'stream' && !options.integrations.some(({ name }) => name === 'SpanStreaming')) {
-    options.integrations.push(spanStreamingIntegration());
-  }
-
   applySdkMetadata(options, 'node-core');
 
   const client = new NodeClient(options);

packages/node-core/test/light/sdk.test.ts

@@ -106,6 +106,20 @@ describe('Light Mode | SDK', () => {
 
       expect(integrationNames).toContain('NodeFetch');
     });
+
+    it('includes spanStreaming integration when traceLifecycle is "stream"', () => {
+      const integrations = Sentry.getDefaultIntegrations({ traceLifecycle: 'stream' });
+      const integrationNames = integrations.map(i => i.name);
+
+      expect(integrationNames).toContain('SpanStreaming');
+    });
+
+    it("doesn't include spanStreaming integration when traceLifecycle is not 'stream'", () => {
+      const integrations = Sentry.getDefaultIntegrations();
+      const integrationNames = integrations.map(i => i.name);
+
+      expect(integrationNames).not.toContain('SpanStreaming');
+    });
   });
 
   describe('isInitialized', () => {

packages/node/src/sdk/index.ts

@@ -1,5 +1,5 @@
 import type { Integration, Options } from '@sentry/core';
-import { applySdkMetadata, hasSpansEnabled } from '@sentry/core';
+import { applySdkMetadata, hasSpansEnabled, spanStreamingIntegration } from '@sentry/core';
 import type { NodeClient } from '@sentry/node-core';
 import {
   getDefaultIntegrations as getNodeCoreDefaultIntegrations,
@@ -33,6 +33,7 @@ export function getDefaultIntegrations(options: Options): Integration[] {
     // This means that generally request isolation will work (because that is done by httpIntegration)
     // But `transactionName` will not be set automatically
     ...(hasSpansEnabled(options) ? getAutoPerformanceIntegrations() : []),
+    ...(options.traceLifecycle === 'stream' ? [spanStreamingIntegration()] : []),
   ];
 }
 

packages/node/test/sdk/init.test.ts

@@ -143,6 +143,28 @@ describe('init()', () => {
         }),
       );
     });
+
+    it('installs spanStreaming integration when traceLifecycle is "stream"', () => {
+      init({ dsn: PUBLIC_DSN, traceLifecycle: 'stream' });
+      const client = getClient();
+
+      expect(client?.getOptions()).toEqual(
+        expect.objectContaining({
+          integrations: expect.arrayContaining([expect.objectContaining({ name: 'SpanStreaming' })]),
+        }),
+      );
+    });
+
+    it("doesn't install spanStreaming integration when traceLifecycle is not 'stream'", () => {
+      init({ dsn: PUBLIC_DSN });
+
+      const client = getClient();
+      expect(client?.getOptions()).toEqual(
+        expect.objectContaining({
+          integrations: expect.not.arrayContaining([expect.objectContaining({ name: 'SpanStreaming' })]),
+        }),
+      );
+    });
   });
 
   describe('OpenTelemetry', () => {