fix(nextjs): Turn off debugID injection if sourcemaps are explicitly disabled (#19010)

This PR adds an additional check to make sure we only inject debug IDs
if sourcemaps are NOT disabled. The issue isn't present when sourcemaps
are enabled and since debug IDs are only relevant for sourcemap
correlation then this should be a safe change AFAIK.

Closes #18983

Author: logaretm

packages/nextjs/src/config/handleRunAfterProductionCompile.ts

@@ -50,7 +50,8 @@ export async function handleRunAfterProductionCompile(
   await sentryBuildPluginManager.telemetry.emitBundlerPluginExecutionSignal();
   await sentryBuildPluginManager.createRelease();
 
-  if (!usesNativeDebugIds) {
+  // Skip debug ID injection if sourcemaps are disabled which are only relevant for sourcemap correlation
+  if (!usesNativeDebugIds && sentryBuildOptions.sourcemaps?.disable !== true) {
     await sentryBuildPluginManager.injectDebugIds([distDir]);
   }
 

packages/nextjs/test/config/handleRunAfterProductionCompile.test.ts

@@ -249,6 +249,62 @@ describe('handleRunAfterProductionCompile', () => {
     });
   });
 
+  describe('sourcemaps disabled', () => {
+    it('skips debug ID injection when sourcemaps.disable is true', async () => {
+      const optionsWithDisabledSourcemaps: SentryBuildOptions = {
+        ...mockSentryBuildOptions,
+        sourcemaps: {
+          disable: true,
+        },
+      };
+
+      await handleRunAfterProductionCompile(
+        {
+          releaseName: 'test-release',
+          distDir: '/path/to/.next',
+          buildTool: 'turbopack',
+        },
+        optionsWithDisabledSourcemaps,
+      );
+
+      expect(mockSentryBuildPluginManager.injectDebugIds).not.toHaveBeenCalled();
+      expect(mockSentryBuildPluginManager.uploadSourcemaps).toHaveBeenCalled();
+    });
+
+    it('still injects debug IDs when sourcemaps.disable is false', async () => {
+      const optionsWithEnabledSourcemaps: SentryBuildOptions = {
+        ...mockSentryBuildOptions,
+        sourcemaps: {
+          disable: false,
+        },
+      };
+
+      await handleRunAfterProductionCompile(
+        {
+          releaseName: 'test-release',
+          distDir: '/path/to/.next',
+          buildTool: 'turbopack',
+        },
+        optionsWithEnabledSourcemaps,
+      );
+
+      expect(mockSentryBuildPluginManager.injectDebugIds).toHaveBeenCalledWith(['/path/to/.next']);
+    });
+
+    it('still injects debug IDs when sourcemaps option is undefined', async () => {
+      await handleRunAfterProductionCompile(
+        {
+          releaseName: 'test-release',
+          distDir: '/path/to/.next',
+          buildTool: 'turbopack',
+        },
+        mockSentryBuildOptions,
+      );
+
+      expect(mockSentryBuildPluginManager.injectDebugIds).toHaveBeenCalledWith(['/path/to/.next']);
+    });
+  });
+
   describe('path handling', () => {
     it('correctly passes distDir to debug ID injection', async () => {
       const customDistDir = '/custom/dist/path';