Filter invalid identifier exports and add typeof guard in RSC utils

Author: onurtemizkan

packages/react-router/src/server/rsc/responseUtils.ts

@@ -39,7 +39,7 @@ export function isNotFoundResponse(error: unknown): boolean {
       return true;
     }
 
-    if (errorObj.status === 404) {
+    if (typeof errorObj.status === 'number' && errorObj.status === 404) {
       return true;
     }
   }

packages/react-router/src/vite/makeAutoInstrumentRSCPlugin.ts

@@ -7,6 +7,7 @@ import type { AutoInstrumentRSCOptions } from './types';
 import t = recast.types.namedTypes;
 
 const JS_EXTENSIONS_RE = /\.(ts|tsx|js|jsx|mjs|mts)$/;
+const JS_IDENTIFIER_RE = /^[a-zA-Z_$][a-zA-Z0-9_$]*$/;
 const WRAPPED_MODULE_SUFFIX = '?sentry-rsc-wrap';
 
 // Prevents the Sentry bundler plugin from transforming this import path
@@ -291,7 +292,9 @@ export function makeAutoInstrumentRSCPlugin(options: AutoInstrumentRSCOptions =
         return null;
       }
 
-      const exportNames = analysis.namedExports;
+      // Skip string literal export names (e.g. `export { fn as "my-action" }`) that
+      // can't be used in `export const name = ...` generated code.
+      const exportNames = analysis.namedExports.filter(name => JS_IDENTIFIER_RE.test(name));
       const includeDefault = analysis.hasDefaultExport;
       if (exportNames.length === 0 && !includeDefault) {
         // eslint-disable-next-line no-console

packages/react-router/test/vite/makeAutoInstrumentRSCPlugin.test.ts

@@ -294,6 +294,16 @@ describe('makeAutoInstrumentRSCPlugin', () => {
       expect(result!.code).toContain('wrapServerFunction');
     });
 
+    it('skips string literal export names that are not valid identifiers', () => {
+      const plugin = createPluginWithRSCDetected();
+      const code = '\'use server\';\nfunction a() {}\nfunction b() {}\nexport { a as "my-action", b }';
+      const result = plugin.transform(code, 'app/routes/rsc/actions.ts');
+
+      expect(result).not.toBeNull();
+      expect(result!.code).toContain('export const b = wrapServerFunction("b"');
+      expect(result!.code).not.toContain('my-action');
+    });
+
     it('does not log when debug is disabled', () => {
       const plugin = createPluginWithRSCDetected({ debug: false });