always set fallback traceLifecycle to 'static'

Author: Lms24

packages/browser/src/integrations/spanstreaming.ts

@@ -27,17 +27,19 @@ export const spanStreamingIntegration = defineIntegration(() => {
     setup(client) {
       const initialMessage = 'SpanStreaming integration requires';
       const fallbackMsg = 'Falling back to static trace lifecycle.';
+      const clientOptions = client.getOptions();
 
       if (!hasSpanStreamingEnabled(client)) {
+        clientOptions.traceLifecycle = 'static';
         DEBUG_BUILD && debug.warn(`${initialMessage} \`traceLifecycle\` to be set to "stream"! ${fallbackMsg}`);
         return;
       }
 
-      const beforeSendSpan = client.getOptions().beforeSendSpan;
+      const beforeSendSpan = clientOptions.beforeSendSpan;
       // If users misconfigure their SDK by opting into span streaming but
       // using an incompatible beforeSendSpan callback, we fall back to the static trace lifecycle.
       if (beforeSendSpan && !isStreamedBeforeSendSpanCallback(beforeSendSpan)) {
-        client.getOptions().traceLifecycle = 'static';
+        clientOptions.traceLifecycle = 'static';
         DEBUG_BUILD &&
           debug.warn(`${initialMessage} a beforeSendSpan callback using \`withStreamedSpan\`! ${fallbackMsg}`);
         return;

packages/browser/test/integrations/spanstreaming.test.ts

@@ -50,25 +50,29 @@ describe('spanStreamingIntegration', () => {
     expect(client.getOptions().traceLifecycle).toBe('stream');
   });
 
-  it('logs a warning if traceLifecycle is not set to "stream"', () => {
-    const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});
-    const client = new BrowserClient({
-      ...getDefaultBrowserClientOptions(),
-      dsn: 'https://username@domain/123',
-      integrations: [spanStreamingIntegration()],
-      traceLifecycle: 'static',
-    });
-
-    SentryCore.setCurrentClient(client);
-    client.init();
-
-    expect(debugSpy).toHaveBeenCalledWith(
-      'SpanStreaming integration requires `traceLifecycle` to be set to "stream"! Falling back to static trace lifecycle.',
-    );
-    debugSpy.mockRestore();
-
-    expect(client.getOptions().traceLifecycle).toBe('static');
-  });
+  it.each(['static', 'somethingElse'])(
+    'logs a warning if traceLifecycle is not set to "stream" but to %s',
+    traceLifecycle => {
+      const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});
+      const client = new BrowserClient({
+        ...getDefaultBrowserClientOptions(),
+        dsn: 'https://username@domain/123',
+        integrations: [spanStreamingIntegration()],
+        // @ts-expect-error - we want to test the warning for invalid traceLifecycle values
+        traceLifecycle,
+      });
+
+      SentryCore.setCurrentClient(client);
+      client.init();
+
+      expect(debugSpy).toHaveBeenCalledWith(
+        'SpanStreaming integration requires `traceLifecycle` to be set to "stream"! Falling back to static trace lifecycle.',
+      );
+      debugSpy.mockRestore();
+
+      expect(client.getOptions().traceLifecycle).toBe('static');
+    },
+  );
 
   it('falls back to static trace lifecycle if beforeSendSpan is not compatible with span streaming', () => {
     const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});

packages/core/src/integrations/spanStreaming.ts

@@ -15,15 +15,17 @@ export const spanStreamingIntegration = defineIntegration(() => {
     setup(client) {
       const initialMessage = 'SpanStreaming integration requires';
       const fallbackMsg = 'Falling back to static trace lifecycle.';
+      const clientOptions = client.getOptions();
 
       if (!hasSpanStreamingEnabled(client)) {
+        clientOptions.traceLifecycle = 'static';
         DEBUG_BUILD && debug.warn(`${initialMessage} \`traceLifecycle\` to be set to "stream"! ${fallbackMsg}`);
         return;
       }
 
-      const beforeSendSpan = client.getOptions().beforeSendSpan;
+      const beforeSendSpan = clientOptions.beforeSendSpan;
       if (beforeSendSpan && !isStreamedBeforeSendSpanCallback(beforeSendSpan)) {
-        client.getOptions().traceLifecycle = 'static';
+        clientOptions.traceLifecycle = 'static';
         DEBUG_BUILD &&
           debug.warn(`${initialMessage} a beforeSendSpan callback using \`withStreamedSpan\`! ${fallbackMsg}`);
         return;

packages/core/test/integrations/spanStreaming.test.ts

@@ -34,25 +34,29 @@ describe('spanStreamingIntegration (core)', () => {
     expect(integration.setup).toBeDefined();
   });
 
-  it('logs a warning if traceLifecycle is not set to "stream"', () => {
-    const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});
-    const client = new TestClient({
-      ...getDefaultTestClientOptions(),
-      dsn: 'https://username@domain/123',
-      integrations: [spanStreamingIntegration()],
-      traceLifecycle: 'static',
-    });
-
-    SentryCore.setCurrentClient(client);
-    client.init();
-
-    expect(debugSpy).toHaveBeenCalledWith(
-      'SpanStreaming integration requires `traceLifecycle` to be set to "stream"! Falling back to static trace lifecycle.',
-    );
-    debugSpy.mockRestore();
-
-    expect(client.getOptions().traceLifecycle).toBe('static');
-  });
+  it.each(['static', 'somethingElse'])(
+    'logs a warning if traceLifecycle is not set to "stream" but to %s',
+    traceLifecycle => {
+      const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});
+      const client = new TestClient({
+        ...getDefaultTestClientOptions(),
+        dsn: 'https://username@domain/123',
+        integrations: [spanStreamingIntegration()],
+        // @ts-expect-error - we want to test the warning for invalid traceLifecycle values
+        traceLifecycle,
+      });
+
+      SentryCore.setCurrentClient(client);
+      client.init();
+
+      expect(debugSpy).toHaveBeenCalledWith(
+        'SpanStreaming integration requires `traceLifecycle` to be set to "stream"! Falling back to static trace lifecycle.',
+      );
+      debugSpy.mockRestore();
+
+      expect(client.getOptions().traceLifecycle).toBe('static');
+    },
+  );
 
   it('falls back to static trace lifecycle if beforeSendSpan is not compatible with span streaming', () => {
     const debugSpy = vi.spyOn(debug, 'warn').mockImplementation(() => {});

packages/node/src/sdk/index.ts

@@ -15,7 +15,7 @@ import { initOpenTelemetry } from './initOtel';
 /**
  * Get default integrations, excluding performance.
  */
-export function getDefaultIntegrationsWithoutPerformance(options: Options): Integration[] {
+export function getDefaultIntegrationsWithoutPerformance(options?: Options | undefined): Integration[] {
   const nodeCoreIntegrations = getNodeCoreDefaultIntegrations(options);
 
   // Filter out the node-core HTTP and NodeFetch integrations and replace them with Node SDK's composite versions