Skip to content

Commit fd452e9

Browse files
romtsnclaude
andcommitted
fix(masking): Remove from opposite set when adding mask/unmask view class
addMaskViewClass now removes from unmaskViewClasses and vice versa, preventing stale entries from silently blocking masking when setMaskAllText(false)/setMaskAllImages(false) is called with defaults. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 700f5d7 commit fd452e9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

sentry/src/main/java/io/sentry/SentryMaskingOptions.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ public Set<String> getMaskViewClasses() {
9393

9494
public void addMaskViewClass(final @NotNull String className) {
9595
this.maskViewClasses.add(className);
96+
this.unmaskViewClasses.remove(className);
9697
}
9798

9899
@NotNull
@@ -102,6 +103,7 @@ public Set<String> getUnmaskViewClasses() {
102103

103104
public void addUnmaskViewClass(final @NotNull String className) {
104105
this.unmaskViewClasses.add(className);
106+
this.maskViewClasses.remove(className);
105107
}
106108

107109
public @Nullable String getMaskViewContainerClass() {

sentry/src/main/java/io/sentry/SentryReplayOptions.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,12 +263,14 @@ public void setMaskAllImages(final boolean maskAllImages) {
263263
public void addMaskViewClass(final @NotNull String className) {
264264
trackCustomMasking();
265265
this.maskViewClasses.add(className);
266+
this.unmaskViewClasses.remove(className);
266267
}
267268

268269
@Override
269270
public void addUnmaskViewClass(final @NotNull String className) {
270271
trackCustomMasking();
271272
this.unmaskViewClasses.add(className);
273+
this.maskViewClasses.remove(className);
272274
}
273275

274276
@ApiStatus.Internal

0 commit comments

Comments
 (0)