Skip to content

Commit e818730

Browse files
adinaueradinauer
committed
rename callback to onOversizedEvent
1 parent 9afb21d commit e818730

File tree

4 files changed

+41
-41
lines changed

4 files changed

+41
-41
lines changed

‎sentry/api/sentry.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3417,7 +3417,7 @@ public class io/sentry/SentryOptions {
34173417
public fun getMaxTraceFileSize ()J
34183418
public fun getModulesLoader ()Lio/sentry/internal/modules/IModulesLoader;
34193419
public fun getOnDiscard ()Lio/sentry/SentryOptions$OnDiscardCallback;
3420-
public fun getOnOversizedError ()Lio/sentry/SentryOptions$OnOversizedErrorCallback;
3420+
public fun getOnOversizedEvent ()Lio/sentry/SentryOptions$OnOversizedEventCallback;
34213421
public fun getOpenTelemetryMode ()Lio/sentry/SentryOpenTelemetryMode;
34223422
public fun getOptionsObservers ()Ljava/util/List;
34233423
public fun getOutboxPath ()Ljava/lang/String;
@@ -3569,7 +3569,7 @@ public class io/sentry/SentryOptions {
35693569
public fun setMaxTraceFileSize (J)V
35703570
public fun setModulesLoader (Lio/sentry/internal/modules/IModulesLoader;)V
35713571
public fun setOnDiscard (Lio/sentry/SentryOptions$OnDiscardCallback;)V
3572-
public fun setOnOversizedError (Lio/sentry/SentryOptions$OnOversizedErrorCallback;)V
3572+
public fun setOnOversizedEvent (Lio/sentry/SentryOptions$OnOversizedEventCallback;)V
35733573
public fun setOpenTelemetryMode (Lio/sentry/SentryOpenTelemetryMode;)V
35743574
public fun setPrintUncaughtStackTrace (Z)V
35753575
public fun setProfileLifecycle (Lio/sentry/ProfileLifecycle;)V
@@ -3680,7 +3680,7 @@ public abstract interface class io/sentry/SentryOptions$OnDiscardCallback {
36803680
public abstract fun execute (Lio/sentry/clientreport/DiscardReason;Lio/sentry/DataCategory;Ljava/lang/Long;)V
36813681
}
36823682

3683-
public abstract interface class io/sentry/SentryOptions$OnOversizedErrorCallback {
3683+
public abstract interface class io/sentry/SentryOptions$OnOversizedEventCallback {
36843684
public abstract fun execute (Lio/sentry/SentryEvent;Lio/sentry/Hint;)Lio/sentry/SentryEvent;
36853685
}
36863686

‎sentry/src/main/java/io/sentry/SentryOptions.java‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ public class SentryOptions {
363363
* Callback invoked when an oversized event is detected. This allows custom handling of oversized
364364
* events before the automatic reduction steps are applied.
365365
*/
366-
private @Nullable OnOversizedErrorCallback onOversizedError;
366+
private @Nullable OnOversizedEventCallback onOversizedEvent;
367367

368368
/** Maximum number of spans that can be atteched to single transaction. */
369369
private int maxSpans = 1000;
@@ -1784,22 +1784,22 @@ public void setEnableEventSizeLimiting(final boolean enableEventSizeLimiting) {
17841784
}
17851785

17861786
/**
1787-
* Returns the onOversizedError callback.
1787+
* Returns the onOversizedEvent callback.
17881788
*
1789-
* @return the onOversizedError callback or null if not set
1789+
* @return the onOversizedEvent callback or null if not set
17901790
*/
1791-
public @Nullable OnOversizedErrorCallback getOnOversizedError() {
1792-
return onOversizedError;
1791+
public @Nullable OnOversizedEventCallback getOnOversizedEvent() {
1792+
return onOversizedEvent;
17931793
}
17941794

17951795
/**
1796-
* Sets the onOversizedError callback. This callback is invoked when an oversized event is
1796+
* Sets the onOversizedEvent callback. This callback is invoked when an oversized event is
17971797
* detected, before the automatic reduction steps are applied.
17981798
*
1799-
* @param onOversizedError the onOversizedError callback
1799+
* @param onOversizedEvent the onOversizedEvent callback
18001800
*/
1801-
public void setOnOversizedError(@Nullable OnOversizedErrorCallback onOversizedError) {
1802-
this.onOversizedError = onOversizedError;
1801+
public void setOnOversizedEvent(@Nullable OnOversizedEventCallback onOversizedEvent) {
1802+
this.onOversizedEvent = onOversizedEvent;
18031803
}
18041804

18051805
/**
@@ -3186,8 +3186,8 @@ public interface BeforeBreadcrumbCallback {
31863186
Breadcrumb execute(@NotNull Breadcrumb breadcrumb, @NotNull Hint hint);
31873187
}
31883188

3189-
/** The OnOversizedError callback */
3190-
public interface OnOversizedErrorCallback {
3189+
/** The OnOversizedEvent callback */
3190+
public interface OnOversizedEventCallback {
31913191

31923192
/**
31933193
* Called when an oversized event is detected. This callback allows custom handling of oversized

‎sentry/src/main/java/io/sentry/util/EventSizeLimitingUtils.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ private EventSizeLimitingUtils() {}
5858

5959
@NotNull SentryEvent reducedEvent = event;
6060

61-
final @Nullable SentryOptions.OnOversizedErrorCallback callback =
62-
options.getOnOversizedError();
61+
final @Nullable SentryOptions.OnOversizedEventCallback callback =
62+
options.getOnOversizedEvent();
6363
if (callback != null) {
6464
try {
6565
reducedEvent = callback.execute(reducedEvent, hint);
@@ -71,7 +71,7 @@ private EventSizeLimitingUtils() {}
7171
.getLogger()
7272
.log(
7373
SentryLevel.ERROR,
74-
"The onOversizedError callback threw an exception. It will be ignored and automatic reduction will continue.",
74+
"The onOversizedEvent callback threw an exception. It will be ignored and automatic reduction will continue.",
7575
e);
7676
reducedEvent = event;
7777
}

‎sentry/src/test/java/io/sentry/EventSizeLimitingUtilsTest.kt‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -137,12 +137,12 @@ class EventSizeLimitingUtilsTest {
137137
}
138138

139139
@Test
140-
fun `invokes onOversizedError callback when event exceeds size limit`() {
140+
fun `invokes onOversizedEvent callback when event exceeds size limit`() {
141141
val options = fixture.getOptions()
142142
var callbackInvoked = false
143143
var receivedEvent: SentryEvent? = null
144144
var receivedHint: Hint? = null
145-
options.setOnOversizedError { event, hint ->
145+
options.setOnOversizedEvent { event, hint ->
146146
callbackInvoked = true
147147
receivedEvent = event
148148
receivedHint = hint
@@ -169,9 +169,9 @@ class EventSizeLimitingUtilsTest {
169169
}
170170

171171
@Test
172-
fun `onOversizedError callback successfully reduces size below limit`() {
172+
fun `onOversizedEvent callback successfully reduces size below limit`() {
173173
val options = fixture.getOptions()
174-
options.setOnOversizedError { event, _ ->
174+
options.setOnOversizedEvent { event, _ ->
175175
// Remove all breadcrumbs to reduce size
176176
event.setBreadcrumbs(null)
177177
event
@@ -195,10 +195,10 @@ class EventSizeLimitingUtilsTest {
195195
}
196196

197197
@Test
198-
fun `onOversizedError callback insufficient reduction continues with automatic steps`() {
198+
fun `onOversizedEvent callback insufficient reduction continues with automatic steps`() {
199199
val options = fixture.getOptions()
200200
var callbackInvoked = false
201-
options.setOnOversizedError { event, _ ->
201+
options.setOnOversizedEvent { event, _ ->
202202
callbackInvoked = true
203203
// Remove only some breadcrumbs, not enough to reduce size below limit
204204
val breadcrumbs = event.getBreadcrumbs()
@@ -231,9 +231,9 @@ class EventSizeLimitingUtilsTest {
231231
}
232232

233233
@Test
234-
fun `onOversizedError callback exception continues with automatic reduction`() {
234+
fun `onOversizedEvent callback exception continues with automatic reduction`() {
235235
val options = fixture.getOptions()
236-
options.setOnOversizedError { _, _ -> throw RuntimeException("Callback error") }
236+
options.setOnOversizedEvent { _, _ -> throw RuntimeException("Callback error") }
237237
val event = createLargeEvent()
238238

239239
// Add breadcrumbs to make it large
@@ -252,10 +252,10 @@ class EventSizeLimitingUtilsTest {
252252
}
253253

254254
@Test
255-
fun `onOversizedError callback not invoked when event is below size limit`() {
255+
fun `onOversizedEvent callback not invoked when event is below size limit`() {
256256
val options = fixture.getOptions()
257257
var callbackInvoked = false
258-
options.setOnOversizedError { _, _ ->
258+
options.setOnOversizedEvent { _, _ ->
259259
callbackInvoked = true
260260
SentryEvent()
261261
}
@@ -271,11 +271,11 @@ class EventSizeLimitingUtilsTest {
271271
}
272272

273273
@Test
274-
fun `onOversizedError callback not invoked when event size limiting is disabled`() {
274+
fun `onOversizedEvent callback not invoked when event size limiting is disabled`() {
275275
val options = SentryOptions()
276276
options.isEnableEventSizeLimiting = false
277277
var callbackInvoked = false
278-
options.setOnOversizedError { _, _ ->
278+
options.setOnOversizedEvent { _, _ ->
279279
callbackInvoked = true
280280
SentryEvent()
281281
}
@@ -298,14 +298,14 @@ class EventSizeLimitingUtilsTest {
298298
}
299299

300300
@Test
301-
fun `onOversizedError callback can replace event with a different event`() {
301+
fun `onOversizedEvent callback can replace event with a different event`() {
302302
val options = fixture.getOptions()
303303
val replacementEvent = SentryEvent()
304304
val replacementMessage = Message()
305305
replacementMessage.message = "Replacement event"
306306
replacementEvent.setMessage(replacementMessage)
307307
var callbackInvoked = false
308-
options.setOnOversizedError { _, _ ->
308+
options.setOnOversizedEvent { _, _ ->
309309
callbackInvoked = true
310310
replacementEvent // Return a completely different event
311311
}
@@ -327,10 +327,10 @@ class EventSizeLimitingUtilsTest {
327327
}
328328

329329
@Test
330-
fun `onOversizedError callback returning same event unchanged continues with automatic reduction`() {
330+
fun `onOversizedEvent callback returning same event unchanged continues with automatic reduction`() {
331331
val options = fixture.getOptions()
332332
var callbackInvoked = false
333-
options.setOnOversizedError { event, _ ->
333+
options.setOnOversizedEvent { event, _ ->
334334
callbackInvoked = true
335335
event // Return the same event without modifications
336336
}
@@ -353,10 +353,10 @@ class EventSizeLimitingUtilsTest {
353353
}
354354

355355
@Test
356-
fun `onOversizedError callback receives correct hint object`() {
356+
fun `onOversizedEvent callback receives correct hint object`() {
357357
val options = fixture.getOptions()
358358
var receivedHint: Hint? = null
359-
options.setOnOversizedError { event, hint ->
359+
options.setOnOversizedEvent { event, hint ->
360360
receivedHint = hint
361361
event
362362
}
@@ -380,9 +380,9 @@ class EventSizeLimitingUtilsTest {
380380
}
381381

382382
@Test
383-
fun `onOversizedError callback can modify extras to reduce size`() {
383+
fun `onOversizedEvent callback can modify extras to reduce size`() {
384384
val options = fixture.getOptions()
385-
options.setOnOversizedError { event, _ ->
385+
options.setOnOversizedEvent { event, _ ->
386386
// Remove extras to reduce size
387387
event.setExtras(null)
388388
event
@@ -402,9 +402,9 @@ class EventSizeLimitingUtilsTest {
402402
}
403403

404404
@Test
405-
fun `onOversizedError callback can modify contexts to reduce size`() {
405+
fun `onOversizedEvent callback can modify contexts to reduce size`() {
406406
val options = fixture.getOptions()
407-
options.setOnOversizedError { event, _ ->
407+
options.setOnOversizedEvent { event, _ ->
408408
// Remove contexts to reduce size
409409
event.contexts.keys().toList().forEach { event.contexts.remove(it) }
410410
event
@@ -426,10 +426,10 @@ class EventSizeLimitingUtilsTest {
426426
}
427427

428428
@Test
429-
fun `onOversizedError callback multiple invocations not expected`() {
429+
fun `onOversizedEvent callback multiple invocations not expected`() {
430430
val options = fixture.getOptions()
431431
var callbackInvocationCount = 0
432-
options.setOnOversizedError { event, _ ->
432+
options.setOnOversizedEvent { event, _ ->
433433
callbackInvocationCount++
434434
event
435435
}

0 commit comments

Comments
 (0)