Address PR comments

markushi · markushi · commit e5cbd5d33b1c · 2025-10-22T12:25:51.000+02:00
diff --git a/sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt b/sentry-android-replay/src/main/java/io/sentry/android/replay/screenshot/CanvasStrategy.kt
@@ -87,9 +87,9 @@ internal class CanvasStrategy(
               synchronized(bitmap) {
                 if (!bitmap.isRecycled) {
                   bitmap.copyPixelsFromBuffer(buffer)
+                  lastCaptureSuccessful.set(true)
                 }
               }
-              lastCaptureSuccessful.set(true)
               screenshotRecorderCallback?.onScreenshotRecorded(bitmap)
             }
           }

Original file line number	Diff line number	Diff line change
`@@ -87,9 +87,9 @@ internal class CanvasStrategy(`
`87`	`87`	`synchronized(bitmap) {`
`88`	`88`	`if (!bitmap.isRecycled) {`
`89`	`89`	`bitmap.copyPixelsFromBuffer(buffer)`
	`90`	`+ lastCaptureSuccessful.set(true)`
`90`	`91`	`}`
`91`	`92`	`}`
`92`		`- lastCaptureSuccessful.set(true)`
`93`	`93`	`screenshotRecorderCallback?.onScreenshotRecorded(bitmap)`
`94`	`94`	`}`
`95`	`95`	`}`