Skip to content

Commit d931ddc

Browse files
committed
implement TombstoneParser as Closable and close the tombstone stream
1 parent 4b1919e commit d931ddc

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/TombstoneIntegration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,9 @@ private void reportAsSentryEvent(ApplicationExitInfo exitInfo, boolean enrich) {
254254
return;
255255
}
256256

257-
final TombstoneParser parser = new TombstoneParser(tombstoneInputStream);
258-
event = parser.parse();
257+
try (final TombstoneParser parser = new TombstoneParser(tombstoneInputStream)) {
258+
event = parser.parse();
259+
}
259260
} catch (IOException e) {
260261
logTombstoneFailure(exitInfo);
261262
return;

sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import io.sentry.protocol.SentryStackFrame;
1212
import io.sentry.protocol.SentryStackTrace;
1313
import io.sentry.protocol.SentryThread;
14+
import java.io.Closeable;
1415
import java.io.IOException;
1516
import java.io.InputStream;
1617
import java.util.ArrayList;
@@ -19,7 +20,7 @@
1920
import java.util.Locale;
2021
import java.util.Map;
2122

22-
public class TombstoneParser {
23+
public class TombstoneParser implements Closeable {
2324

2425
private final InputStream tombstoneStream;
2526
private final Map<String, String> excTypeValueMap = new HashMap<>();
@@ -199,4 +200,9 @@ private DebugMeta createDebugMeta(TombstoneProtos.Tombstone tombstone) {
199200

200201
return debugMeta;
201202
}
203+
204+
@Override
205+
public void close() throws IOException {
206+
tombstoneStream.close();
207+
}
202208
}

0 commit comments

Comments
 (0)