Move logic to event processor

Author: markushi

sentry-android-core/src/main/java/io/sentry/android/core/AnrV2Integration.java

@@ -12,20 +12,9 @@
 import io.sentry.ILogger;
 import io.sentry.IScopes;
 import io.sentry.Integration;
-import io.sentry.ProfileChunk;
-import io.sentry.ProfileContext;
 import io.sentry.SentryEvent;
-import io.sentry.SentryExceptionFactory;
 import io.sentry.SentryLevel;
 import io.sentry.SentryOptions;
-import io.sentry.SentryStackTraceFactory;
-import io.sentry.android.core.anr.AggregatedStackTrace;
-import io.sentry.android.core.anr.AnrCulpritIdentifier;
-import io.sentry.android.core.anr.AnrException;
-import io.sentry.android.core.anr.AnrProfile;
-import io.sentry.android.core.anr.AnrProfileManager;
-import io.sentry.android.core.anr.AnrProfileRotationHelper;
-import io.sentry.android.core.anr.StackTraceConverter;
 import io.sentry.android.core.cache.AndroidEnvelopeCache;
 import io.sentry.android.core.internal.threaddump.Lines;
 import io.sentry.android.core.internal.threaddump.ThreadDumpParser;
@@ -35,12 +24,8 @@
 import io.sentry.protocol.DebugImage;
 import io.sentry.protocol.DebugMeta;
 import io.sentry.protocol.Message;
-import io.sentry.protocol.SentryException;
 import io.sentry.protocol.SentryId;
-import io.sentry.protocol.SentryStackFrame;
-import io.sentry.protocol.SentryStackTrace;
 import io.sentry.protocol.SentryThread;
-import io.sentry.protocol.profiling.SentryProfile;
 import io.sentry.transport.CurrentDateProvider;
 import io.sentry.transport.ICurrentDateProvider;
 import io.sentry.util.HintUtils;
@@ -49,12 +34,9 @@
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.Closeable;
-import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
-import java.util.Arrays;
-import java.util.HashMap;
 import java.util.List;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
@@ -207,111 +189,9 @@ public boolean shouldReportHistorical() {
         }
       }
 
-      if (options.isEnableAnrProfiling()) {
-        applyAnrProfile(isBackground, anrTimestamp, event);
-        // TODO: maybe move to AnrV2EventProcessor instead
-        if (hasOnlySystemFrames(event)) {
-          // By omitting the {{ default }} fingerprint, the stacktrace will be completely ignored
-          // and all events will be grouped
-          // into the same issue
-          event.setFingerprints(
-              Arrays.asList(
-                  "{{ system-frames-only-anr }}",
-                  isBackground ? "background-anr" : "foreground-anr"));
-        }
-      }
-
       return new ApplicationExitInfoHistoryDispatcher.Report(event, hint, anrHint);
     }
 
-    private void applyAnrProfile(
-        final boolean isBackground, final long anrTimestamp, final @NotNull SentryEvent event) {
-
-      // as of now AnrProfilingIntegration only generates profiles in foreground
-      if (isBackground) {
-        return;
-      }
-
-      final @Nullable String cacheDirPath = options.getCacheDirPath();
-      if (cacheDirPath == null) {
-        return;
-      }
-      final @NotNull File cacheDir = new File(cacheDirPath);
-
-      @Nullable AnrProfile anrProfile = null;
-
-      try {
-        final File lastFile = AnrProfileRotationHelper.getLastFile(cacheDir);
-
-        if (lastFile.exists()) {
-          options.getLogger().log(SentryLevel.DEBUG, "Reading ANR profile");
-          try (final AnrProfileManager provider = new AnrProfileManager(options, lastFile)) {
-            anrProfile = provider.load();
-          }
-        } else {
-          options.getLogger().log(SentryLevel.DEBUG, "No ANR profile file found");
-        }
-      } catch (Throwable t) {
-        options.getLogger().log(SentryLevel.INFO, "Could not retrieve ANR profile", t);
-      } finally {
-        if (!AnrProfileRotationHelper.deleteLastFile(cacheDir)) {
-          options.getLogger().log(SentryLevel.INFO, "Could not delete ANR profile file");
-        }
-      }
-
-      if (anrProfile != null) {
-        options.getLogger().log(SentryLevel.INFO, "ANR profile found");
-        if (anrTimestamp >= anrProfile.startTimeMs && anrTimestamp <= anrProfile.endtimeMs) {
-          final @Nullable AggregatedStackTrace culprit =
-              AnrCulpritIdentifier.identify(anrProfile.stacks);
-          if (culprit != null) {
-            final @Nullable SentryId profilerId = captureAnrProfile(anrTimestamp, anrProfile);
-
-            final @NotNull StackTraceElement[] stack = culprit.getStack();
-            if (stack.length > 0) {
-              final StackTraceElement stackTraceElement = culprit.getStack()[0];
-              final String message =
-                  stackTraceElement.getClassName() + "." + stackTraceElement.getMethodName();
-              final AnrException exception = new AnrException(message);
-              exception.setStackTrace(stack);
-
-              // TODO should this be re-used from somewhere else?
-              final SentryExceptionFactory factory =
-                  new SentryExceptionFactory(new SentryStackTraceFactory(options));
-              event.setExceptions(factory.getSentryExceptions(exception));
-              if (profilerId != null) {
-                event.getContexts().setProfile(new ProfileContext(profilerId));
-              }
-            }
-          }
-        } else {
-          options.getLogger().log(SentryLevel.DEBUG, "ANR profile found, but doesn't match");
-        }
-      }
-    }
-
-    @Nullable
-    private SentryId captureAnrProfile(
-        final long anrTimestamp, final @NotNull AnrProfile anrProfile) {
-      final SentryProfile profile = StackTraceConverter.convert(anrProfile);
-      final ProfileChunk chunk =
-          new ProfileChunk(
-              new SentryId(),
-              new SentryId(),
-              null,
-              new HashMap<>(0),
-              anrTimestamp / 1000.0d,
-              ProfileChunk.PLATFORM_JAVA,
-              options);
-      chunk.setSentryProfile(profile);
-      final SentryId profilerId = scopes.captureProfileChunk(chunk);
-      if (SentryId.EMPTY_ID.equals(profilerId)) {
-        return null;
-      } else {
-        return chunk.getProfilerId();
-      }
-    }
-
     private @NotNull ParseResult parseThreadDump(
         final @NotNull ApplicationExitInfo exitInfo, final boolean isBackground) {
       final byte[] dump;
@@ -365,33 +245,6 @@ private byte[] getDumpBytes(final @NotNull InputStream trace) throws IOException
     }
   }
 
-  private static boolean hasOnlySystemFrames(final @NotNull SentryEvent event) {
-    final List<SentryException> exceptions = event.getExceptions();
-    if (exceptions == null || exceptions.isEmpty()) {
-      // No exceptions means we haven't verified frames - don't apply special fingerprinting
-      return false;
-    }
-
-    for (final SentryException exception : exceptions) {
-      final @Nullable SentryStackTrace stacktrace = exception.getStacktrace();
-      if (stacktrace != null) {
-        final @Nullable List<SentryStackFrame> frames = stacktrace.getFrames();
-        if (frames != null && !frames.isEmpty()) {
-          for (final SentryStackFrame frame : frames) {
-            if (frame.isInApp() != null && frame.isInApp()) {
-              return false;
-            }
-            final @Nullable String module = frame.getModule();
-            if (module != null && !AnrCulpritIdentifier.isSystemFrame(frame.getModule())) {
-              return false;
-            }
-          }
-        }
-      }
-    }
-    return true;
-  }
-
   @ApiStatus.Internal
   public static final class AnrV2Hint extends BlockingFlushHint
       implements Backfillable, AbnormalExit {