@@ -2953,7 +2953,7 @@ class ScopesTest {
29532953 }
29542954
29552955 @Test
2956- fun `does not add user fields to log attributes by default ` () {
2956+ fun `adds user fields to log attributes even if sendDefaultPii is false ` () {
29572957 val (sut, mockClient) =
29582958 getEnabledScopes {
29592959 it.logs.isEnabled = true
@@ -2975,9 +2975,17 @@ class ScopesTest {
29752975 check {
29762976 assertEquals(" log message" , it.body)
29772977
2978- assertNull(it.attributes?.get(" user.id" ))
2979- assertNull(it.attributes?.get(" user.name" ))
2980- assertNull(it.attributes?.get(" user.email" ))
2978+ val userId = it.attributes?.get(" user.id" )!!
2979+ assertEquals(" usrid" , userId.value)
2980+ assertEquals(" string" , userId.type)
2981+
2982+ val userName = it.attributes?.get(" user.name" )!!
2983+ assertEquals(" usrname" , userName.value)
2984+ assertEquals(" string" , userName.type)
2985+
2986+ val userEmail = it.attributes?.get(" user.email" )!!
2987+ assertEquals(" user@sentry.io" , userEmail.value)
2988+ assertEquals(" string" , userEmail.type)
29812989 },
29822990 anyOrNull(),
29832991 )
@@ -2988,7 +2996,6 @@ class ScopesTest {
29882996 val (sut, mockClient) =
29892997 getEnabledScopes {
29902998 it.logs.isEnabled = true
2991- it.isSendDefaultPii = true
29922999 it.distinctId = " distinctId"
29933000 }
29943001
@@ -3012,7 +3019,6 @@ class ScopesTest {
30123019 val (sut, mockClient) =
30133020 getEnabledScopes {
30143021 it.logs.isEnabled = true
3015- it.isSendDefaultPii = true
30163022 it.distinctId = null
30173023 }
30183024
@@ -3919,7 +3925,7 @@ class ScopesTest {
39193925 }
39203926
39213927 @Test
3922- fun `does not add user fields to metric attributes by default ` () {
3928+ fun `adds user fields to metric attributes even if sendDefaultPii is false ` () {
39233929 val (sut, mockClient) = getEnabledScopes { it.distinctId = " distinctId" }
39243930
39253931 sut.configureScope { scope ->
@@ -3937,9 +3943,17 @@ class ScopesTest {
39373943 check {
39383944 assertEquals(" metric name" , it.name)
39393945
3940- assertNull(it.attributes?.get(" user.id" ))
3941- assertNull(it.attributes?.get(" user.name" ))
3942- assertNull(it.attributes?.get(" user.email" ))
3946+ val userId = it.attributes?.get(" user.id" )!!
3947+ assertEquals(" usrid" , userId.value)
3948+ assertEquals(" string" , userId.type)
3949+
3950+ val userName = it.attributes?.get(" user.name" )!!
3951+ assertEquals(" usrname" , userName.value)
3952+ assertEquals(" string" , userName.type)
3953+
3954+ val userEmail = it.attributes?.get(" user.email" )!!
3955+ assertEquals(" user@sentry.io" , userEmail.value)
3956+ assertEquals(" string" , userEmail.type)
39433957 },
39443958 anyOrNull(),
39453959 anyOrNull(),
@@ -3948,11 +3962,7 @@ class ScopesTest {
39483962
39493963 @Test
39503964 fun `unset user does provide distinct-id as user-id for metrics` () {
3951- val (sut, mockClient) =
3952- getEnabledScopes {
3953- it.isSendDefaultPii = true
3954- it.distinctId = " distinctId"
3955- }
3965+ val (sut, mockClient) = getEnabledScopes { it.distinctId = " distinctId" }
39563966
39573967 sut.metrics().count(" metric name" )
39583968
@@ -3972,11 +3982,7 @@ class ScopesTest {
39723982
39733983 @Test
39743984 fun `unset user does provide null user-id when distinct-id is missing for metrics` () {
3975- val (sut, mockClient) =
3976- getEnabledScopes {
3977- it.isSendDefaultPii = true
3978- it.distinctId = null
3979- }
3985+ val (sut, mockClient) = getEnabledScopes { it.distinctId = null }
39803986
39813987 sut.metrics().count(" metric name" )
39823988
0 commit comments