Skip to content

Commit 89dd122

Browse files
markushiclaude
andcommitted
refactor(replay): Rename custom masking tracking methods
- customMaskingTagTracked -> customMaskingTracked - trackCustomMaskingTag() -> trackCustomMasking() - resetCustomMaskingTagTracked() -> resetCustomMaskingTracked() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4c17016 commit 89dd122

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

sentry-android-replay/src/main/java/io/sentry/android/replay/viewhierarchy/ComposeViewHierarchyNode.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,12 @@ internal object ComposeViewHierarchyNode {
8585
): Boolean {
8686
val sentryPrivacyModifier = this?.getOrNull(SentryReplayModifiers.SentryPrivacy)
8787
if (sentryPrivacyModifier == "unmask") {
88-
SentryReplayOptions.trackCustomMaskingTag()
88+
SentryReplayOptions.trackCustomMasking()
8989
return false
9090
}
9191

9292
if (sentryPrivacyModifier == "mask") {
93-
SentryReplayOptions.trackCustomMaskingTag()
93+
SentryReplayOptions.trackCustomMasking()
9494
return true
9595
}
9696

sentry-android-replay/src/main/java/io/sentry/android/replay/viewhierarchy/ViewHierarchyNode.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,15 +292,15 @@ internal sealed class ViewHierarchyNode(
292292
(tag as? String)?.lowercase()?.contains(SENTRY_UNMASK_TAG) == true ||
293293
getTag(R.id.sentry_privacy) == "unmask"
294294
) {
295-
SentryReplayOptions.trackCustomMaskingTag()
295+
SentryReplayOptions.trackCustomMasking()
296296
return false
297297
}
298298

299299
if (
300300
(tag as? String)?.lowercase()?.contains(SENTRY_MASK_TAG) == true ||
301301
getTag(R.id.sentry_privacy) == "mask"
302302
) {
303-
SentryReplayOptions.trackCustomMaskingTag()
303+
SentryReplayOptions.trackCustomMasking()
304304
return true
305305
}
306306

sentry/src/main/java/io/sentry/SentryReplayOptions.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
public final class SentryReplayOptions {
2121

2222
private static final String CUSTOM_MASKING_INTEGRATION_NAME = "ReplayCustomMasking";
23-
private static volatile boolean customMaskingTagTracked = false;
23+
private static volatile boolean customMaskingTracked = false;
2424

2525
public static final String TEXT_VIEW_CLASS_NAME = "android.widget.TextView";
2626
public static final String IMAGE_VIEW_CLASS_NAME = "android.widget.ImageView";
@@ -282,7 +282,7 @@ public void setSessionSampleRate(final @Nullable Double sessionSampleRate) {
282282
* <p>Default is enabled.
283283
*/
284284
public void setMaskAllText(final boolean maskAllText) {
285-
trackCustomMaskingTag();
285+
trackCustomMasking();
286286
if (maskAllText) {
287287
maskViewClasses.add(TEXT_VIEW_CLASS_NAME);
288288
unmaskViewClasses.remove(TEXT_VIEW_CLASS_NAME);
@@ -301,7 +301,7 @@ public void setMaskAllText(final boolean maskAllText) {
301301
* <p>Default is enabled.
302302
*/
303303
public void setMaskAllImages(final boolean maskAllImages) {
304-
trackCustomMaskingTag();
304+
trackCustomMasking();
305305
if (maskAllImages) {
306306
maskViewClasses.add(IMAGE_VIEW_CLASS_NAME);
307307
unmaskViewClasses.remove(IMAGE_VIEW_CLASS_NAME);
@@ -317,7 +317,7 @@ public Set<String> getMaskViewClasses() {
317317
}
318318

319319
public void addMaskViewClass(final @NotNull String className) {
320-
trackCustomMaskingTag();
320+
trackCustomMasking();
321321
this.maskViewClasses.add(className);
322322
}
323323

@@ -327,7 +327,7 @@ public Set<String> getUnmaskViewClasses() {
327327
}
328328

329329
public void addUnmaskViewClass(final @NotNull String className) {
330-
trackCustomMaskingTag();
330+
trackCustomMasking();
331331
this.unmaskViewClasses.add(className);
332332
}
333333

@@ -382,16 +382,16 @@ public void setUnmaskViewContainerClass(@NotNull String containerClass) {
382382
}
383383

384384
@ApiStatus.Internal
385-
public static void trackCustomMaskingTag() {
386-
if (!customMaskingTagTracked) {
387-
customMaskingTagTracked = true;
385+
public static void trackCustomMasking() {
386+
if (!customMaskingTracked) {
387+
customMaskingTracked = true;
388388
addIntegrationToSdkVersion(CUSTOM_MASKING_INTEGRATION_NAME);
389389
}
390390
}
391391

392392
@TestOnly
393-
public static void resetCustomMaskingTagTracked() {
394-
customMaskingTagTracked = false;
393+
public static void resetCustomMaskingTracked() {
394+
customMaskingTracked = false;
395395
}
396396

397397
@ApiStatus.Internal

sentry/src/test/java/io/sentry/SentryReplayOptionsTest.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class SentryReplayOptionsTest {
1111
@BeforeTest
1212
fun setup() {
1313
SentryIntegrationPackageStorage.getInstance().clearStorage()
14-
SentryReplayOptions.resetCustomMaskingTagTracked()
14+
SentryReplayOptions.resetCustomMaskingTracked()
1515
}
1616

1717
@Test
@@ -178,15 +178,15 @@ class SentryReplayOptionsTest {
178178
}
179179

180180
@Test
181-
fun `trackCustomMaskingTag adds ReplayCustomMasking integration`() {
182-
SentryReplayOptions.trackCustomMaskingTag()
181+
fun `trackCustomMasking adds ReplayCustomMasking integration`() {
182+
SentryReplayOptions.trackCustomMasking()
183183
assertTrue(hasCustomMaskingIntegration())
184184
}
185185

186186
@Test
187-
fun `trackCustomMaskingTag only adds integration once`() {
188-
SentryReplayOptions.trackCustomMaskingTag()
189-
SentryReplayOptions.trackCustomMaskingTag()
187+
fun `trackCustomMasking only adds integration once`() {
188+
SentryReplayOptions.trackCustomMasking()
189+
SentryReplayOptions.trackCustomMasking()
190190
assertTrue(hasCustomMaskingIntegration())
191191
assertEquals(1, SentryIntegrationPackageStorage.getInstance().integrations.count { it == "ReplayCustomMasking" })
192192
}

0 commit comments

Comments
 (0)