Skip to content

Commit 8499a13

Browse files
committed
remove obsolete TODO RE: mechanism change
1 parent 7edfb15 commit 8499a13

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/internal/tombstone/TombstoneParser.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,6 @@ private static Mechanism createMechanismFromSignalInfo(
140140
final Mechanism mechanism = new Mechanism();
141141
// this follows the current processing triggers strictly, changing any of these
142142
// alters grouping and name (long-term we might want to have a tombstone mechanism)
143-
// TODO: if we align this with ANRv2 this would be overwritten in a BackfillingEventProcessor as
144-
// `ApplicationExitInfo` not sure what the right call is. `ApplicationExitInfo` is
145-
// certainly correct. But `signalhandler` isn't wrong either, since all native crashes
146-
// retrieved via `REASON_CRASH_NATIVE` will be signals. I am not sure what the side-effect
147-
// in ingestion/processing will be if we change the mechanism, but initially i wanted to
148-
// stay close to the Native SDK.
149143
mechanism.setType("signalhandler");
150144
mechanism.setHandled(false);
151145
mechanism.setSynthetic(true);

0 commit comments

Comments
 (0)