performance data collection is now started only when the transaction is sampled

Author: stefanosiano

sentry/src/main/java/io/sentry/SentryTracer.java

@@ -90,8 +90,8 @@ public SentryTracer(
     }
 
     // We are currently sending the performance data only in profiles, but we are always sending
-    // performance measurements.
-    if (compositePerformanceCollector != null) {
+    // performance measurements (frames data in spans).
+    if (compositePerformanceCollector != null && Boolean.TRUE.equals(isSampled())) {
       compositePerformanceCollector.start(this);
     }
 

sentry/src/test/java/io/sentry/SentryTracerTest.kt

@@ -1175,6 +1175,12 @@ class SentryTracerTest {
     verify(fixture.compositePerformanceCollector).start(anyOrNull<ITransaction>())
   }
 
+  @Test
+  fun `when transaction is created, but not sampled, compositePerformanceCollector is not started`() {
+    val transaction = fixture.getSut(samplingDecision = TracesSamplingDecision(false))
+    verify(fixture.compositePerformanceCollector, never()).start(anyOrNull<ITransaction>())
+  }
+
   @Test
   fun `when transaction is created and profiled compositePerformanceCollector is started`() {
     val transaction =