Merge branch 'main' into markushi/fix/undefined-behavior

Author: markushi

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Unreleased
 
+### Improvements
+
+- Avoid forking `rootScopes` for Reactor if current thread has `NoOpScopes` ([#4793](https://github.com/getsentry/sentry-java/pull/4793))
+  - This reduces the SDKs overhead by avoiding unnecessary scope forks
+
+## 8.27.1
+
 ### Fixes
 
 - Do not log if `sentry.properties` in rundir has not been found ([#4929](https://github.com/getsentry/sentry-java/pull/4929))

gradle.properties

@@ -11,7 +11,7 @@ org.jetbrains.dokka.experimental.gradle.pluginMode=V2Enabled
 android.useAndroidX=true
 
 # Release information
-versionName=8.27.0
+versionName=8.27.1
 
 # Override the SDK name on native crashes on Android
 sentryAndroidSdkName=sentry.native.android

sentry-reactor/src/main/java/io/sentry/reactor/SentryReactorThreadLocalAccessor.java

@@ -16,7 +16,7 @@ public Object key() {
 
   @Override
   public IScopes getValue() {
-    return Sentry.getCurrentScopes();
+    return Sentry.getCurrentScopes(false);
   }
 
   @Override

sentry/api/sentry.api

@@ -2631,6 +2631,7 @@ public final class io/sentry/Sentry {
 	public static fun getBaggage ()Lio/sentry/BaggageHeader;
 	public static fun getCurrentHub ()Lio/sentry/IHub;
 	public static fun getCurrentScopes ()Lio/sentry/IScopes;
+	public static fun getCurrentScopes (Z)Lio/sentry/IScopes;
 	public static fun getGlobalScope ()Lio/sentry/IScope;
 	public static fun getLastEventId ()Lio/sentry/protocol/SentryId;
 	public static fun getSpan ()Lio/sentry/ISpan;

sentry/src/main/java/io/sentry/Sentry.java

@@ -97,16 +97,33 @@ private Sentry() {}
     return new HubScopesWrapper(getCurrentScopes());
   }
 
-  @ApiStatus.Internal // exposed for the coroutines integration in SentryContext
+  @ApiStatus.Internal
   @SuppressWarnings("deprecation")
   public static @NotNull IScopes getCurrentScopes() {
+    return getCurrentScopes(true);
+  }
+
+  /**
+   * Returns the current contexts scopes.
+   *
+   * @param ensureForked if true, forks root scopes in case there are no scopes for this context if
+   *     false, returns NoOpScopes if there are no scopes for this context
+   * @return current scopes, a root scopes fork or NoopScopes
+   */
+  @ApiStatus.Internal
+  @SuppressWarnings("deprecation")
+  public static @NotNull IScopes getCurrentScopes(final boolean ensureForked) {
     if (globalHubMode) {
       return rootScopes;
     }
     @Nullable IScopes scopes = getScopesStorage().get();
     if (scopes == null || scopes.isNoOp()) {
-      scopes = rootScopes.forkedScopes("getCurrentScopes");
-      getScopesStorage().set(scopes);
+      if (!ensureForked) {
+        return NoOpScopes.getInstance();
+      } else {
+        scopes = rootScopes.forkedScopes("getCurrentScopes");
+        getScopesStorage().set(scopes);
+      }
     }
     return scopes;
   }

sentry/src/main/java/io/sentry/util/InitUtil.java

@@ -108,12 +108,14 @@ public static IProfileConverter initializeProfileConverter(@NotNull SentryOption
   }
 
   private static boolean shouldInitializeProfiler(@NotNull SentryOptions options) {
-    return options.isContinuousProfilingEnabled()
+    return Platform.isJvm()
+        && options.isContinuousProfilingEnabled()
         && options.getContinuousProfiler() instanceof NoOpContinuousProfiler;
   }
 
   private static boolean shouldInitializeProfileConverter(@NotNull SentryOptions options) {
-    return options.isContinuousProfilingEnabled()
+    return Platform.isJvm()
+        && options.isContinuousProfilingEnabled()
         && options.getProfilerConverter() instanceof NoOpProfileConverter;
   }