Skip to content

Commit 63b3ed9

Browse files
committed
Remove failed frame from snapshot list too
1 parent 26f6e6d commit 63b3ed9

File tree

1 file changed

+2
-1
lines changed
  • sentry-android-replay/src/main/java/io/sentry/android/replay

1 file changed

+2
-1
lines changed

sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayCache.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public class ReplayCache(private val options: SentryOptions, private val replayI
140140
}
141141
// Work on a snapshot of frames to avoid races with writers
142142
val framesSnapshot =
143-
framesLock.acquire().use { if (frames.isEmpty()) emptyList() else frames.toList() }
143+
framesLock.acquire().use { if (frames.isEmpty()) mutableListOf() else frames.toMutableList() }
144144
if (framesSnapshot.isEmpty()) {
145145
options.logger.log(DEBUG, "No captured frames, skipping generating a video segment")
146146
return null
@@ -188,6 +188,7 @@ public class ReplayCache(private val options: SentryOptions, private val replayI
188188
// likelihood of it being able to be encoded later is low
189189
deleteFile(lastFrame.screenshot)
190190
framesLock.acquire().use { frames.remove(lastFrame) }
191+
framesSnapshot.remove(lastFrame)
191192
lastFrame = null
192193
}
193194
}

0 commit comments

Comments
 (0)